Skip to content

Commit b5c0b9f

Browse files
colin2328meta-codesync[bot]
authored andcommitted
add metatls-hostname to supported enable_transport (#1574)
Summary: Pull Request resolved: #1574 as title-> no longer get wraning message Reviewed By: zdevito Differential Revision: D84865706 fbshipit-source-id: d9892bcfe480ff82d27244078dd366460b016e49
1 parent f5edd3a commit b5c0b9f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

python/monarch/_src/actor/actor_mesh.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,12 +392,15 @@ def enable_transport(transport: "ChannelTransport | str") -> None:
392392
393393
Currently only one transport type may be enabled at one time.
394394
In the future we may allow multiple to be enabled.
395+
396+
For Meta usage, use metatls-hostname
395397
"""
396398
if isinstance(transport, str):
397399
transport = {
398400
"tcp": ChannelTransport.TcpWithHostname,
399401
"ipc": ChannelTransport.Unix,
400402
"metatls": ChannelTransport.MetaTlsWithIpV6,
403+
"metatls-hostname": ChannelTransport.MetaTlsWithHostname,
401404
}.get(transport)
402405
if transport is None:
403406
raise ValueError(f"unknown transport: {transport}")

python/monarch/_src/job/meta.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,12 @@
2222
from monarch._src.actor.allocator import AllocateMixin
2323
from monarch._src.actor.host_mesh import host_mesh_from_alloc
2424
from monarch._src.actor.meta.allocator import (
25-
MastAllocatorBase,
2625
MastAllocatorConfig,
2726
MastHostAllocator,
2827
MastHostAllocatorBase,
2928
)
3029

31-
from monarch._src.job.job import BatchJob, enable_transport, JobState, JobTrait
30+
from monarch._src.job.job import BatchJob, JobState, JobTrait
3231

3332
from monarch.tools.commands import create, info, kill
3433
from monarch.tools.components.meta import hyperactor
@@ -40,8 +39,6 @@
4039
from torchx.specs import AppState
4140
from torchx.specs.fb.component_helpers import Packages
4241

43-
enable_transport("metatls")
44-
4542

4643
class _MASTSpec(NamedTuple):
4744
hpcIdentity: str

0 commit comments

Comments
 (0)