MONARCH_HYPERACTOR_UNAWAITED_PYTOKIO_TRACEBACK --> MONARCH_HYPERACTOR_ENABLE_UNAWAITED_PYTHON_TASK_TRACEBACK (#1718)

Summary:
Pull Request resolved: #1718

Rename the environment variable
ghstack-source-id: 320149421
exported-using-ghexport

Reviewed By: vidhyav, mariusae

Differential Revision: D85899714

fbshipit-source-id: 77b69080d19c9af81126e311a549137da4cd1f67

Author: samlurye

hyperactor/src/attrs.rs

@@ -311,7 +311,6 @@ macro_rules! impl_attrvalue {
 
 // Implement AttrValue for common standard library types
 impl_attrvalue!(
-    bool,
     i8,
     i16,
     i32,
@@ -384,6 +383,24 @@ where
     }
 }
 
+impl AttrValue for bool {
+    fn display(&self) -> String {
+        if *self { 1.to_string() } else { 0.to_string() }
+    }
+
+    fn parse(value: &str) -> Result<Self, anyhow::Error> {
+        let value = value.to_ascii_lowercase();
+        match value.as_str() {
+            "0" | "false" => Ok(false),
+            "1" | "true" => Ok(true),
+            _ => Err(anyhow::anyhow!(
+                "expected `0`, `1`, `true` or `false`, got `{}`",
+                value
+            )),
+        }
+    }
+}
+
 // Internal trait for type-erased serialization
 #[doc(hidden)]
 pub trait SerializableValue: Send + Sync {

hyperactor/src/config.rs

@@ -334,7 +334,7 @@ mod tests {
         let expected_lines: HashSet<&str> = indoc! {"
             # export HYPERACTOR_MESSAGE_LATENCY_SAMPLING_RATE=0.01
             # export HYPERACTOR_CHANNEL_NET_RX_BUFFER_FULL_CHECK_INTERVAL=5s
-            # export HYPERACTOR_CHANNEL_MULTIPART=true
+            # export HYPERACTOR_CHANNEL_MULTIPART=1
             # export HYPERACTOR_DEFAULT_ENCODING=serde_multipart
             # export HYPERACTOR_REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL=5s
             # export HYPERACTOR_STOP_ACTOR_TIMEOUT=10s

monarch_hyperactor/src/pytokio.rs

@@ -69,14 +69,14 @@ declare_attrs! {
     /// If true, when a pytokio PythonTask fails, the traceback of the original callsite
     /// will be logged.
     @meta(CONFIG = ConfigAttr {
-        env_name: Some("MONARCH_HYPERACTOR_UNAWAITED_PYTOKIO_TRACEBACK".to_string()),
-        py_name: Some("unawaited_pytokio_traceback".to_string()),
+        env_name: Some("MONARCH_HYPERACTOR_ENABLE_UNAWAITED_PYTHON_TASK_TRACEBACK".to_string()),
+        py_name: Some("enable_unawaited_python_task_traceback".to_string()),
     })
-    pub attr UNAWAITED_PYTOKIO_TRACEBACK: u8 = 0;
+    pub attr ENABLE_UNAWAITED_PYTHON_TASK_TRACEBACK: bool = false;
 }
 
 fn current_traceback() -> PyResult<Option<PyObject>> {
-    if config::global::get(UNAWAITED_PYTOKIO_TRACEBACK) != 0 {
+    if config::global::get(ENABLE_UNAWAITED_PYTHON_TASK_TRACEBACK) {
         Python::with_gil(|py| {
             Ok(Some(
                 py.import("traceback")?
@@ -274,7 +274,7 @@ fn send_result(
                 let tb = if let Some(tb) = traceback {
                     format_traceback(py, &tb).unwrap()
                 } else {
-                    "None (run with `MONARCH_HYPERACTOR_UNAWAITED_PYTOKIO_TRACEBACK=1` to see a traceback here)\n".into()
+                    "None (run with `MONARCH_HYPERACTOR_ENABLE_UNAWAITED_PYTHON_TASK_TRACEBACK=1` to see a traceback here)\n".into()
                 };
                 tracing::error!(
                     "PythonTask errored but is not being awaited; this will not crash your program, but indicates that \