From de417b7b5b5a80be17dbaf964de1dfa9873b4036 Mon Sep 17 00:00:00 2001 From: Shayne Fletcher Date: Sat, 1 Nov 2025 11:46:09 -0700 Subject: [PATCH] : python/monarch: pytorch InputBuffer::add() signature changed (#1739) Summary: pytorch `InputBuffer::add` API changed. adapt `monarch/python/monarch/_gradient_generator.cpp` ``` realInputBuffer(node).add( input_nr, check_and_reduce(node->node, input_nr, std::move(t)), std::nullopt, std::nullopt); // Remove: node->node ``` that gradient computation still works correctly after this change needs to be tested. Reviewed By: vidhyav Differential Revision: D86025607 --- python/monarch/gradient/_gradient_generator.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/python/monarch/gradient/_gradient_generator.cpp b/python/monarch/gradient/_gradient_generator.cpp index 01ea6eed3..a45b38542 100644 --- a/python/monarch/gradient/_gradient_generator.cpp +++ b/python/monarch/gradient/_gradient_generator.cpp @@ -420,12 +420,20 @@ struct GradientGenerator { DEBUG_PRINT( "// add: " << node->node->name() << ", input_nr=" << static_cast(input_nr) << "\n"); +#if !defined(FBCODE_BUILD) + realInputBuffer(node).add( + input_nr, + check_and_reduce(node->node, input_nr, std::move(t)), + std::nullopt, + std::nullopt); +#else realInputBuffer(node).add( input_nr, check_and_reduce(node->node, input_nr, std::move(t)), std::nullopt, std::nullopt, node->node); +#endif } InputBuffer& realInputBuffer(NodeState* state) {