Skip to content

Commit d2ddc21

Browse files
TroyGardenfacebook-github-bot
authored andcommitted
fix pre-commit error in sharding (#2755)
Summary: Pull Request resolved: #2755 # context * pre-commit test failed: https://github.com/pytorch/torchrec/actions/runs/13416363381/job/37489987778 * after the fix {F1975288470} Reviewed By: iamzainhuda Differential Revision: D69905081 fbshipit-source-id: 5516a7957b27c581a579c96666c5e96d2522b324
1 parent 3578390 commit d2ddc21

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

torchrec/distributed/sharding/cw_sharding.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,11 @@ def _shard(
192192
for i, rank in enumerate(info.param_sharding.ranks):
193193
# Remap rank by number of replica groups if 2D parallelism is enabled
194194
rank = (
195-
self._env.remap_rank(rank, ShardingType.COLUMN_WISE) # pyre-ignore[16]
195+
# pyre-ignore[16]
196+
self._env.remap_rank(
197+
rank,
198+
ShardingType.COLUMN_WISE,
199+
)
196200
if self._is_2D_parallel
197201
else rank
198202
)

torchrec/distributed/sharding/grid_sharding.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,8 @@ def _shard(
250250
# pyre-fixme [6]
251251
for i, rank in enumerate(info.param_sharding.ranks):
252252
rank = (
253-
self._env.remap_rank(rank, ShardingType.GRID_SHARD) # pyre-ignore[16]
253+
# pyre-ignore[16]
254+
self._env.remap_rank(rank, ShardingType.GRID_SHARD)
254255
if self._is_2D_parallel
255256
else rank
256257
)

torchrec/distributed/sharding/tw_sharding.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,8 @@ def _shard(
147147
rank = (
148148
# pyre-ignore [16]
149149
self._env.remap_rank(
150-
info.param_sharding.ranks[0], ShardingType.TABLE_WISE # pyre-ignore[16]
150+
info.param_sharding.ranks[0], # pyre-ignore[16]
151+
ShardingType.TABLE_WISE,
151152
)
152153
if self._is_2D_parallel
153154
else info.param_sharding.ranks[0]

0 commit comments

Comments
 (0)