directly pass update_util as int flag without syncing iter #3293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67302872 |
Fiery
force-pushed
the
export-D67302872
branch
from
0c6c6bb to
75ef325
Compare
Contributor
Fiery
pushed a commit
to Fiery/torchrec
that referenced
this pull request
Sep 16, 2025
…rch#3293) Summary: as title, this issue continue exists in most recent ITEP experiments when we only apply ITEP on the baseline without changing batch size and/or trainer numbers. from recent MAI results in f777920760, we see about 3.5% QPS gap with ITEP enabled (393 vs 403 P90) issues visible in trace https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2Faps-aps-mai_to_flow-777920760-f777930060%2F0%2Frank-0.Aug_11_01_48_39.4443.pt.trace.json.gz&bucket=aps_traces {F1981311699} Reviewed By: doIIarplus Differential Revision: D67302872
Contributor
Fiery
force-pushed
the
export-D67302872
branch
from
75ef325 to
e7b89f2
Compare
Fiery
pushed a commit
to Fiery/torchrec
that referenced
this pull request
Sep 16, 2025
…rch#3293) Summary: Pull Request resolved: meta-pytorch#3293 as title, this issue continue exists in most recent ITEP experiments when we only apply ITEP on the baseline without changing batch size and/or trainer numbers. from recent MAI results in f777920760, we see about 3.5% QPS gap with ITEP enabled (393 vs 403 P90) issues visible in trace https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2Faps-aps-mai_to_flow-777920760-f777930060%2F0%2Frank-0.Aug_11_01_48_39.4443.pt.trace.json.gz&bucket=aps_traces {F1981311699} Reviewed By: doIIarplus Differential Revision: D67302872
…rch#3293) Summary: as title, this issue continue exists in most recent ITEP experiments when we only apply ITEP on the baseline without changing batch size and/or trainer numbers. from recent MAI results in f777920760, we see about 3.5% QPS gap with ITEP enabled (393 vs 403 P90) issues visible in trace https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2Faps-aps-mai_to_flow-777920760-f777930060%2F0%2Frank-0.Aug_11_01_48_39.4443.pt.trace.json.gz&bucket=aps_traces {F1981311699} Reviewed By: doIIarplus Differential Revision: D67302872
Fiery
force-pushed
the
export-D67302872
branch
from
e7b89f2 to
d5cd980
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
as title, this issue continue exists in most recent ITEP experiments when we only apply ITEP on the baseline without changing batch size and/or trainer numbers.
from recent MAI results in f777920760, we see about 3.5% QPS gap with ITEP enabled (393 vs 403 P90)
issues visible in trace
https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2Faps-aps-mai_to_flow-777920760-f777930060%2F0%2Frank-0.Aug_11_01_48_39.4443.pt.trace.json.gz&bucket=aps_traces
{F1981311699}
Differential Revision: D67302872