Fix broken docs-build by pinning protobuf-3.20.x (#1033)

Summary:

Pin protobuf-3.20.x (required by kfp-1.8.22) in dev-requirements and first install docs/requirements.txt then downgrade protobuf to 3.20.x.

What we oughta do is to upgrade to `kfp-2.x` but that's a much more intrusive change as we are bumping major versions. So pin to `apache-airflow==2.6.3` so that protobuf doesn't conflict with kfp.

Reviewed By: tonykao8080

Differential Revision: D72016216

Author: kiukchung

.github/workflows/doc-build.yaml

@@ -20,16 +20,15 @@ jobs:
           architecture: x64
       - name: Checkout TorchX
         uses: actions/checkout@v2
-      - name: Install Dependencies
+      - name: Install Doc Dependencies
         run: |
           set -eux
           sudo apt-get update
           sudo apt-get install -y pandoc
-          pip install -e .[dev]
           pip install -r docs/requirements.txt
       - name: Install TorchX
         run: |
-          python setup.py develop
+          pip install -e .[dev]
       - name: Start Airflow
         run: |
           # start airflow in background

.github/workflows/pyre.yaml

@@ -22,6 +22,6 @@ jobs:
           set -eux
           pip install -e .[dev]
       - name: Init Lint Runner
-          lintrunner init
+        run: lintrunner init
       - name: Run Pyre
         run: scripts/pyre.sh

dev-requirements.txt

@@ -14,6 +14,8 @@ google-cloud-runtimeconfig==0.34.0
 hydra-core
 ipython
 kfp==1.8.22
+# pin protobuf to the version that is required by kfp
+protobuf==3.20.3
 mlflow-skinny
 moto~=5.0.8
 pyre-extensions

torchx/schedulers/test/ray_scheduler_test.py

@@ -390,7 +390,9 @@ def test_nonmatching_address(self) -> None:
             ):
                 _scheduler_with_client.submit(app=app, cfg={})
 
-        def _assertDictContainsSubset(self, expected, actual, msg=None):
+        def _assertDictContainsSubset(
+            self, expected: dict, actual: dict, msg: str = None
+        ) -> None:
             # NB: implement unittest.TestCase.assertDictContainsSubsetNew() since it was removed in python-3.11
             for key, value in expected.items():
                 self.assertIn(key, actual, msg)