From 4bab44a0efb20fdd3f4e5559fa5d6364d222844b Mon Sep 17 00:00:00 2001 From: Kiuk Chung Date: Thu, 11 Sep 2025 12:48:51 -0700 Subject: [PATCH] (torchx/runner)(1/n) remove useless nested event logging - runner.dryrun (#1112) Summary: remove useless event logging for sub-steps of runner.dryrun(). If these need to be logged they should be logged at the APIs that the runner.dryrun() calls. Differential Revision: D82238445 --- torchx/runner/api.py | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/torchx/runner/api.py b/torchx/runner/api.py index f38367ecd..fec19f0bd 100644 --- a/torchx/runner/api.py +++ b/torchx/runner/api.py @@ -419,12 +419,7 @@ def dryrun( sched = self._scheduler(scheduler) resolved_cfg = sched.run_opts().resolve(cfg) - # early validation before build workspace - with log_event( - "pre_build_validate", - scheduler, - ): - sched._pre_build_validate(app, scheduler, resolved_cfg) + sched._pre_build_validate(app, scheduler, resolved_cfg) if workspace and isinstance(sched, WorkspaceMixin): role = app.roles[0] @@ -434,13 +429,7 @@ def dryrun( logger.info( 'To disable workspaces pass: --workspace="" from CLI or workspace=None programmatically.' ) - with log_event( - "build_workspace_and_update_role", - scheduler, - ) as ctx: - sched.build_workspace_and_update_role(role, workspace, resolved_cfg) - ctx._torchx_event.app_image = role.image - ctx._torchx_event.workspace = workspace + sched.build_workspace_and_update_role(role, workspace, resolved_cfg) if old_img != role.image: logger.info( @@ -453,11 +442,7 @@ def dryrun( " Either a patch was built or no changes to workspace was detected." ) - with log_event( - "validate", - scheduler, - ): - sched._validate(app, scheduler, resolved_cfg) + sched._validate(app, scheduler, resolved_cfg) dryrun_info = sched.submit_dryrun(app, resolved_cfg) dryrun_info._scheduler = scheduler return dryrun_info