Clippy running on docker CI

[viferga]

https://github.com/metacall/metassr/actions/runs/17985509850/job/51162854138

I have no clue why is this happening, any ideas? @hulxv

[hulxv]

For some reason when I try it on my local machine (without docker) I got this:

Debug: Set MetaCall log level to Debug
Debug: Loader script path: /home/mohamed/dev/contrib/metacall/metassr/target/debug/
Debug: Loading plugin: ext_loader
Debug: Loading plugin symbol: dynlink_symbol_ext_loader_impl_interface_singleton
Debug: Loading plugin: /usr/local/lib/plugins/backtrace_plugin/metacall.json
Debug: Loading plugin: node_loader
Debug: Loading plugin symbol: dynlink_symbol_node_loader_impl_interface_singleton

thread '<unnamed>' panicked at library/core/src/panicking.rs:218:5:
unsafe precondition(s) violated: NonNull::new_unchecked requires that the pointer is non-null
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread caused non-unwinding panic. aborting.
Stack trace (most recent call last) in thread 2666380:
#16   Object "/usr/lib/libnode.so.127", at 0x722cf674f6e1, in 
#15   Object "/usr/lib/libnode.so.127", at 0x722d56344501, in v8impl::(anonymous namespace)::FunctionCallbackWrapper::Invoke(v8::FunctionCallbackInfo<v8::Value> const&)
#14   Object "/usr/local/lib/libnode_loader.so", at 0x722da6340b67, in node_loader_trampoline_resolve(napi_env__*, napi_callback_info__*)
#13   Object "/usr/local/lib/libnode_loader.so", at 0x722da633c999, in node_loader_impl_async_func_resolve(loader_impl_node_type*, napi_env__*, void* (*)(void*, void*), napi_value__*, napi_value__*, void*)
#12   Source "src/types/metacall_future.rs", line 121, in resolver [0x5d1e62d89ef8]
#11 | Source "/home/mohamed/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/boxed.rs", line 1061, in from_raw_in<dyn core::any::Any, alloc::alloc::Global>
    |  1059:     #[must_use = "call `drop(Box::from_raw(ptr))` if you intend to drop the `Box`"]
    |  1060:     pub unsafe fn from_raw(raw: *mut T) -> Self {
    | >1061:         unsafe { Self::from_raw_in(raw, Global) }
    |  1062:     }
    | Source "/home/mohamed/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/boxed.rs", line 1173, in new_unchecked<dyn core::any::Any>
    |  1171:     #[inline]
    |  1172:     pub const unsafe fn from_raw_in(raw: *mut T, alloc: A) -> Self {
    | >1173:         Box(unsafe { Unique::new_unchecked(raw) }, alloc)
    |  1174:     }
    | Source "/home/mohamed/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/unique.rs", line 90, in new_unchecked<dyn core::any::Any>
    |    88:     pub const unsafe fn new_unchecked(ptr: *mut T) -> Self {
    |    89:         // SAFETY: the caller must guarantee that `ptr` is non-null.
    | >  90:         unsafe { Unique { pointer: NonNull::new_unchecked(ptr), _marker: PhantomData } }
    |    91:     }
      Source "/home/mohamed/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ub_checks.rs", line 75, in from_raw<dyn core::any::Any> [0x5d1e62d7bb1f]
         72:             }
         73: 
         74:             if ::core::ub_checks::$kind() {
      >  75:                 precondition_check($($arg,)*);
         76:             }
         77:         }
         78:     };
#10   Source "/home/mohamed/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ub_checks.rs", line 68, in precondition_check [0x5d1e62d8bc9f]
         65:             #[rustc_nounwind]
         66:             const fn precondition_check($($name:$ty),*) {
         67:                 if !$e {
      >  68:                     ::core::panicking::panic_nounwind(
         69:                         concat!("unsafe precondition(s) violated: ", $message)
         70:                     );
         71:                 }
#9    Source "library/core/src/panicking.rs", line 218, in panic_nounwind [0x5d1e6299e321]
#8  | Source "library/core/src/intrinsics/mod.rs", line 3886, in runtime
      Source "library/core/src/panicking.rs", line 117, in panic_nounwind_fmt [0x5d1e6299e28c]
#7    Source "library/std/src/panicking.rs", line 695, in begin_panic_handler [0x5d1e62ec8a8c]
#6    Source "library/std/src/sys/backtrace.rs", line 168, in __rust_end_short_backtrace<std::panicking::begin_panic_handler::{closure_env#0}, !> [0x5d1e62ec7e18]
#5    Source "library/std/src/panicking.rs", line 697, in {closure#0} [0x5d1e62ec8dc5]
#4    Source "library/std/src/panicking.rs", line 0, in rust_panic_with_hook [0x5d1e62ec91c2]
#3    Source "library/std/src/sys/pal/unix/mod.rs", line 367, in abort_internal [0x5d1e62ecc529]
#2    Object "/usr/lib/libc.so.6", at 0x722da6025579, in abort
#1    Object "/usr/lib/libc.so.6", at 0x722da603e40f, in raise
#0    Object "/usr/lib/libc.so.6", at 0x722da609894c, in 
Aborted (Signal sent by tkill() 2666359 1000)
[1]    2666336 IOT instruction (core dumped)  npm run build

What's the problem? it seems come from Metacall

[viferga]

Wow you got stack traces? I was trying to solve that now but it was giving an issue with address sanitizer preloading.

[viferga]

I am making a new commit and deleting the clippy CI. I will add clippy directly in the test CI instead.

I am also publishing a new version of metacall with debug symbols but without address sanitizer.

[viferga]

It's crazy it even gets the rust code in the stack trace XD

[viferga]

@hulxv Look how it looks, in Release:

#11 27.24 thread '<unnamed>' panicked at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library/core/src/ptr/unique.rs:88:36:
#11 27.24 unsafe precondition(s) violated: NonNull::new_unchecked requires that the pointer is non-null
#11 27.24 
#11 27.24 This indicates a bug in the program. This Undefined Behavior check is optional, and cannot be relied on for safety.
#11 27.24 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
#11 27.24 thread caused non-unwinding panic. aborting.
#11 27.24 Stack trace (most recent call last) in thread 2520:
#11 27.24 #31   Object "/gnu/store/3611k5c6iki74mzrp2lj670kv7csp0wh-libnode-22.12.0/lib/libnode.so.127", at 0x7fe17c8ccba5, in node::SpinEventLoopInternal(node::Environment*)
#11 27.24 #30   Object "/gnu/store/9ygpsbp5gfbrwrin5jdmkd3m84vdsai5-libuv-1.49.1/lib/libuv.so.1", at 0x7fe1960d1275, in uv_run
#11 27.24 #29   Object "/gnu/store/9ygpsbp5gfbrwrin5jdmkd3m84vdsai5-libuv-1.49.1/lib/libuv.so.1", at 0x7fe1960e37a2, in 
#11 27.24 #28   Object "/gnu/store/9ygpsbp5gfbrwrin5jdmkd3m84vdsai5-libuv-1.49.1/lib/libuv.so.1", at 0x7fe1960d06c2, in 
#11 27.24 #27   Object "/gnu/store/3611k5c6iki74mzrp2lj670kv7csp0wh-libnode-22.12.0/lib/libnode.so.127", at 0x7fe17c988424, in 
#11 27.24 #26   Object "/gnu/store/3611k5c6iki74mzrp2lj670kv7csp0wh-libnode-22.12.0/lib/libnode.so.127", at 0x7fe17c8cbd96, in node::CallbackScope::~CallbackScope()
#11 27.24 #25   Object "/gnu/store/3611k5c6iki74mzrp2lj670kv7csp0wh-libnode-22.12.0/lib/libnode.so.127", at 0x7fe17c8cbd30, in node::InternalCallbackScope::~InternalCallbackScope()
#11 27.24 #24   Object "/gnu/store/3611k5c6iki74mzrp2lj670kv7csp0wh-libnode-22.12.0/lib/libnode.so.127", at 0x7fe17c8cbaf8, in node::InternalCallbackScope::Close()
#11 27.24 #23   Object "/gnu/store/3611k5c6iki74mzrp2lj670kv7csp0wh-libnode-22.12.0/lib/libnode.so.127", at 0x7fe17d17cf8e, in v8::internal::MicrotaskQueue::PerformCheckpointInternal(v8::Isolate*)
#11 27.24 #22   Object "/gnu/store/3611k5c6iki74mzrp2lj670kv7csp0wh-libnode-22.12.0/lib/libnode.so.127", at 0x7fe17d17cc55, in v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*)
#11 27.24 #21   Object "/gnu/store/3611k5c6iki74mzrp2lj670kv7csp0wh-libnode-22.12.0/lib/libnode.so.127", at 0x7fe17d14d2e9, in v8::internal::Execution::TryRunMicrotasks(v8::internal::Isolate*, v8::internal::MicrotaskQueue*)
#11 27.24 #20   Object "/gnu/store/3611k5c6iki74mzrp2lj670kv7csp0wh-libnode-22.12.0/lib/libnode.so.127", at 0x7fe17d14c185, in 
#11 27.24 #19   Object "[0x7fe11cc8b402]", at 0x7fe11cc8b402, in 
#11 27.24 #18   Object "[0x7fe11ccbc918]", at 0x7fe11ccbc918, in 
#11 27.24 #17   Object "[0x7fe11cdab274]", at 0x7fe11cdab274, in 
#11 27.24 #16   Object "[0x7fe11cc8d8dd]", at 0x7fe11cc8d8dd, in 
#11 27.24 #15   Object "[0x7fe11cc8f5e1]", at 0x7fe11cc8f5e1, in 
#11 27.24 #14   Object "/gnu/store/3611k5c6iki74mzrp2lj670kv7csp0wh-libnode-22.12.0/lib/libnode.so.127", at 0x7fe17c962334, in 
#11 27.24 #13   Object "/gnu/store/lq4c37dxvbd8f4g5b7p0flf2w05s3h9r-metacall-0.9.14/lib/libnode_loader.so", at 0x7fe19547fab9, in 
#11 27.24 #12   Object "/gnu/store/lq4c37dxvbd8f4g5b7p0flf2w05s3h9r-metacall-0.9.14/lib/libnode_loader.so", at 0x7fe195478288, in 
#11 27.24 #11   Object "../../target/debug/metassr", at 0x55a7c87c4266, in 
#11 27.24 #10   Object "../../target/debug/metassr", at 0x55a7c87afab6, in 
#11 27.24 #9    Object "../../target/debug/metassr", at 0x55a7c87bf5d5, in 
#11 27.24 #8    Object "../../target/debug/metassr", at 0x55a7c892e80c, in 
#11 27.24 #7    Object "../../target/debug/metassr", at 0x55a7c890c14c, in 
#11 27.24 #6    Object "../../target/debug/metassr", at 0x55a7c890ae58, in 
#11 27.24 #5    Object "../../target/debug/metassr", at 0x55a7c890c485, in 
#11 27.24 #4    Object "../../target/debug/metassr", at 0x55a7c890c88c, in 
#11 27.24 #3    Object "../../target/debug/metassr", at 0x55a7c890fe89, in 
#11 27.24 #2    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7fe1973e74ab, in abort
#11 27.24 #1    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7fe1973fecc1, in gsignal
#11 27.24 #0    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7fe19745395c, in 
#11 27.24 Aborted (Signal sent by tkill() 2515 0)
#11 28.24 Aborted (core dumped)
#11 ERROR: process "/bin/sh -c cargo build \t&& cd ./tests/web-app \t&& npm install \t&& npm run build" did not complete successfully: exit code: 134
------
 > [6/6] RUN cargo build 	&& cd ./tests/web-app 	&& npm install 	&& npm run build:
27.24 #7    Object "../../target/debug/metassr", at 0x55a7c890c14c, in 
27.24 #6    Object "../../target/debug/metassr", at 0x55a7c890ae58, in 
27.24 #5    Object "../../target/debug/metassr", at 0x55a7c890c485, in 
27.24 #4    Object "../../target/debug/metassr", at 0x55a7c890c88c, in 
27.24 #3    Object "../../target/debug/metassr", at 0x55a7c890fe89, in 
27.24 #2    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7fe1973e74ab, in abort
27.24 #1    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7fe1973fecc1, in gsignal
27.24 #0    Object "/lib/x86_64-linux-gnu/libc.so.6", at 0x7fe19745395c, in 
27.24 Aborted (Signal sent by tkill() 2515 0)
28.24 Aborted (core dumped)

In debug with address sanitizer:

added 20 packages, and audited 21 packages in 3s

1 package is looking for funding
  run `npm fund` for details

1 moderate severity vulnerability

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> app@1.0.0 build
> ../../target/debug/metassr --debug-mode=metacall build

==4961==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.

I am removing sanitizer and letting debug symbols now so we have stack trace and it does not have problems of preload asan.