Skip to content

Commit 04297ca

Browse files
committed
Fix ruff format
1 parent 1e46ca7 commit 04297ca

File tree

5 files changed

+31
-38
lines changed

5 files changed

+31
-38
lines changed

.github/workflows/commit.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
python -m pip install --upgrade setuptools wheel
2323
python -m pip install -r requirements/dev.txt
2424
- name: Run ruff format
25-
run: ruff format
25+
run: ruff format .
2626
- name: Run ruff
2727
run: ruff .
2828

netbox_config_diff/compliance/secrets.py

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ class SecretsMixin:
1515

1616
def get_session_key(self) -> None:
1717
if "netbox_secrets_sessionid" in self.request.COOKIES:
18-
self.session_key = base64.b64decode(self.request.COOKIES['netbox_secrets_sessionid'])
18+
self.session_key = base64.b64decode(self.request.COOKIES["netbox_secrets_sessionid"])
1919
elif "HTTP_X_SESSION_KEY" in self.request.META:
20-
self.session_key = base64.b64decode(self.request.META['HTTP_X_SESSION_KEY'])
20+
self.session_key = base64.b64decode(self.request.META["HTTP_X_SESSION_KEY"])
2121
else:
2222
self.session_key = None
2323

@@ -45,24 +45,33 @@ def get_secret(self, secret: "Secret") -> str | None:
4545
return None
4646
return secret.plaintext
4747

48-
def get_credentials(self, device: Device) -> tuple[str, str]:
49-
if self.netbox_secrets_installed:
50-
if secret := device.secrets.filter(role__name=self.user_role).first():
51-
if value := self.get_secret(secret):
52-
username = value
53-
if secret := device.secrets.filter(role__name=self.password_role).first():
54-
if value := self.get_secret(secret):
55-
password = value
56-
return username, password
48+
def get_credentials(self, device: Device) -> tuple[str, str, str]:
49+
if not self.netbox_secrets_installed:
50+
return self.username, self.password, self.auth_secondary
5751

58-
return self.username, self.password
52+
if secret := device.secrets.filter(role__name=self.user_role).first():
53+
username = value if (value := self.get_secret(secret)) else self.username
54+
else:
55+
username = self.username
56+
if secret := device.secrets.filter(role__name=self.password_role).first():
57+
password = value if (value := self.get_secret(secret)) else self.password
58+
else:
59+
password = self.password
60+
if secret := device.secrets.filter(role__name=self.auth_secondary_role).first():
61+
auth_secondary = value if (value := self.get_secret(secret)) else self.auth_secondary
62+
else:
63+
auth_secondary = self.auth_secondary
64+
65+
return username, password, auth_secondary
5966

6067
def check_netbox_secrets(self) -> None:
6168
if "netbox_secrets" in get_installed_plugins():
6269
self.get_master_key()
6370
self.user_role = get_plugin_config("netbox_config_diff", "USER_SECRET_ROLE")
6471
self.password_role = get_plugin_config("netbox_config_diff", "PASSWORD_SECRET_ROLE")
72+
self.auth_secondary_role = get_plugin_config("netbox_config_diff", "SECOND_AUTH_SECRET_ROLE")
6573
self.netbox_secrets_installed = True
66-
else:
67-
self.username = get_plugin_config("netbox_config_diff", "USERNAME")
68-
self.password = get_plugin_config("netbox_config_diff", "PASSWORD")
74+
75+
self.username = get_plugin_config("netbox_config_diff", "USERNAME")
76+
self.password = get_plugin_config("netbox_config_diff", "PASSWORD")
77+
self.auth_secondary = get_plugin_config("netbox_config_diff", "AUTH_SECONDARY")

netbox_config_diff/configurator/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def _log(self, message: str, log_level: str | None = None) -> None:
1515
raise Exception(f"Unknown logging level: {log_level}")
1616
if log_level is None:
1717
log_level = LogLevelChoices.LOG_DEFAULT
18-
self.log_data.append((timezone.now().strftime('%Y-%m-%d %H:%M:%S'), log_level, message))
18+
self.log_data.append((timezone.now().strftime("%Y-%m-%d %H:%M:%S"), log_level, message))
1919

2020
def log(self, message: str) -> None:
2121
self._log(message, log_level=LogLevelChoices.LOG_DEFAULT)

netbox_config_diff/models/models.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,21 +110,21 @@ class ConfigurationRequest(AbsoluteURLMixin, JobsMixin, PrimaryModel):
110110
created_by = models.ForeignKey(
111111
to=settings.AUTH_USER_MODEL,
112112
on_delete=models.SET_NULL,
113-
related_name='+',
113+
related_name="+",
114114
blank=True,
115115
null=True,
116116
)
117117
approved_by = models.ForeignKey(
118118
to=settings.AUTH_USER_MODEL,
119119
on_delete=models.SET_NULL,
120-
related_name='+',
120+
related_name="+",
121121
blank=True,
122122
null=True,
123123
)
124124
scheduled_by = models.ForeignKey(
125125
to=settings.AUTH_USER_MODEL,
126126
on_delete=models.SET_NULL,
127-
related_name='+',
127+
related_name="+",
128128
blank=True,
129129
null=True,
130130
)
@@ -213,20 +213,19 @@ class Substitute(AbsoluteURLMixin, NetBoxModel):
213213
unique=True,
214214
validators=(
215215
RegexValidator(
216-
regex=r'^[a-z0-9_]+$',
216+
regex=r"^[a-z0-9_]+$",
217217
message=_("Only alphanumeric characters and underscores are allowed."),
218218
flags=re.IGNORECASE,
219219
),
220220
RegexValidator(
221-
regex=r'__',
221+
regex=r"__",
222222
message=_("Double underscores are not permitted in names."),
223223
flags=re.IGNORECASE,
224224
inverse_match=True,
225225
),
226226
),
227227
)
228228
description = models.CharField(
229-
verbose_name=_('description'),
230229
max_length=200,
231230
blank=True,
232231
)

netbox_config_diff/navigation.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
from django import forms
2-
from extras.dashboard.utils import register_widget
3-
from extras.dashboard.widgets import DashboardWidget, WidgetConfigForm
41
from extras.plugins import PluginMenuButton, PluginMenuItem
52
from utilities.choices import ButtonColorChoices
63

@@ -47,15 +44,3 @@ def get_add_button(model: str) -> PluginMenuButton:
4744
permissions=["netbox_config_diff.view_substitute"],
4845
),
4946
)
50-
51-
52-
@register_widget
53-
class ReminderWidget(DashboardWidget):
54-
default_title = 'Reminder'
55-
description = 'Add a virtual sticky note'
56-
57-
class ConfigForm(WidgetConfigForm):
58-
content = forms.CharField(widget=forms.Textarea())
59-
60-
def render(self, request):
61-
return self.config.get('content')

0 commit comments

Comments
 (0)