Skip to content

Commit 6583e42

Browse files
committed
Make BindingException public
Fixes the following warning from IntelliJ: 'internal' type 'BindCancellationException' is accessed from 'public' inline declaration. This will become an error in language version 2.4. See https://youtrack.jetbrains.com/issue/KTLC-283.
1 parent 549ed30 commit 6583e42

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

kotlin-result-coroutines/src/commonMain/kotlin/com/github/michaelbull/result/coroutines/CoroutineBinding.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public suspend inline fun <V, E> coroutineBinding(crossinline block: suspend Cor
6060
}
6161
}
6262

63-
public object BindingCancellationException : CancellationException(null as String?)
63+
public class BindingCancellationException() : CancellationException(null as String?)
6464

6565
public interface CoroutineBindingScope<E> : CoroutineScope {
6666
public suspend fun <V> Result<V, E>.bind(): V
@@ -82,10 +82,10 @@ internal class CoroutineBindingScopeImpl<E>(
8282
mutex.withLock {
8383
if (result == null) {
8484
result = this.asErr()
85-
coroutineContext.cancel(BindingCancellationException)
85+
coroutineContext.cancel(BindingCancellationException())
8686
}
8787

88-
throw BindingCancellationException
88+
throw BindingCancellationException()
8989
}
9090
}
9191
}

kotlin-result/src/commonMain/kotlin/com/github/michaelbull/result/Binding.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public inline fun <V, E> binding(crossinline block: BindingScope<E>.() -> V): Re
3939
}
4040
}
4141

42-
public expect object BindingException : Exception
42+
public expect class BindingException() : Exception
4343

4444
public interface BindingScope<E> {
4545
public fun <V> Result<V, E>.bind(): V
@@ -55,7 +55,7 @@ internal class BindingScopeImpl<E> : BindingScope<E> {
5555
value
5656
} else {
5757
result = this.asErr()
58-
throw BindingException
58+
throw BindingException()
5959
}
6060
}
6161
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
package com.github.michaelbull.result
22

3-
public actual object BindingException : Exception()
3+
public actual class BindingException : Exception()

kotlin-result/src/jvmMain/kotlin/com/github/michaelbull/result/BindingException.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.github.michaelbull.result
22

3-
public actual object BindingException : Exception() {
3+
public actual class BindingException : Exception() {
44
override fun fillInStackTrace(): Throwable {
55
return this
66
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
package com.github.michaelbull.result
22

3-
public actual object BindingException : Exception()
3+
public actual class BindingException : Exception()
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
package com.github.michaelbull.result
22

3-
public actual object BindingException : Exception()
3+
public actual class BindingException : Exception()

0 commit comments

Comments
 (0)