Skip to content
This repository was archived by the owner on Apr 19, 2025. It is now read-only.

Commit 790f79e

Browse files
committed
Merge branch 'develop'
2 parents f95a381 + e56fc7a commit 790f79e

File tree

7 files changed

+30
-38
lines changed

7 files changed

+30
-38
lines changed

src/Contracts/SMSToken.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@
22

33
namespace MichaelDzjap\TwoFactorAuth\Contracts;
44

5-
use App\User;
6-
75
interface SMSToken
86
{
97
/**
108
* Send a user a two-factor authentication token via SMS.
119
*
12-
* @param \App\User $user
10+
* @param mixed $user
1311
* @return void
1412
*/
15-
public function sendSMSToken(User $user) : void;
13+
public function sendSMSToken($user) : void;
1614
}

src/Contracts/TwoFactorProvider.php

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,40 +2,38 @@
22

33
namespace MichaelDzjap\TwoFactorAuth\Contracts;
44

5-
use App\User;
6-
75
interface TwoFactorProvider
86
{
97
/**
108
* Check if two-factor authentication is enabled for a user.
119
*
12-
* @param \App\User $user
10+
* @param mixed $user
1311
* @return bool
1412
*/
15-
public function enabled(User $user);
13+
public function enabled($user);
1614

1715
/**
1816
* Register a user with this provider.
1917
*
20-
* @param \App\User $user
18+
* @param mixed $user
2119
* @return void
2220
*/
23-
public function register(User $user) : void;
21+
public function register($user) : void;
2422

2523
/**
2624
* Unregister a user with this provider.
2725
*
28-
* @param \App\User $user
26+
* @param mixed $user
2927
* @return bool
3028
*/
31-
public function unregister(User $user);
29+
public function unregister($user);
3230

3331
/**
3432
* Determine if the token is valid.
3533
*
36-
* @param \App\User $user
34+
* @param mixed $user
3735
* @param string $token
3836
* @return bool
3937
*/
40-
public function verify(User $user, string $token);
38+
public function verify($user, string $token);
4139
}

src/Events/TwoFactorAuthenticated.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace MichaelDzjap\TwoFactorAuth\Events;
44

5-
use App\User;
65
use Illuminate\Queue\SerializesModels;
76

87
class TwoFactorAuthenticated
@@ -12,17 +11,17 @@ class TwoFactorAuthenticated
1211
/**
1312
* The user instance.
1413
*
15-
* @var \App\User
14+
* @var mixed
1615
*/
1716
public $user;
1817

1918
/**
2019
* Create a new event instance.
2120
*
22-
* @param \App\User $user
21+
* @param mixed $user
2322
* @return void
2423
*/
25-
public function __construct(User $user)
24+
public function __construct($user)
2625
{
2726
$this->user = $user;
2827
}

src/Http/Controllers/TwoFactorAuthenticatesUsers.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace MichaelDzjap\TwoFactorAuth\Http\Controllers;
44

5-
use App\User;
65
use Illuminate\Foundation\Auth\RedirectsUsers;
76
use Illuminate\Http\Request;
87
use Illuminate\Validation\ValidationException;
@@ -76,7 +75,9 @@ public function verifyToken(VerifySMSToken $request)
7675
*/
7776
protected function attemptTwoFactorAuth(Request $request)
7877
{
79-
$user = User::findOrFail($request->session()->get('two-factor:auth')['id']);
78+
$user = config('twofactor-auth.model')::findOrFail(
79+
$request->session()->get('two-factor:auth')['id']
80+
);
8081

8182
if (resolve(TwoFactorProvider::class)->verify($user, $request->input('token'))) {
8283
auth()->login($user); // If SMS code validation passes, login user

src/Providers/BaseProvider.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,15 @@
22

33
namespace MichaelDzjap\TwoFactorAuth\Providers;
44

5-
use App\User;
6-
75
abstract class BaseProvider
86
{
97
/**
108
* Check if two-factor authentication is enabled.
119
*
12-
* @param \App\User $user
10+
* @param mixed $user
1311
* @return bool
1412
*/
15-
public function enabled(User $user)
13+
public function enabled($user)
1614
{
1715
$enabled = config('twofactor-auth.enabled', 'user');
1816

src/Providers/MessageBirdVerify.php

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace MichaelDzjap\TwoFactorAuth\Providers;
44

55
use Exception;
6-
use App\User;
76
use MessageBird\Client;
87
use MessageBird\Exceptions\RequestException;
98
use MessageBird\Objects\Verify;
@@ -36,21 +35,21 @@ public function __construct(Client $client)
3635
/**
3736
* Register a user with this provider.
3837
*
39-
* @param \App\User $user
38+
* @param mixed $user
4039
* @return void
4140
*/
42-
public function register(User $user) : void
41+
public function register($user) : void
4342
{
4443
//
4544
}
4645

4746
/**
4847
* Unregister a user with this provider.
4948
*
50-
* @param \App\User $user
49+
* @param mixed $user
5150
* @return bool
5251
*/
53-
public function unregister(User $user)
52+
public function unregister($user)
5453
{
5554
$result = $this->client->verify->delete($user->getTwoFactorAuthId());
5655
$user->setTwoFactorAuthId(null);
@@ -61,11 +60,11 @@ public function unregister(User $user)
6160
/**
6261
* Determine if the token is valid.
6362
*
64-
* @param \App\User $user
63+
* @param mixed $user
6564
* @param string $token
6665
* @return bool
6766
*/
68-
public function verify(User $user, string $token)
67+
public function verify($user, string $token)
6968
{
7069
// Parse potential MessageBird exceptions. Unfortunately a rather generic
7170
// RequestException is thrown both in the case of an expired token as well as
@@ -104,11 +103,11 @@ public function verify(User $user, string $token)
104103
/**
105104
* Send a user a two-factor authentication token via SMS.
106105
*
107-
* @param \App\User $user
106+
* @param mixed $user
108107
* @return void
109108
* @throws Exception $exception
110109
*/
111-
public function sendSMSToken(User $user) : void
110+
public function sendSMSToken($user) : void
112111
{
113112
if (!$user->getMobile()) {
114113
throw new Exception("No mobile phone number found for user {$user->id}.");

src/Providers/NullProvider.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
namespace MichaelDzjap\TwoFactorAuth\Providers;
44

5-
use App\User;
65
use MichaelDzjap\TwoFactorAuth\Contracts\SMSToken;
76
use MichaelDzjap\TwoFactorAuth\Contracts\TwoFactorProvider;
87

@@ -11,31 +10,31 @@ class NullProvider extends BaseProvider implements TwoFactorProvider, SMSToken
1110
/**
1211
* {@inheritdoc}
1312
*/
14-
public function register(User $user) : void
13+
public function register($user) : void
1514
{
1615
//
1716
}
1817

1918
/**
2019
* {@inheritdoc}
2120
*/
22-
public function unregister(User $user)
21+
public function unregister($user)
2322
{
2423
//
2524
}
2625

2726
/**
2827
* {@inheritdoc}
2928
*/
30-
public function verify(User $user, string $token)
29+
public function verify($user, string $token)
3130
{
3231
return true;
3332
}
3433

3534
/**
3635
* {@inheritdoc}
3736
*/
38-
public function sendSMSToken(User $user) : void
37+
public function sendSMSToken($user) : void
3938
{
4039
//
4140
}

0 commit comments

Comments
 (0)