Skip to content

Conversation

@Harmanpreet-Microsoft
Copy link
Contributor

Purpose

This pull request updates the .github/workflows/CAdeploy.yml file to enhance the notification process for deployment failures. The main improvement is the addition of a more detailed and structured email body for failure notifications.

Notification process improvements:

  • Enhanced the email body to include a detailed message with a personalized introduction, a description of the issue, the build URL, and a request for investigation. This replaces the previous minimalistic message.
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.-NA

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.-NA

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the deployment failure notification in the CAdeploy workflow by replacing the minimal JSON payload with a more detailed, personalized email body.

  • Introduces a here-doc to build a structured HTML email body.
  • Swaps the static -d JSON payload for the dynamic EMAIL_BODY variable.
  • Retains the curl-based POST to the Logic App endpoint.
Comments suppressed due to low confidence (3)

.github/workflows/CAdeploy.yml:524

  • The here-doc delimiter EOF is indented, so Bash will not recognize the closing marker. Either move EOF to the start of the line or use cat <<-EOF to allow indentation.
          EMAIL_BODY=$(cat <<EOF

.github/workflows/CAdeploy.yml:526

  • The JSON payload no longer includes a subject field which your Logic App consumer likely expects. Consider adding a "subject": "CA Deployment Failed" key alongside body.
            "body": "<p>Dear Team,</p><p>We would like to inform you that the Build-your-own-copilot-Solution-Accelerator(Client Advisior) Automation process has encountered an issue and has failed to complete successfully.</p><p><strong>Build URL:</strong> ${RUN_URL}<br> ${OUTPUT}</p><p>Please investigate the matter at your earliest convenience.</p><p>Best regards,<br>Your Automation Team</p>"

.github/workflows/CAdeploy.yml:526

  • The variable ${OUTPUT} may be undefined here, leading to an empty or malformed message. Ensure OUTPUT is set earlier or remove it if unused.
            "body": "<p>Dear Team,</p><p>We would like to inform you that the Build-your-own-copilot-Solution-Accelerator(Client Advisior) Automation process has encountered an issue and has failed to complete successfully.</p><p><strong>Build URL:</strong> ${RUN_URL}<br> ${OUTPUT}</p><p>Please investigate the matter at your earliest convenience.</p><p>Best regards,<br>Your Automation Team</p>"

@Roopan-Microsoft Roopan-Microsoft merged commit e599cb8 into main Jul 9, 2025
8 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-correctemailbody branch July 9, 2025 08:55
@github-actions
Copy link

github-actions bot commented Jul 9, 2025

🎉 This PR is included in version 1.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants