Skip to content

Commit 7a564c7

Browse files
author
S Raghav
committed
Address comments and add option to get all references
1 parent 50585d7 commit 7a564c7

File tree

2 files changed

+72
-29
lines changed

2 files changed

+72
-29
lines changed

‎GitHubReferences.ps1

Lines changed: 27 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ function Get-GitHubReference
2525
them individually.
2626
2727
.PARAMETER Reference
28-
Name of the reference, for example: "heads/<branch name>" for branches and "tags/<tag name>" for tags
28+
Name of the reference, for example: "heads/<branch name>" for branches and "tags/<tag name>" for tags.
29+
Gets all the references if not provided
2930
3031
.PARAMETER AccessToken
3132
If provided, this will be used as the AccessToken for authentication with the
@@ -36,7 +37,7 @@ function Get-GitHubReference
3637
with no commandline status update. When not specified, those commands run in
3738
the background, enabling the command prompt to provide status information.
3839
If not supplied here, the DefaultNoStatus configuration property value will be used.
39-
40+
4041
.OUTPUTS
4142
[PSCustomObject]
4243
Details of the git reference in the given repository
@@ -60,7 +61,6 @@ function Get-GitHubReference
6061
ParameterSetName='Uri')]
6162
[string] $Uri,
6263

63-
[Parameter(Mandatory)]
6464
[string] $Reference,
6565

6666
[string] $AccessToken,
@@ -77,6 +77,7 @@ function Get-GitHubReference
7777
$telemetryProperties = @{
7878
'OwnerName' = (Get-PiiSafeString -PlainText $OwnerName)
7979
'RepositoryName' = (Get-PiiSafeString -PlainText $RepositoryName)
80+
'ProvidedReference' = $PSBoundParameters.ContainsKey('Reference')
8081
}
8182

8283
if ($OwnerName -xor $RepositoryName)
@@ -85,14 +86,21 @@ function Get-GitHubReference
8586
Write-Log -Message $message -Level Error
8687
throw $message
8788
}
88-
$uriFragment = "/repos/$OwnerName/$RepositoryName/git/refs/$Reference"
89-
$description = "Getting Reference $Reference for $RepositoryName"
89+
90+
if (-not [String]::IsNullOrEmpty($RepositoryName))
91+
{
92+
$uriFragment = "/repos/$OwnerName/$RepositoryName/git/refs"
93+
$description = "Getting all references for $RepositoryName"
94+
if ($PSBoundParameters.ContainsKey('Reference'))
95+
{
96+
$uriFragment = $uriFragment + "/$Reference"
97+
$description = "Getting Reference $Reference for $RepositoryName"
98+
}
99+
}
90100

91101
$params = @{
92102
'UriFragment' = $uriFragment
93-
'Method' = 'Get'
94103
'Description' = $description
95-
'AcceptHeader' = 'application/vnd.github.symmetra-preview+json'
96104
'AccessToken' = $AccessToken
97105
'TelemetryEventName' = $MyInvocation.MyCommand.Name
98106
'TelemetryProperties' = $telemetryProperties
@@ -101,12 +109,19 @@ function Get-GitHubReference
101109

102110
try
103111
{
104-
return Invoke-GHRestMethod @params
112+
return Invoke-GHRestMethodMultipleResult @params
113+
105114
}
106115
catch
107116
{
108-
Write-InteractiveHost "No reference named $Reference exists in repository $RepositoryName" -NoNewline -f Red
109-
Write-Log -Level Error "No reference named $Reference exists in repository $RepositoryName"
117+
if ($PSBoundParameters.ContainsKey('Reference'))
118+
{
119+
Write-InteractiveHost "No reference named $Reference exists in repository $RepositoryName ..$_.Exception" -NoNewline -f Red
120+
Write-Log -Level Error "No reference named $Reference exists in repository $RepositoryName"
121+
return $null
122+
}
123+
Write-InteractiveHost "No references exist in repository $RepositoryName ..$_.Exception" -NoNewline -f Red
124+
Write-Log -Level Error "No references exist in repository $RepositoryName"
110125
return $null
111126
}
112127

@@ -156,7 +171,7 @@ function New-GitHubReference
156171
Details of the git reference created. Throws an Exception if the reference already exists
157172
158173
.EXAMPLE
159-
-GitHubReference -OwnerName Powershell -RepositoryName PowerShellForGitHub -Reference refs/heads/master -Sha aa218f56b14c9653891f9e74264a383fa43fefbd
174+
-GitHubReference -OwnerName Powershell -RepositoryName PowerShellForGitHub -Reference heads/master -Sha aa218f56b14c9653891f9e74264a383fa43fefbd
160175
#>
161176
[CmdletBinding(
162177
SupportsShouldProcess,
@@ -207,7 +222,7 @@ function New-GitHubReference
207222
$description = "Creating Reference $Reference for $RepositoryName from SHA $Sha"
208223

209224
$hashBody = @{
210-
'ref' = $Reference
225+
'ref' = "refs/" + $Reference
211226
'sha' = $Sha
212227
}
213228

‎Tests/GitHubReferences.Tests.ps1

Lines changed: 45 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -84,40 +84,40 @@ try
8484
Describe 'Create a new reference(branch) in repository' {
8585
$repositoryName = [Guid]::NewGuid()
8686
$repo = New-GitHubRepository -RepositoryName $repositoryName -AutoInit
87-
$existingref = @(Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/master")
87+
$existingref = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/master"
8888
$sha = $existingref.object.sha
8989

9090
Context 'On creating a valid reference in a new repository from a given SHA' {
91-
$refName = "refs/heads/" + [Guid]::NewGuid().ToString()
92-
$result = @(New-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $refName -Sha $sha)
91+
$refName = "heads/" + [Guid]::NewGuid().ToString()
92+
$result = New-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $refName -Sha $sha
9393

9494
It 'Should successfully create the reference' {
95-
$result.ref | Should Be $refName
95+
$result.ref | Should Be "refs/$refName"
9696
}
9797
}
9898

9999
Context 'On creating a valid reference in a new repository (specified by Uri) from a given SHA' {
100-
$refName = "refs/heads/" + [Guid]::NewGuid().ToString()
101-
$result = @(New-GitHubReference -Uri $repo.svn_url -Reference $refName -Sha $sha)
100+
$refName = "heads/" + [Guid]::NewGuid().ToString()
101+
$result = New-GitHubReference -Uri $repo.svn_url -Reference $refName -Sha $sha
102102

103103
It 'Should successfully create the reference' {
104-
$result.ref | Should Be $refName
104+
$result.ref | Should Be "refs/$refName"
105105
}
106106
}
107107

108108
Context 'On creating an existing reference in a new repository from a given SHA' {
109-
$refName = "refs/heads/master"
109+
$refName = "heads/master"
110110

111111
It 'Should throw an Exception' {
112-
{ @(New-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $refName -Sha $sha) } | Should Throw
112+
{ New-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $refName -Sha $sha } | Should Throw
113113
}
114114
}
115115

116116
Context 'On creating an existing reference in a new repository (specified by Uri) from a given SHA' {
117-
$refName = "refs/heads/master"
117+
$refName = "heads/master"
118118

119119
It 'Should throw an exception' {
120-
{ @(New-GitHubReference -Uri $repo.svn_url -Reference $refName -Sha $sha) } | Should Throw
120+
{ New-GitHubReference -Uri $repo.svn_url -Reference $refName -Sha $sha } | Should Throw
121121
}
122122
}
123123

@@ -127,40 +127,68 @@ try
127127
Describe 'Getting a reference(branch) from repository' {
128128
$repositoryName = [Guid]::NewGuid()
129129
$repo = New-GitHubRepository -RepositoryName $repositoryName -AutoInit
130+
$refName = "refs/heads/master"
130131

131132
Context 'On getting a valid reference from a new repository' {
132-
$reference = @(Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/master")
133+
$reference = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/master"
133134

134135
It 'Should return details of the reference' {
135-
$reference.ref | Should be "refs/heads/master"
136+
$reference.ref | Should be $refName
136137
}
137138
}
138139

139140
Context 'On getting an invalid reference from a new repository' {
140-
$reference = @(Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/someRandomRef")
141+
$reference = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/someRandomRef"
141142

142143
It 'Should not return any details' {
143144
$reference | Should be $null
144145
}
145146
}
146147

147148
Context 'On getting a valid reference using Uri from a new repository' {
148-
$reference = @(Get-GitHubReference -Uri $repo.svn_url -Reference "heads/master")
149+
$reference = Get-GitHubReference -Uri $repo.svn_url -Reference "heads/master"
149150

150151
It 'Should return details of the reference' {
151-
$reference.ref | Should be "refs/heads/master"
152+
$reference.ref | Should be $refName
152153
}
153154
}
154155

155156
Context 'On getting an invalid reference using Uri from a new repository' {
156-
$reference = @(Get-GitHubReference -Uri $repo.svn_url -Reference "heads/someRandomRef")
157+
$reference = Get-GitHubReference -Uri $repo.svn_url -Reference "heads/someRandomRef"
157158

158159
It 'Should not return any details' {
159160
$reference | Should be $null
160161
}
161162
}
162163
$null = Remove-GitHubRepository -OwnerName $ownerName -RepositoryName $repositoryName
163164
}
165+
166+
Describe 'Getting all references from repository' {
167+
$repositoryName = [Guid]::NewGuid()
168+
$repo = New-GitHubRepository -RepositoryName $repositoryName -AutoInit
169+
$existingref = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/master"
170+
$sha = $existingref.object.sha
171+
New-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/branch1" -Sha $sha
172+
$refNames = @("refs/heads/master", "refs/heads/branch1")
173+
174+
Context 'On getting all references from a new repository' {
175+
$reference = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName
176+
177+
It 'Should return all references' {
178+
($reference.ref | Where {$refNames -Contains $_}).Count | Should be $refNames.Count
179+
}
180+
}
181+
182+
Context 'On getting all references using Uri from a new repository' {
183+
$reference = Get-GitHubReference -Uri $repo.svn_url
184+
185+
It 'Should return all references' {
186+
($reference.ref | Where {$refNames -Contains $_}).Count | Should be $refNames.Count
187+
}
188+
}
189+
190+
$null = Remove-GitHubRepository -OwnerName $ownerName -RepositoryName $repositoryName
191+
}
164192
}
165193
}
166194
catch

0 commit comments

Comments
 (0)