From c88bd24708c8d71718fd0ecf55176043ecf20e68 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:55 -0400 Subject: [PATCH 01/79] spelling: align Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/index.ts b/src/core/prototypes/index.ts index 7429dadc39..f54db63a34 100644 --- a/src/core/prototypes/index.ts +++ b/src/core/prototypes/index.ts @@ -16,7 +16,7 @@ * * * Legends {@link "core/prototypes/legends/index"} * - * * Guides {@link "core/prototypes/guides/index"} helper non visual elements to allign other elements + * * Guides {@link "core/prototypes/guides/index"} helper non visual elements to align other elements * * * Glyphs {@link "core/prototypes/glyphs/index"} is container of other elements on plot segmets * From 62ebbdb57110c1a43ada249a22c976f1c87a3c15 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:54 -0400 Subject: [PATCH 02/79] spelling: alignment Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/utils/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/utils/index.ts b/src/app/utils/index.ts index 656f182f5c..9ca094ea91 100644 --- a/src/app/utils/index.ts +++ b/src/app/utils/index.ts @@ -381,7 +381,7 @@ export function isInIFrame() { } } -export function getAligntment(anchor: Element) { +export function getAlignment(anchor: Element) { let alignX: | "start-outer" | "inner" From 5809aaf743f883897e78a4884b2e644135b426ae Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:55 -0400 Subject: [PATCH 03/79] spelling: assume Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/application.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/application.tsx b/src/app/application.tsx index bb8c5838ab..ef02ecd01a 100644 --- a/src/app/application.tsx +++ b/src/app/application.tsx @@ -283,7 +283,7 @@ export class Application { deepClone(info.specification) ); - // if version wasn't saved in tempalte we asume it is 2.0.3 + // if version wasn't saved in tempalte we assume it is 2.0.3 if (info.template && info.template.version == undefined) { info.template.version = defaultVersionOfTemplate; } From 97ff00b0de1f2d6012479ceabf88a84970e37841 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:56 -0400 Subject: [PATCH 04/79] spelling: attribute Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/index.tsx b/src/app/index.tsx index 43cbb7a13a..d250453045 100644 --- a/src/app/index.tsx +++ b/src/app/index.tsx @@ -26,7 +26,7 @@ * * {@link ObjectClass.getAttributePanelWidgets} method uses interface of {@link WidgetManager} to build UI for mark attributes. (See {@link "core/prototypes/marks/index"}) * - * * {@link "app/views/index"} module contains general views for dataset displaying, file views for open, save, create chart and different panes like attribure panel link creator, object list editor, scale editor, scale panel with used scales list. + * * {@link "app/views/index"} module contains general views for dataset displaying, file views for open, save, create chart and different panes like attribute panel link creator, object list editor, scale editor, scale panel with used scales list. * * * {@link "app/views/dataset/table_view"} contains view for displaying dataset as table on creating the new chart or for displaying data samples after importing data * From b2d5c07cefe844b5f8a2ca0e1091a0fee4640647 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:56 -0400 Subject: [PATCH 05/79] spelling: attributes Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- sass/components/canvas/attribute_editor.scss | 2 +- src/app/views/panels/widgets/controls/fluentui_image.tsx | 2 +- src/app/views/panels/widgets/controls/fluentui_image_2.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sass/components/canvas/attribute_editor.scss b/sass/components/canvas/attribute_editor.scss index 458a07a621..473612f4c4 100644 --- a/sass/components/canvas/attribute_editor.scss +++ b/sass/components/canvas/attribute_editor.scss @@ -1119,7 +1119,7 @@ background: lighten($color-active, 30%); height: 26px; - &-attrubutes { + &-attributes { @extend .el-drag-over; width: auto; } diff --git a/src/app/views/panels/widgets/controls/fluentui_image.tsx b/src/app/views/panels/widgets/controls/fluentui_image.tsx index b409b21cb4..2a4c7d258f 100644 --- a/src/app/views/panels/widgets/controls/fluentui_image.tsx +++ b/src/app/views/panels/widgets/controls/fluentui_image.tsx @@ -149,7 +149,7 @@ export class InputImage extends ContextedComponent< {this.props.label} ) : null} - + {strings.objects.image.dropImage} diff --git a/src/app/views/panels/widgets/controls/fluentui_image_2.tsx b/src/app/views/panels/widgets/controls/fluentui_image_2.tsx index 65c66f43bd..1abd2b4a18 100644 --- a/src/app/views/panels/widgets/controls/fluentui_image_2.tsx +++ b/src/app/views/panels/widgets/controls/fluentui_image_2.tsx @@ -118,7 +118,7 @@ export class InputImage extends ContextedComponent< {this.props.label} ) : null} - + {strings.objects.image.dropImage} From 8943aef3ba4a8b3f7a2223ff167e6b16a6d12d20 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:57 -0400 Subject: [PATCH 06/79] spelling: available Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index acc4107941..a6d04862b6 100644 --- a/README.md +++ b/README.md @@ -128,6 +128,6 @@ contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additio # Documentation Run `yarn typedoc` to generate documentation pages. -The page will be awailable in [`./docs/charticulator`](./docs/charticulator/index.html) +The page will be available in [`./docs/charticulator`](./docs/charticulator/index.html) Start point of documentation is index page {@link "index"} \ No newline at end of file From 5c8e7447eff40d8dd5dcf5cb3d1ae8fbf7c0098a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:57 -0400 Subject: [PATCH 07/79] spelling: background Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/plot_segments/axis.ts | 46 +++++++++---------- src/core/specification/types.ts | 4 +- src/strings.ts | 2 +- src/tests/unit/charts/200_Mushrooms.chart | 8 ++-- .../unit/charts/World_Population_2017.chart | 12 ++--- 5 files changed, 36 insertions(+), 36 deletions(-) diff --git a/src/core/prototypes/plot_segments/axis.ts b/src/core/prototypes/plot_segments/axis.ts index 631fb6e55a..b744c14be4 100644 --- a/src/core/prototypes/plot_segments/axis.ts +++ b/src/core/prototypes/plot_segments/axis.ts @@ -69,8 +69,8 @@ import React = require("react"); export const defaultAxisStyle: Specification.Types.AxisRenderingStyle = { tickColor: { r: 0, g: 0, b: 0 }, - tickTextBackgroudColor: null, - tickTextBackgroudColorId: null, + tickTextBackgroundColor: null, + tickTextBackgroundColorId: null, showTicks: true, showBaseline: true, lineColor: { r: 0, g: 0, b: 0 }, @@ -135,7 +135,7 @@ export class AxisRenderer { } else { this.style = fillDefaultAxisStyle(deepClone(style)); } - this.style.tickTextBackgroudColorId = + this.style.tickTextBackgroundColorId = "axis-tick-filter-" + getRandomNumber(); return this; } @@ -713,8 +713,8 @@ export class AxisRenderer { style.fontSize, { fillColor: style.tickColor, - backgroundColor: style.tickTextBackgroudColor, - backgroundColorId: style.tickTextBackgroudColorId, + backgroundColor: style.tickTextBackgroundColor, + backgroundColorId: style.tickTextBackgroundColorId, } ); lines.push(text); @@ -745,8 +745,8 @@ export class AxisRenderer { style.fontSize, { fillColor: style.tickColor, - backgroundColor: style.tickTextBackgroudColor, - backgroundColorId: style.tickTextBackgroudColorId, + backgroundColor: style.tickTextBackgroundColor, + backgroundColorId: style.tickTextBackgroundColorId, }, this.plotSegment && this.dataFlow ? { @@ -788,8 +788,8 @@ export class AxisRenderer { style.fontSize, { fillColor: style.tickColor, - backgroundColor: style.tickTextBackgroudColor, - backgroundColorId: style.tickTextBackgroudColorId, + backgroundColor: style.tickTextBackgroundColor, + backgroundColorId: style.tickTextBackgroundColorId, }, this.plotSegment && this.dataFlow ? { @@ -850,8 +850,8 @@ export class AxisRenderer { style.fontSize, { fillColor: style.tickColor, - backgroundColor: style.tickTextBackgroudColor, - backgroundColorId: style.tickTextBackgroudColorId, + backgroundColor: style.tickTextBackgroundColor, + backgroundColorId: style.tickTextBackgroundColorId, }, this.plotSegment && this.dataFlow ? { @@ -921,8 +921,8 @@ export class AxisRenderer { style.fontSize, { fillColor: style.tickColor, - backgroundColor: style.tickTextBackgroudColor, - backgroundColorId: style.tickTextBackgroudColorId, + backgroundColor: style.tickTextBackgroundColor, + backgroundColorId: style.tickTextBackgroundColorId, }, this.plotSegment && this.dataFlow ? { @@ -980,8 +980,8 @@ export class AxisRenderer { style.fontSize, { fillColor: style.tickColor, - backgroundColor: style.tickTextBackgroudColor, - backgroundColorId: style.tickTextBackgroudColorId, + backgroundColor: style.tickTextBackgroundColor, + backgroundColorId: style.tickTextBackgroundColorId, }, this.plotSegment && this.dataFlow ? { @@ -1190,8 +1190,8 @@ export class AxisRenderer { style.fontSize, { fillColor: style.tickColor, - backgroundColor: style.tickTextBackgroudColor, - backgroundColorId: style.tickTextBackgroudColorId, + backgroundColor: style.tickTextBackgroundColor, + backgroundColorId: style.tickTextBackgroundColorId, } ); lines.push(gt); @@ -1219,8 +1219,8 @@ export class AxisRenderer { style.showTicks ? line : null, makeText(textX, textY, tick.label, style.fontFamily, style.fontSize, { fillColor: style.tickColor, - backgroundColor: style.tickTextBackgroudColor, - backgroundColorId: style.tickTextBackgroudColorId, + backgroundColor: style.tickTextBackgroundColor, + backgroundColorId: style.tickTextBackgroundColorId, }), ]); @@ -1267,8 +1267,8 @@ export class AxisRenderer { style.showTicks ? line : null, makeText(textX, textY, tick.label, style.fontFamily, style.fontSize, { fillColor: style.tickColor, - backgroundColor: style.tickTextBackgroudColor, - backgroundColorId: style.tickTextBackgroudColorId, + backgroundColor: style.tickTextBackgroundColor, + backgroundColorId: style.tickTextBackgroundColorId, }), ]); @@ -1593,10 +1593,10 @@ export function buildAxisAppearanceWidgets( manager.inputColor( { property: axisProperty, - field: ["style", "tickTextBackgroudColor"], + field: ["style", "tickTextBackgroundColor"], }, { - label: strings.objects.axes.tickTextBackgroudColor, + label: strings.objects.axes.tickTextBackgroundColor, labelKey: `tick-text-background-color-${axisProperty}`, allowNull: true, searchSection: [ diff --git a/src/core/specification/types.ts b/src/core/specification/types.ts index c0d09369ab..fb92b0d665 100644 --- a/src/core/specification/types.ts +++ b/src/core/specification/types.ts @@ -103,8 +103,8 @@ export interface AxisRenderingStyle extends AttributeMap { fontFamily: string; fontSize: number; tickSize: number; - tickTextBackgroudColor: Color; - tickTextBackgroudColorId: string; + tickTextBackgroundColor: Color; + tickTextBackgroundColorId: string; wordWrap: boolean; gridlineStyle: StrokeStyle; gridlineColor: Color; diff --git a/src/strings.ts b/src/strings.ts index a489bd285d..a96887d940 100644 --- a/src/strings.ts +++ b/src/strings.ts @@ -432,7 +432,7 @@ export const strings = { dataExpressions: "Data Expressions", lineColor: "Line Color", tickColor: "Tick Label Color", - tickTextBackgroudColor: "Tick background color", + tickTextBackgroundColor: "Tick background color", showTickLine: "Show Tick Line", showBaseline: "Show Baseline", verticalText: "Vertical text", diff --git a/src/tests/unit/charts/200_Mushrooms.chart b/src/tests/unit/charts/200_Mushrooms.chart index 3f12006e76..01fe1eceb1 100644 --- a/src/tests/unit/charts/200_Mushrooms.chart +++ b/src/tests/unit/charts/200_Mushrooms.chart @@ -1631,8 +1631,8 @@ "g": 0, "b": 0 }, - "tickTextBackgroudColor": null, - "tickTextBackgroudColorId": null, + "tickTextBackgroundColor": null, + "tickTextBackgroundColorId": null, "showTicks": true, "showBaseline": true, "lineColor": { @@ -1705,8 +1705,8 @@ "g": 0, "b": 0 }, - "tickTextBackgroudColor": null, - "tickTextBackgroudColorId": null, + "tickTextBackgroundColor": null, + "tickTextBackgroundColorId": null, "showTicks": true, "showBaseline": true, "lineColor": { diff --git a/src/tests/unit/charts/World_Population_2017.chart b/src/tests/unit/charts/World_Population_2017.chart index b38df8454a..b5049758bf 100644 --- a/src/tests/unit/charts/World_Population_2017.chart +++ b/src/tests/unit/charts/World_Population_2017.chart @@ -272,8 +272,8 @@ "g": 0, "b": 0 }, - "tickTextBackgroudColor": null, - "tickTextBackgroudColorId": null, + "tickTextBackgroundColor": null, + "tickTextBackgroundColorId": null, "showTicks": true, "showBaseline": true, "lineColor": { @@ -421,8 +421,8 @@ "g": 0, "b": 0 }, - "tickTextBackgroudColor": null, - "tickTextBackgroudColorId": null, + "tickTextBackgroundColor": null, + "tickTextBackgroundColorId": null, "showTicks": true, "showBaseline": true, "lineColor": { @@ -638,8 +638,8 @@ "g": 0, "b": 0 }, - "tickTextBackgroudColor": null, - "tickTextBackgroudColorId": null, + "tickTextBackgroundColor": null, + "tickTextBackgroundColorId": null, "showTicks": true, "showBaseline": true, "lineColor": { From 64b9fa763a369203c179c6cd3bdcb45b4851b542 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:58 -0400 Subject: [PATCH 08/79] spelling: bracket Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/expression/parser.pegjs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/core/expression/parser.pegjs b/src/core/expression/parser.pegjs index e0d0ab9b82..2cad8bb5c2 100644 --- a/src/core/expression/parser.pegjs +++ b/src/core/expression/parser.pegjs @@ -94,13 +94,13 @@ level4 return create_operator(flatten(op), expr); } -begin_braket "\"(\"" = "(" -end_braket "\")\"" = ")" +begin_bracket "\"(\"" = "(" +end_bracket "\")\"" = ")" comma "\",\'" = "," dot "." = "." -braket_expression - = begin_braket sp expr:levelm0 sp end_braket +bracket_expression + = begin_bracket sp expr:levelm0 sp end_bracket { return expr; } item @@ -109,11 +109,11 @@ item / lambda_function / fieldaccess / variable - / braket_expression + / bracket_expression fieldable = variable - / braket_expression + / bracket_expression fieldaccess = expr:fieldable fields:(sp dot sp variable_name)+ @@ -122,7 +122,7 @@ fieldaccess funcitem = fieldaccess / variable - / braket_expression + / bracket_expression funcname = name:variable_name names:("." variable_name)* @@ -142,7 +142,7 @@ argitems { return [ expr ] } argitem_list - = begin_braket sp source_args:argitems sp end_braket + = begin_bracket sp source_args:argitems sp end_bracket { var args = []; for(var i = 0; i < source_args.length; i++) { @@ -167,7 +167,7 @@ argnames { return [ expr ] } lambda_function - = begin_braket sp argNames:argnames sp end_braket sp "=>" sp expr:expression + = begin_bracket sp argNames:argnames sp end_bracket sp "=>" sp expr:expression { return new Expression.LambdaFunction(expr, argNames); } / argName:variable_name sp "=>" sp expr:expression { return new Expression.LambdaFunction(expr, [argName]); } From 52bb551da99006372a73254ebd8c2117f7484a34 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:28:46 -0400 Subject: [PATCH 09/79] spelling: can Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/plot_segments/line.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/plot_segments/line.ts b/src/core/prototypes/plot_segments/line.ts index 69a8be13b2..5206e1d872 100644 --- a/src/core/prototypes/plot_segments/line.ts +++ b/src/core/prototypes/plot_segments/line.ts @@ -28,7 +28,7 @@ import { AxisDataBinding } from "../../specification/types"; /** * Line plot segment distributes the elements on the line * - * (y1 and y2 can have diferent values, so line cna have some angle between line and axis lines) + * (y1 and y2 can have diferent values, so line can have some angle between line and axis lines) * y1 *------#------#------* y2 * x1 x2 * From c50ae2312960ab7c2a6bcac81e9f475cd084ae2a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:58 -0400 Subject: [PATCH 10/79] spelling: charticulator Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/dataflow/index.ts | 2 +- src/core/prototypes/marks/index.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/prototypes/dataflow/index.ts b/src/core/prototypes/dataflow/index.ts index fe30bfe2ca..52305a8286 100644 --- a/src/core/prototypes/dataflow/index.ts +++ b/src/core/prototypes/dataflow/index.ts @@ -6,7 +6,7 @@ * * {@link DataflowTable} provides data context for charticulator's expressions, solver, plotsegments. * - * {@link DataflowManager} is a proxy between dateset and other parts of charticualtor. + * {@link DataflowManager} is a proxy between dateset and other parts of charticulator. * * @packageDocumentation * @preferred diff --git a/src/core/prototypes/marks/index.ts b/src/core/prototypes/marks/index.ts index 0b4b063d10..602d27d8a1 100644 --- a/src/core/prototypes/marks/index.ts +++ b/src/core/prototypes/marks/index.ts @@ -43,7 +43,7 @@ * * All marks implement several methods of {@link ObjectClass} * for exmaple - * `{@link ObjectClass.getAttributePanelWidgets}` - the method responsible for displaying widgets in the property panel. Each time when a user selects the mark in the object browser, the charticualtor calls this method to display properties. Charticulator displays the properties for rectangle named `Shape1` + * `{@link ObjectClass.getAttributePanelWidgets}` - the method responsible for displaying widgets in the property panel. Each time when a user selects the mark in the object browser, the charticulator calls this method to display properties. Charticulator displays the properties for rectangle named `Shape1` * * ![Mark widgets](media://mark_widgets.png) * From 8f8805e992551126f94ed8dbdf52083b0237798f Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:59 -0400 Subject: [PATCH 11/79] spelling: classes Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/marks/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/marks/index.ts b/src/core/prototypes/marks/index.ts index 602d27d8a1..e5afa0f865 100644 --- a/src/core/prototypes/marks/index.ts +++ b/src/core/prototypes/marks/index.ts @@ -4,7 +4,7 @@ /** * # Marks * - * Most of mark elements extends {@link EmphasizableMarkClass} and {@link MarkClass} clases. + * Most of mark elements extends {@link EmphasizableMarkClass} and {@link MarkClass} classes. * * Each mark has a property * From 2e78c8a7088274821833aacfadfc909f01f46c03 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:52:59 -0400 Subject: [PATCH 12/79] spelling: collapse Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/views/fluentui_tool_bar.tsx | 6 +++--- src/app/views/tool_bar.tsx | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/app/views/fluentui_tool_bar.tsx b/src/app/views/fluentui_tool_bar.tsx index e39b1be7ce..bd6e5b1870 100644 --- a/src/app/views/fluentui_tool_bar.tsx +++ b/src/app/views/fluentui_tool_bar.tsx @@ -27,7 +27,7 @@ import { useState } from "react"; import { useEffect } from "react"; import { Icon } from "@fluentui/react/lib/Icon"; -const minWidthToColapseButtons = Object.freeze({ +const minWidthToCollapseButtons = Object.freeze({ guides: 1090, plotSegments: 1120, scaffolds: 1211, @@ -496,7 +496,7 @@ export const FluentUIToolbar: React.FC<{ {strings.toolbar.guides} )} - {innerWidth > minWidthToColapseButtons.guides ? ( + {innerWidth > minWidthToCollapseButtons.guides ? ( <> )} - {innerWidth > minWidthToColapseButtons.scaffolds ? ( + {innerWidth > minWidthToCollapseButtons.scaffolds ? ( <> )} - {innerWidth > minWidthToColapseButtons.guides ? ( + {innerWidth > minWidthToCollapseButtons.guides ? ( <> )} - {innerWidth > minWidthToColapseButtons.plotSegments ? ( + {innerWidth > minWidthToCollapseButtons.plotSegments ? ( <> )} - {innerWidth > minWidthToColapseButtons.scaffolds ? ( + {innerWidth > minWidthToCollapseButtons.scaffolds ? ( <> Date: Sun, 2 Oct 2022 14:07:30 -0400 Subject: [PATCH 13/79] spelling: column Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/dataset/dsv_parser.ts | 2 +- src/strings.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/dataset/dsv_parser.ts b/src/core/dataset/dsv_parser.ts index bb9634a501..0a523c3860 100644 --- a/src/core/dataset/dsv_parser.ts +++ b/src/core/dataset/dsv_parser.ts @@ -44,7 +44,7 @@ export interface LocaleFileFormat { } /** - * Parses data from file. Returns converted rows and list of colum names with types. + * Parses data from file. Returns converted rows and list of column names with types. * Calls {@link inferAndConvertColumn} method from {@link "core/dataset/data_types"} for convert types. * @param fileName input file name for parsing * @param content data of file diff --git a/src/strings.ts b/src/strings.ts index a96887d940..e68aff6bdb 100644 --- a/src/strings.ts +++ b/src/strings.ts @@ -187,7 +187,7 @@ export const strings = { loadSample: "Load Sample Dataset...", links: "Links", messageNoID: (keyColumn: string) => - `No ${keyColumn} colum are specified in main table`, + `No ${keyColumn} column are specified in main table`, messageNoSourceOrTargetID: ( linkSourceKeyColumn: string, linkTargetKeyColumn: string From 2caee9ccfbc8d9b13d222cbe53ee569f279a8229 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:03 -0400 Subject: [PATCH 14/79] spelling: columns Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/actions/actions.ts | 2 +- src/strings.ts | 2 +- src/tests/karma/application_ui.test.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/actions/actions.ts b/src/app/actions/actions.ts index e08bd27306..77388b7f37 100644 --- a/src/app/actions/actions.ts +++ b/src/app/actions/actions.ts @@ -283,7 +283,7 @@ export class RemoveMarkFromGlyph extends Action { } /** - * Dispatches when user binds table coulmns to attributes + * Dispatches when user binds table columns to attributes */ export class MapDataToMarkAttribute extends Action { /** diff --git a/src/strings.ts b/src/strings.ts index e68aff6bdb..ebc810148c 100644 --- a/src/strings.ts +++ b/src/strings.ts @@ -192,7 +192,7 @@ export const strings = { linkSourceKeyColumn: string, linkTargetKeyColumn: string ) => - `No ${linkSourceKeyColumn} or ${linkTargetKeyColumn} colums are specified in links table`, + `No ${linkSourceKeyColumn} or ${linkTargetKeyColumn} columns are specified in links table`, removeButtonText: "Remove", removeButtonTitle: "Remove this table", }, diff --git a/src/tests/karma/application_ui.test.ts b/src/tests/karma/application_ui.test.ts index 31d138186f..1c48318930 100644 --- a/src/tests/karma/application_ui.test.ts +++ b/src/tests/karma/application_ui.test.ts @@ -168,7 +168,7 @@ describe("Charticulator", () => { const columns = dataColumnsSelector.querySelectorAll( "span.el-text" ); - // select all coulmns + // select all columns columns.forEach((column) => column.click()); //click to create legend button From 8a85f1d6387f7d2c955f6af069c297a58c53098b Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:00 -0400 Subject: [PATCH 15/79] spelling: components Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/index.tsx b/src/app/index.tsx index d250453045..3e78339914 100644 --- a/src/app/index.tsx +++ b/src/app/index.tsx @@ -20,7 +20,7 @@ * * * {@link "app/backend/indexed_db"} contains class {@link IndexedDBBackend}. It wraps [IndexedDB API](https://developer.mozilla.org/docs/Web/API/IndexedDB_API) to save user charts in the browser storage. * - * * {@link "app/components/index"} contains general high-level componenets for UI. Other low-level components ("bricks" of UI) are in {@link "app/views/index"} module. + * * {@link "app/components/index"} contains general high-level components for UI. Other low-level components ("bricks" of UI) are in {@link "app/views/index"} module. * * Charticulator has {@link WidgetManager} class for managing those components. It's "facade" over all components. * From 465aef23bbfe02088ad0ed22ee3fa2443d4f73ea Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:00 -0400 Subject: [PATCH 16/79] spelling: configuration Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/container/chart_template.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/container/chart_template.ts b/src/container/chart_template.ts index 01fd1f8654..cb6dfe8c41 100644 --- a/src/container/chart_template.ts +++ b/src/container/chart_template.ts @@ -389,7 +389,7 @@ export class ChartTemplate { ) as Specification.Types.AxisDataBinding; axisDataBinding.expression = expression; if (inference.autoDomainMin || inference.autoDomainMax) { - // disableAuto flag responsible for disabling/enabling configulration scale domains when new data is coming + // disableAuto flag responsible for disabling/enabling configuration scale domains when new data is coming // If disableAuto is true, the same scales will be used for data // Example: If disableAuto is true, axis values will be same for all new data sets. let vector = getExpressionVector( From 31199661dc87b991aa1209f4a36fa7ca1ceff8ca Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:01 -0400 Subject: [PATCH 17/79] spelling: constraints Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/state.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/prototypes/state.ts b/src/core/prototypes/state.ts index cfaea5f976..84fd3f4a2b 100644 --- a/src/core/prototypes/state.ts +++ b/src/core/prototypes/state.ts @@ -151,10 +151,10 @@ export class ChartStateManager { return true; } else { for (let index = 0; index < origin.constraints.length; index++) { - const originConstringts = origin.constraints[index]; + const originConstraints = origin.constraints[index]; const current = chart.constraints[index]; expect_deep_approximately_equals( - originConstringts, + originConstraints, current, defaultDifferenceApproximation, true From 93e64d70081dd166f3f171e02b5c6ea03fd37acd Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:01 -0400 Subject: [PATCH 18/79] spelling: contains Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/specification/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/specification/types.ts b/src/core/specification/types.ts index fb92b0d665..939c21cf7f 100644 --- a/src/core/specification/types.ts +++ b/src/core/specification/types.ts @@ -72,7 +72,7 @@ export interface AxisDataBinding extends AttributeMap { orderMode?: OrderMode; /** scrolling options */ - // allCategories contsins all data set and categories property uses to display current content + // allCategories contains all data set and categories property uses to display current content allowScrolling?: boolean; allCategories?: string[]; scrollPosition?: number; From a63591fece149611d27e7443af178436f8d0ff5e Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:02 -0400 Subject: [PATCH 19/79] spelling: conversion Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/utils/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/utils/index.ts b/src/app/utils/index.ts index 9ca094ea91..f4e2548bdf 100644 --- a/src/app/utils/index.ts +++ b/src/app/utils/index.ts @@ -165,7 +165,7 @@ export function stringToDataURL(mimeType: string, content: string) { return "data:" + mimeType + ";base64," + b64EncodeUnicode(content); } -function checkConvertion( +function checkConversion( type: DataType, dataSample: (string | boolean | Date | number)[] ) { @@ -303,7 +303,7 @@ export function getConvertableTypes( return true; } if (dataSample) { - return checkConvertion( + return checkConversion( t, dataSample.map((d) => d && d.toString()) ); From 114a67f8ed41cda26943a5c48a661b04061fc3bc Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:02 -0400 Subject: [PATCH 20/79] spelling: coordinate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/common/math.ts | 4 ++-- src/core/prototypes/common.ts | 2 +- src/core/prototypes/marks/image.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/common/math.ts b/src/core/common/math.ts index 98cf0f056e..02b1700c59 100644 --- a/src/core/common/math.ts +++ b/src/core/common/math.ts @@ -54,12 +54,12 @@ export namespace Geometry { return { x: p.x / len, y: p.y / len }; } - /** Rotate a vector 90 degrees (counter-clock-wise, but clock-wise in screen coordiantes) */ + /** Rotate a vector 90 degrees (counter-clock-wise, but clock-wise in screen coordinates) */ export function vectorRotate90(p: Vector): Vector { return { y: p.x, x: -p.y }; } - /** Rotate a vector by a angle in radians (counter-clock-wise, but clock-wise in screen coordiantes) */ + /** Rotate a vector by a angle in radians (counter-clock-wise, but clock-wise in screen coordinates) */ export function vectorRotate(p: Vector, radians: number): Vector { return { x: p.x * Math.cos(radians) + p.y * Math.sin(radians), diff --git a/src/core/prototypes/common.ts b/src/core/prototypes/common.ts index ccad3ce309..0f793550a7 100644 --- a/src/core/prototypes/common.ts +++ b/src/core/prototypes/common.ts @@ -141,7 +141,7 @@ export namespace Handles { y: number; } - /** A line with a x or y coordiante, and a span on the other */ + /** A line with a x or y coordinate, and a span on the other */ export interface Line extends Description { type: "line"; axis: "x" | "y"; diff --git a/src/core/prototypes/marks/image.ts b/src/core/prototypes/marks/image.ts index 5266d9abf8..35b9eeef19 100644 --- a/src/core/prototypes/marks/image.ts +++ b/src/core/prototypes/marks/image.ts @@ -365,7 +365,7 @@ export class ImageElementClass extends EmphasizableMarkClass< ); } - // Center in local coordiantes + // Center in local coordinates const cx = (attrs.x1 + attrs.x2) / 2; const cy = (attrs.y1 + attrs.y2) / 2; From 8824608cbfacb9651a3c4c32e0f59b56867eec6f Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:07:53 -0400 Subject: [PATCH 21/79] spelling: coordinator Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/solver/plugins/polar_coordinator.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/core/solver/plugins/polar_coordinator.ts b/src/core/solver/plugins/polar_coordinator.ts index f730be1303..4105ecde1f 100644 --- a/src/core/solver/plugins/polar_coordinator.ts +++ b/src/core/solver/plugins/polar_coordinator.ts @@ -10,7 +10,7 @@ import { snapToAttribute } from "../../prototypes/update_attribute"; import { ConstraintPlugin, ConstraintSolver, Variable } from "../abstract"; // eslint-disable-next-line -export interface PolarCoordinatorPluginOptions {} +export interface PolarCoordinatorPluginOptions { } // Converts Polar coordinates to cartesian coordinates export class PolarCoordinatorPlugin extends ConstraintPlugin { @@ -22,7 +22,7 @@ export class PolarCoordinatorPlugin extends ConstraintPlugin { radialVarable: Variable[]; angleVarable: Variable[]; chartConstraints: Specification.Constraint[]; - coordinatoObjectID: string; + coordinatorObjectID: string; chartMananger: ChartStateManager; constructor( @@ -33,7 +33,7 @@ export class PolarCoordinatorPlugin extends ConstraintPlugin { angleVarable: Variable[], attrs: PolarGuideCoordinatorAttributesExtend, chartConstraints: Specification.Constraint[], - coordinatoObjectID: string, + coordinatorObjectID: string, chartMananger: ChartStateManager ) { super(); @@ -44,7 +44,7 @@ export class PolarCoordinatorPlugin extends ConstraintPlugin { this.angleVarable = angleVarable; this.attrs = attrs; this.chartConstraints = chartConstraints; - this.coordinatoObjectID = coordinatoObjectID; + this.coordinatorObjectID = coordinatorObjectID; this.chartMananger = chartMananger; } @@ -96,14 +96,14 @@ export class PolarCoordinatorPlugin extends ConstraintPlugin { snapToAttribute( this.chartMananger, this.chartConstraints, - this.coordinatoObjectID, + this.coordinatorObjectID, attrXname, cx + tx ); snapToAttribute( this.chartMananger, this.chartConstraints, - this.coordinatoObjectID, + this.coordinatorObjectID, attrYname, cy + ty ); From bacd70abeab45c199fcdbaf14cf2bfe12583eb70 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:08:58 -0400 Subject: [PATCH 22/79] spelling: count Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/plot_segments/region_2d/base.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/plot_segments/region_2d/base.ts b/src/core/prototypes/plot_segments/region_2d/base.ts index ff8fe7e2a1..1ac7a5cc59 100644 --- a/src/core/prototypes/plot_segments/region_2d/base.ts +++ b/src/core/prototypes/plot_segments/region_2d/base.ts @@ -244,7 +244,7 @@ export class DodgingFitters { } /** - * Describes variables for constraints group. Count of group matches with data cound + * Describes variables for constraints group. Count of group matches with data count */ export class SublayoutGroup { public group: number[]; From 890170cc7812a3d9da5b789cc33b64b493873213 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:04 -0400 Subject: [PATCH 23/79] spelling: curve Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/plot_segments/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/plot_segments/index.ts b/src/core/prototypes/plot_segments/index.ts index efbeb3c17b..5616a85527 100644 --- a/src/core/prototypes/plot_segments/index.ts +++ b/src/core/prototypes/plot_segments/index.ts @@ -22,7 +22,7 @@ * * ![Cartesian plot segmets](media://cartesian_plot.png) * - * {@link CurvePlotSegment} - puts elements on cruve drawn by user. + * {@link CurvePlotSegment} - puts elements on curve drawn by user. * * ![Curve plot](media://curve_plot.png) * From 8faec8f59ba569ca7c9433ac6ed5175181cfc23e Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:29:02 -0400 Subject: [PATCH 24/79] spelling: dataset Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/dataflow/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/dataflow/index.ts b/src/core/prototypes/dataflow/index.ts index 52305a8286..b77670a6c1 100644 --- a/src/core/prototypes/dataflow/index.ts +++ b/src/core/prototypes/dataflow/index.ts @@ -6,7 +6,7 @@ * * {@link DataflowTable} provides data context for charticulator's expressions, solver, plotsegments. * - * {@link DataflowManager} is a proxy between dateset and other parts of charticulator. + * {@link DataflowManager} is a proxy between dataset and other parts of charticulator. * * @packageDocumentation * @preferred From c38eba64804f12563580325d9a05becd50bb0ac5 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:09:26 -0400 Subject: [PATCH 25/79] spelling: decimal Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/application.tsx | 8 ++++---- src/container/container.tsx | 4 ++-- src/tests/karma/application_ui.test.ts | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/app/application.tsx b/src/app/application.tsx index ef02ecd01a..965d9fae89 100644 --- a/src/app/application.tsx +++ b/src/app/application.tsx @@ -51,7 +51,7 @@ import { EditorType } from "./stores/app_store"; import { LocalizationConfig } from "../container/container"; export class ApplicationExtensionContext implements ExtensionContext { - constructor(public app: Application) {} + constructor(public app: Application) { } public getGlobalDispatcher(): Dispatcher { return this.app.appStore.dispatcher; @@ -175,7 +175,7 @@ export class Application { ); const DelimiterSymbol = parseSafe( window.localStorage.getItem(LocalStorageKeys.DelimiterSymbol) || - defaultDelimiter, + defaultDelimiter, defaultDelimiter ); const GroupSymbol = parseSafe( @@ -184,7 +184,7 @@ export class Application { ); const NumberFormatRemove = parseSafe( window.localStorage.getItem(LocalStorageKeys.NumberFormatRemove) || - defaultNumberFormat.remove, + defaultNumberFormat.remove, defaultNumberFormat.remove ); @@ -207,7 +207,7 @@ export class Application { setFormatOptions({ currency: [localizaiton?.currency, ""] ?? defaultCurrency, grouping: defaultDigitsGroup, - decimal: localizaiton?.decemalDelimiter ?? defaultNumberFormat.decimal, + decimal: localizaiton?.decimalDelimiter ?? defaultNumberFormat.decimal, thousands: localizaiton?.thousandsDelimiter ?? defaultNumberFormat.decimal, }); diff --git a/src/container/container.tsx b/src/container/container.tsx index 3aa031ebb0..8822f686d1 100644 --- a/src/container/container.tsx +++ b/src/container/container.tsx @@ -42,7 +42,7 @@ export interface ChartContainerComponentProps { export interface LocalizationConfig { currency: string; thousandsDelimiter: string; - decemalDelimiter: string; + decimalDelimiter: string; } export interface ChartContainerComponentState { @@ -223,7 +223,7 @@ export class ChartContainer extends EventEmitter { setFormatOptions({ currency: [localizaiton?.currency, ""] ?? defaultCurrency, grouping: defaultDigitsGroup, - decimal: localizaiton?.decemalDelimiter ?? defaultNumberFormat.decimal, + decimal: localizaiton?.decimalDelimiter ?? defaultNumberFormat.decimal, thousands: localizaiton?.thousandsDelimiter ?? defaultNumberFormat.decimal, }); diff --git a/src/tests/karma/application_ui.test.ts b/src/tests/karma/application_ui.test.ts index 1c48318930..21570d8418 100644 --- a/src/tests/karma/application_ui.test.ts +++ b/src/tests/karma/application_ui.test.ts @@ -57,7 +57,7 @@ describe("Charticulator", () => { { currency: "$", thousandsDelimiter: ",", - decemalDelimiter: ".", + decimalDelimiter: ".", } ) .then(() => { From 2e36077eafae42b425a9ad9d7c14d052828f6915 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:04 -0400 Subject: [PATCH 26/79] spelling: default Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../components/colors/color_space_select.tsx | 4 +-- .../dataset/data_field_binding_builder.tsx | 12 +++---- src/app/views/dataset/dataset_view.tsx | 8 ++--- src/app/views/panels/radio_control.tsx | 4 +-- .../panels/widgets/controls/combo_box.tsx | 8 ++--- .../fluentui_customized_components.tsx | 32 +++++++++---------- .../controls/fluentui_empty_mapping.tsx | 4 +-- .../widgets/controls/fluentui_image.tsx | 8 ++--- .../widgets/controls/fluentui_image_2.tsx | 8 ++--- .../widgets/controls/fluentui_input_color.tsx | 6 ++-- .../controls/fluentui_input_number.tsx | 6 ++-- .../fluentui_reorder_string_value.tsx | 8 ++--- .../panels/widgets/fluent_mapping_editor.tsx | 22 ++++++------- .../views/panels/widgets/fluentui_filter.tsx | 4 +-- .../views/panels/widgets/fluentui_manager.tsx | 24 +++++++------- .../panels/widgets/fluentui_value_editor.tsx | 8 ++--- src/app/views/panels/widgets/styles.tsx | 4 +-- 17 files changed, 85 insertions(+), 85 deletions(-) diff --git a/src/app/components/colors/color_space_select.tsx b/src/app/components/colors/color_space_select.tsx index 1c8aac33e2..d72d116b76 100644 --- a/src/app/components/colors/color_space_select.tsx +++ b/src/app/components/colors/color_space_select.tsx @@ -3,7 +3,7 @@ import * as React from "react"; import { ComboBox, IComboBoxOption } from "@fluentui/react"; -import { defultComponentsHeight } from "../../views/panels/widgets/controls/fluentui_customized_components"; +import { defaultComponentsHeight } from "../../views/panels/widgets/controls/fluentui_customized_components"; import { Color } from "../../../core"; import { ColorSpaceDescription, @@ -47,7 +47,7 @@ export class ColorSpaceSelect extends React.Component< }} styles={{ root: { - ...defultComponentsHeight, + ...defaultComponentsHeight, }, input: { width: "100px !important", diff --git a/src/app/views/dataset/data_field_binding_builder.tsx b/src/app/views/dataset/data_field_binding_builder.tsx index a2ec54894e..7e6e6d859a 100644 --- a/src/app/views/dataset/data_field_binding_builder.tsx +++ b/src/app/views/dataset/data_field_binding_builder.tsx @@ -40,7 +40,7 @@ import { AggregationFunctionDescription } from "../../../core/expression"; import { defaultLabelStyle, defaultStyle, - defultBindButtonSize, + defaultBindButtonSize, FluentDataBindingMenuItem, FluentDataBindingMenuLabel, } from "../panels/widgets/controls/fluentui_customized_components"; @@ -85,7 +85,7 @@ interface Builder { /** * Add default value */ - produceDefaultValue(dafaultValue: IDefaultValue): void; + produceDefaultValue(defaultValue: IDefaultValue): void; getMenuItems(): IContextualMenuItem[]; @@ -739,8 +739,8 @@ export class MenuItemBuilder implements Builder { this.menuItemsCreator.setFieds(datasetStore, table, kinds, types); } - public produceDefaultValue(dafaultValue: IDefaultValue): void { - this.menuItemsCreator.produceDefaultValue(dafaultValue); + public produceDefaultValue(defaultValue: IDefaultValue): void { + this.menuItemsCreator.produceDefaultValue(defaultValue); } public buildMenu(): void { @@ -845,12 +845,12 @@ export class Director { ...(defaultStyle as any), title: { ...defaultStyle.title, - lineHeight: defultBindButtonSize.height, + lineHeight: defaultBindButtonSize.height, borderWidth: "0px", }, dropdownOptionText: { boxSizing: "unset", - lineHeight: defultBindButtonSize.height, + lineHeight: defaultBindButtonSize.height, }, callout: { minWidth: 180, diff --git a/src/app/views/dataset/dataset_view.tsx b/src/app/views/dataset/dataset_view.tsx index 8c7235e830..1fe1c5b863 100644 --- a/src/app/views/dataset/dataset_view.tsx +++ b/src/app/views/dataset/dataset_view.tsx @@ -38,7 +38,7 @@ import { FileViewImport, MappingMode } from "../file_view/import_view"; import { strings } from "../../../strings"; import { EditorType } from "../../stores/app_store"; import { Callout, DefaultButton } from "@fluentui/react"; -import { defultBindButtonSize } from "../panels/widgets/controls/fluentui_customized_components"; +import { defaultBindButtonSize } from "../panels/widgets/controls/fluentui_customized_components"; export interface DatasetViewProps { store: AppStore; @@ -93,9 +93,9 @@ export interface ColumnsViewState { const buttonStyles = { root: { - height: `${defultBindButtonSize}px`, - width: `${defultBindButtonSize}px`, - minWidth: `${defultBindButtonSize}px`, + height: `${defaultBindButtonSize}px`, + width: `${defaultBindButtonSize}px`, + minWidth: `${defaultBindButtonSize}px`, padding: "0px", border: "none", }, diff --git a/src/app/views/panels/radio_control.tsx b/src/app/views/panels/radio_control.tsx index bc27a445cc..99207ebfbf 100644 --- a/src/app/views/panels/radio_control.tsx +++ b/src/app/views/panels/radio_control.tsx @@ -5,7 +5,7 @@ import * as React from "react"; import { DefaultButton } from "@fluentui/react"; import { SVGImageIcon } from "../../../app/components"; import * as R from "../../../app/resources"; -import { defultComponentsHeight } from "../../../app/views/panels/widgets/controls/fluentui_customized_components"; +import { defaultComponentsHeight } from "../../../app/views/panels/widgets/controls/fluentui_customized_components"; export interface PanelRadioControlProps { options: string[]; @@ -51,7 +51,7 @@ export class PanelRadioControl extends React.Component< root: { marginRight: 5, marginLeft: 5, - ...defultComponentsHeight, + ...defaultComponentsHeight, }, }} onRenderIcon={() => { diff --git a/src/app/views/panels/widgets/controls/combo_box.tsx b/src/app/views/panels/widgets/controls/combo_box.tsx index b389cf0628..015a5f1727 100644 --- a/src/app/views/panels/widgets/controls/combo_box.tsx +++ b/src/app/views/panels/widgets/controls/combo_box.tsx @@ -11,7 +11,7 @@ import { fontList } from "../../../../../core"; import { defaultLabelStyle, defaultStyle, - defultComponentsHeight, + defaultComponentsHeight, } from "./fluentui_customized_components"; export interface ComboBoxFontFamilyProps { @@ -41,8 +41,8 @@ export const FluentComboBoxFontFamily: React.FC = ( fontFamily: fontName, }, root: { - ...defultComponentsHeight, - minHeight: defultComponentsHeight.height, + ...defaultComponentsHeight, + minHeight: defaultComponentsHeight.height, }, }, })); @@ -66,7 +66,7 @@ export const FluentComboBoxFontFamily: React.FC = ( styles={{ ...defaultStyle, root: { - ...defultComponentsHeight, + ...defaultComponentsHeight, }, }} selectedKey={currentValue} diff --git a/src/app/views/panels/widgets/controls/fluentui_customized_components.tsx b/src/app/views/panels/widgets/controls/fluentui_customized_components.tsx index 57251c7436..f844157a45 100644 --- a/src/app/views/panels/widgets/controls/fluentui_customized_components.tsx +++ b/src/app/views/panels/widgets/controls/fluentui_customized_components.tsx @@ -17,7 +17,7 @@ import { } from "@fluentui/react"; import styled from "styled-components"; -export const defultBindButtonSize = { +export const defaultBindButtonSize = { height: "24px", width: "24px", }; @@ -31,8 +31,8 @@ export const FluentButton = styled.div<{ margin-left: ${({ marginLeft }) => marginLeft || "unset"}; display: inline-block; padding: 0px ${({ paddingRight }) => paddingRight || "4px"} 0px 0px; - height: ${defultBindButtonSize.height}; - line-height: ${defultBindButtonSize.height}; + height: ${defaultBindButtonSize.height}; + line-height: ${defaultBindButtonSize.height}; button { padding: 4px; } @@ -139,7 +139,7 @@ export const FluentGroupedList = styled.div<{ marginLeft?: number }>` min-height: 24px; } `; -export const defultComponentsHeight = { +export const defaultComponentsHeight = { height: "24px", lineHeight: "unset", }; @@ -155,10 +155,10 @@ export const groupHeaderStyles: IStyleFunctionOrObject< display: "none", }, groupHeaderContainer: { - ...defultComponentsHeight, + ...defaultComponentsHeight, }, expand: { - ...defultBindButtonSize, + ...defaultBindButtonSize, fontSize: "unset", }, dropIcon: { @@ -223,45 +223,45 @@ export const FluentDatePickerWrapper = styled.div` export const defaultStyle: any = { field: { - defultComponentsHeight, + defaultComponentsHeight, height: "20px", }, - fieldGroup: defultComponentsHeight, + fieldGroup: defaultComponentsHeight, dropdown: { boxSizing: "unset", - ...defultComponentsHeight, + ...defaultComponentsHeight, }, dropdownOptionText: { boxSizing: "unset", - ...defultComponentsHeight, + ...defaultComponentsHeight, }, dropdownItem: { boxSizing: "unset", minHeight: "25px", - ...defultComponentsHeight, + ...defaultComponentsHeight, }, dropdownItemHeader: { boxSizing: "unset", - ...defultComponentsHeight, + ...defaultComponentsHeight, }, dropdownItemSelected: { boxSizing: "unset", minHeight: "24px", lineHeight: "24px", - ...defultComponentsHeight, + ...defaultComponentsHeight, }, caretDown: { boxSizing: "unset", - ...defultComponentsHeight, + ...defaultComponentsHeight, }, caretDownWrapper: { boxSizing: "unset", marginTop: "5px", - ...defultComponentsHeight, + ...defaultComponentsHeight, }, title: { boxSizing: "unset", - ...defultComponentsHeight, + ...defaultComponentsHeight, height: "22px", lineHeight: "unset", }, diff --git a/src/app/views/panels/widgets/controls/fluentui_empty_mapping.tsx b/src/app/views/panels/widgets/controls/fluentui_empty_mapping.tsx index e511d7cab3..f296bf9677 100644 --- a/src/app/views/panels/widgets/controls/fluentui_empty_mapping.tsx +++ b/src/app/views/panels/widgets/controls/fluentui_empty_mapping.tsx @@ -5,7 +5,7 @@ import * as React from "react"; import { DefaultButton, TextField } from "@fluentui/react"; import { defaultStyle, - defultBindButtonSize, + defaultBindButtonSize, FluentButton, FluentTextField, labelRender, @@ -116,7 +116,7 @@ export const EmptyColorButton = ({ styles={{ root: { minWidth: "unset", - ...defultBindButtonSize, + ...defaultBindButtonSize, marginLeft: 5, }, }} diff --git a/src/app/views/panels/widgets/controls/fluentui_image.tsx b/src/app/views/panels/widgets/controls/fluentui_image.tsx index 2a4c7d258f..6222df37eb 100644 --- a/src/app/views/panels/widgets/controls/fluentui_image.tsx +++ b/src/app/views/panels/widgets/controls/fluentui_image.tsx @@ -18,7 +18,7 @@ import { } from "@fluentui/react"; import { defaultLabelStyle, - defultBindButtonSize, + defaultBindButtonSize, FluentActionButton, FluentButton, } from "./fluentui_customized_components"; @@ -161,12 +161,12 @@ export class InputImage extends ContextedComponent< ) : null} ) : null} = (props) => { diff --git a/src/app/views/panels/widgets/fluentui_manager.tsx b/src/app/views/panels/widgets/fluentui_manager.tsx index 668153925d..e3c5c7c326 100644 --- a/src/app/views/panels/widgets/fluentui_manager.tsx +++ b/src/app/views/panels/widgets/fluentui_manager.tsx @@ -78,8 +78,8 @@ import { FluentInputExpression } from "./controls/fluentui_input_expression"; import { defaultLabelStyle, defaultStyle, - defultBindButtonSize, - defultComponentsHeight, + defaultBindButtonSize, + defaultComponentsHeight, FluentButton, FluentCheckbox, FluentDatePickerWrapper, @@ -733,7 +733,7 @@ export class FluentUIWidgetManager label: null, root: { minWidth: "unset", - ...defultBindButtonSize, + ...defaultBindButtonSize, }, }} title={options.labels[index]} @@ -783,7 +783,7 @@ export class FluentUIWidgetManager styles={{ label: defaultLabelStyle, root: { - ...defultComponentsHeight, + ...defaultComponentsHeight, }, ...options.checkBoxStyles, }} @@ -815,11 +815,11 @@ export class FluentUIWidgetManager title={options.label} label={options.label} styles={{ - ...defultBindButtonSize, + ...defaultBindButtonSize, label: defaultLabelStyle, root: { minWidth: "unset", - ...defultBindButtonSize, + ...defaultBindButtonSize, }, }} text={options.label} @@ -1058,7 +1058,7 @@ export class FluentUIWidgetManager styles={{ root: { minWidth: "unset", - ...defultBindButtonSize, + ...defaultBindButtonSize, }, }} iconProps={{ @@ -1178,7 +1178,7 @@ export class FluentUIWidgetManager styles={{ root: { minWidth: "unset", - ...defultBindButtonSize, + ...defaultBindButtonSize, }, label: null, }} @@ -1217,7 +1217,7 @@ export class FluentUIWidgetManager styles={{ root: { minWidth: "unset", - ...defultComponentsHeight, + ...defaultComponentsHeight, }, }} iconProps={{ @@ -1576,7 +1576,7 @@ export class FluentUIWidgetManager }, root: { minWidth: "unset", - ...defultBindButtonSize, + ...defaultBindButtonSize, }, }} /> @@ -1699,7 +1699,7 @@ export class FluentUIWidgetManager styles={{ root: { minWidth: "unset", - ...defultComponentsHeight, + ...defaultComponentsHeight, }, }} text={text} @@ -1967,7 +1967,7 @@ export class FluentUIWidgetManager styles={{ root: { minWidth: "unset", - ...defultComponentsHeight, + ...defaultComponentsHeight, }, }} iconProps={{ diff --git a/src/app/views/panels/widgets/fluentui_value_editor.tsx b/src/app/views/panels/widgets/fluentui_value_editor.tsx index 8913cb9d04..7d29941bcc 100644 --- a/src/app/views/panels/widgets/fluentui_value_editor.tsx +++ b/src/app/views/panels/widgets/fluentui_value_editor.tsx @@ -32,8 +32,8 @@ import { strings } from "../../../../strings"; import { defaultLabelStyle, defaultStyle, - defultBindButtonSize, - defultComponentsHeight, + defaultBindButtonSize, + defaultComponentsHeight, FluentTextField, labelRender, } from "./controls/fluentui_customized_components"; @@ -313,7 +313,7 @@ export class FluentValueEditor extends ContextedComponent< ...(defaultStyle as any), title: { ...defaultStyle.title, - lineHeight: defultBindButtonSize.height, + lineHeight: defaultBindButtonSize.height, }, }} label={this.props.label} @@ -347,7 +347,7 @@ export class FluentValueEditor extends ContextedComponent< => { return { title: { - ...defultComponentsHeight, + ...defaultComponentsHeight, borderWidth: options.hideBorder ? "0px" : null, }, dropdownItemsWrapper: { From f952a918ed0a833128fecf33ebb82d221b8566b0 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:05 -0400 Subject: [PATCH 27/79] spelling: delimiter Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/dataset/dsv_parser.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/dataset/dsv_parser.ts b/src/core/dataset/dsv_parser.ts index 0a523c3860..c9cf1ef758 100644 --- a/src/core/dataset/dsv_parser.ts +++ b/src/core/dataset/dsv_parser.ts @@ -48,7 +48,7 @@ export interface LocaleFileFormat { * Calls {@link inferAndConvertColumn} method from {@link "core/dataset/data_types"} for convert types. * @param fileName input file name for parsing * @param content data of file - * @param type type of file. *.csv - text with coma delimeter. *.tsv - tab separated text files + * @param type type of file. *.csv - text with coma delimiter. *.tsv - tab separated text files */ export function parseDataset( fileName: string, From 1cbc1bce40df6ac887dbab88660c130ce385c34a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:06 -0400 Subject: [PATCH 28/79] spelling: description Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a6d04862b6..8f1771de67 100644 --- a/README.md +++ b/README.md @@ -87,7 +87,7 @@ You can add custom sample datasets that can be used with Charticulator. To do s [ { "name": "", - "description": "", + "description": "", "tables": [ { "name": "", From b4176dc9f6ec6c6965fa60ccc949d3dfd409a826 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:06 -0400 Subject: [PATCH 29/79] spelling: design Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/views/dataset/fluent_ui_data_field_selector.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/views/dataset/fluent_ui_data_field_selector.tsx b/src/app/views/dataset/fluent_ui_data_field_selector.tsx index 3af96edf96..033ab4cdcf 100644 --- a/src/app/views/dataset/fluent_ui_data_field_selector.tsx +++ b/src/app/views/dataset/fluent_ui_data_field_selector.tsx @@ -417,7 +417,7 @@ export class DataFieldSelector extends React.Component< ); } - //Update desing + //Update design public render() { const fields = this.getFields(); From b267542921c44f553235eace77d59161e9b35007 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:07 -0400 Subject: [PATCH 30/79] spelling: different Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/plot_segments/line.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/plot_segments/line.ts b/src/core/prototypes/plot_segments/line.ts index 5206e1d872..70c7c2ec0f 100644 --- a/src/core/prototypes/plot_segments/line.ts +++ b/src/core/prototypes/plot_segments/line.ts @@ -28,7 +28,7 @@ import { AxisDataBinding } from "../../specification/types"; /** * Line plot segment distributes the elements on the line * - * (y1 and y2 can have diferent values, so line can have some angle between line and axis lines) + * (y1 and y2 can have different values, so line can have some angle between line and axis lines) * y1 *------#------#------* y2 * x1 x2 * From f510030460bca578fef4840568937098ce6968f6 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:07 -0400 Subject: [PATCH 31/79] spelling: element Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/actions/actions.ts | 2 +- src/core/prototypes/charts/index.ts | 2 +- src/core/prototypes/glyphs/index.ts | 2 +- src/core/prototypes/marks/anchor.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/actions/actions.ts b/src/app/actions/actions.ts index 77388b7f37..ab89122a73 100644 --- a/src/app/actions/actions.ts +++ b/src/app/actions/actions.ts @@ -530,7 +530,7 @@ export class MapDataToChartElementAttribute extends Action { public digest() { return { - name: "MapChartElementkAttribute", + name: "MapChartElementAttribute", chartElement: objectDigest(this.chartElement), attribute: this.attribute, attributeType: this.attributeType, diff --git a/src/core/prototypes/charts/index.ts b/src/core/prototypes/charts/index.ts index ae4c192759..21c148a231 100644 --- a/src/core/prototypes/charts/index.ts +++ b/src/core/prototypes/charts/index.ts @@ -139,7 +139,7 @@ export class RectangleChart extends ChartClass { }; public readonly state: RectangleChartState; - // Get a list of elemnt attributes + // Get a list of element attributes public attributeNames: string[] = [ "x1", "y1", diff --git a/src/core/prototypes/glyphs/index.ts b/src/core/prototypes/glyphs/index.ts index 3330db7f45..2f2b784544 100644 --- a/src/core/prototypes/glyphs/index.ts +++ b/src/core/prototypes/glyphs/index.ts @@ -80,7 +80,7 @@ export class RectangleGlyph extends GlyphClass { public readonly state: RectangleGlyphState; - // Get a list of elemnt attributes + // Get a list of element attributes public attributeNames: string[] = [ "x1", "y1", diff --git a/src/core/prototypes/marks/anchor.ts b/src/core/prototypes/marks/anchor.ts index 0c50d11d3f..2909478ac1 100644 --- a/src/core/prototypes/marks/anchor.ts +++ b/src/core/prototypes/marks/anchor.ts @@ -33,7 +33,7 @@ export class AnchorElement extends MarkClass { public readonly state: AnchorElementState; - /** Get a list of elemnt attributes */ + /** Get a list of element attributes */ public attributeNames: string[] = ["x", "y"]; public attributes: { [name: string]: AttributeDescription } = { x: { From 2c73a276748fe78e07fd1384a072e4ae68492646 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:09:55 -0400 Subject: [PATCH 32/79] spelling: ellipse Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/marks/rect.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/prototypes/marks/rect.ts b/src/core/prototypes/marks/rect.ts index 9b34c17c50..3586ea294f 100644 --- a/src/core/prototypes/marks/rect.ts +++ b/src/core/prototypes/marks/rect.ts @@ -36,7 +36,7 @@ export { RectElementAttributes, RectElementProperties }; export enum ShapeType { Rectangle = "rectangle", Triangle = "triangle", - Ellips = "ellipse", + Ellipse = "ellipse", } export class RectElementClass extends EmphasizableMarkClass< @@ -236,7 +236,7 @@ export class RectElementClass extends EmphasizableMarkClass< options: [ ShapeType.Rectangle, ShapeType.Triangle, - ShapeType.Ellips, + ShapeType.Ellipse, ], searchSection: strings.objects.general, } @@ -486,7 +486,7 @@ export class RectElementClass extends EmphasizableMarkClass< } const helper = new Graphics.CoordinateSystemHelper(cs); switch (this.object.properties.shape) { - case ShapeType.Ellips: { + case ShapeType.Ellipse: { return helper.ellipse( attrs.x1 + offset.x, attrs.y1 + offset.y, From e62aa11b89c530edec5c93e435ee0e6d103d3f81 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:08 -0400 Subject: [PATCH 33/79] spelling: emphasized Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/marks/image.ts | 6 +++--- src/core/prototypes/marks/nested_chart.ts | 2 +- src/core/prototypes/marks/rect.ts | 12 ++++++------ src/core/prototypes/marks/text.ts | 6 +++--- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/core/prototypes/marks/image.ts b/src/core/prototypes/marks/image.ts index 35b9eeef19..1c8ddd760f 100644 --- a/src/core/prototypes/marks/image.ts +++ b/src/core/prototypes/marks/image.ts @@ -329,7 +329,7 @@ export class ImageElementClass extends EmphasizableMarkClass< glyphIndex: number, // eslint-disable-next-line manager: ChartStateManager, - empasized?: boolean + emphasized?: boolean ): Graphics.Element { const attrs = this.state.attributes; const props = this.object.properties; @@ -438,8 +438,8 @@ export class ImageElementClass extends EmphasizableMarkClass< height: imageHeight, mode: "stretch", style: { - ...this.generateEmphasisStyle(empasized), - colorFilter: empasized + ...this.generateEmphasisStyle(emphasized), + colorFilter: emphasized ? `alpha(opacity=${DEFAULT_POWER_BI_OPACITY * 100})` : null, }, diff --git a/src/core/prototypes/marks/nested_chart.ts b/src/core/prototypes/marks/nested_chart.ts index 6aa45dedb6..085acb41c9 100644 --- a/src/core/prototypes/marks/nested_chart.ts +++ b/src/core/prototypes/marks/nested_chart.ts @@ -265,7 +265,7 @@ export class NestedChartElementClass extends EmphasizableMarkClass< // eslint-disable-next-line manager: ChartStateManager, // eslint-disable-next-line - empasized?: boolean + emphasized?: boolean ): Graphics.Element { const attrs = this.state.attributes; if (!attrs.visible || !this.object.properties.visible) { diff --git a/src/core/prototypes/marks/rect.ts b/src/core/prototypes/marks/rect.ts index 3586ea294f..4fc65216a7 100644 --- a/src/core/prototypes/marks/rect.ts +++ b/src/core/prototypes/marks/rect.ts @@ -477,7 +477,7 @@ export class RectElementClass extends EmphasizableMarkClass< glyphIndex = 0, // eslint-disable-next-line manager: ChartStateManager, - empasized?: boolean + emphasized?: boolean ): Graphics.Element { const attrs = this.state.attributes; const properties = this.object.properties; @@ -501,12 +501,12 @@ export class RectElementClass extends EmphasizableMarkClass< ), fillColor: attrs.fill, opacity: attrs.opacity, - ...this.generateEmphasisStyle(empasized), + ...this.generateEmphasisStyle(emphasized), } ); } case ShapeType.Triangle: { - const path = this.drawTriangleOrCometMarks(helper, offset, empasized); + const path = this.drawTriangleOrCometMarks(helper, offset, emphasized); return path; } case ShapeType.Rectangle: @@ -525,7 +525,7 @@ export class RectElementClass extends EmphasizableMarkClass< ), fillColor: attrs.fill, opacity: attrs.opacity, - ...this.generateEmphasisStyle(empasized), + ...this.generateEmphasisStyle(emphasized), }, properties.rx, properties.ry @@ -833,7 +833,7 @@ export class RectElementClass extends EmphasizableMarkClass< private drawTriangleOrCometMarks( helper: Graphics.CoordinateSystemHelper, offset: Point, - empasized?: boolean + emphasized?: boolean ) { const pathMaker = new Graphics.PathMaker(); const properties = this.object.properties; @@ -919,7 +919,7 @@ export class RectElementClass extends EmphasizableMarkClass< strokeDasharray: strokeStyleToDashArray(properties.strokeStyle), fillColor: attrs.fill, opacity: attrs.opacity, - ...this.generateEmphasisStyle(empasized), + ...this.generateEmphasisStyle(emphasized), }; return path; } diff --git a/src/core/prototypes/marks/text.ts b/src/core/prototypes/marks/text.ts index f3b4a60082..6c059b4976 100644 --- a/src/core/prototypes/marks/text.ts +++ b/src/core/prototypes/marks/text.ts @@ -114,7 +114,7 @@ export class TextElementClass extends EmphasizableMarkClass< glyphIndex = 0, // eslint-disable-next-line manager: ChartStateManager, - empasized?: boolean + emphasized?: boolean ): Graphics.Element { const attrs = this.state.attributes; const props = this.object.properties; @@ -160,7 +160,7 @@ export class TextElementClass extends EmphasizableMarkClass< backgroundColor: attrs.backgroundColor, backgroundColorId: attrs.backgroundColorFilterId, opacity: attrs.opacity, - ...this.generateEmphasisStyle(empasized), + ...this.generateEmphasisStyle(emphasized), } ) ); @@ -179,7 +179,7 @@ export class TextElementClass extends EmphasizableMarkClass< backgroundColor: attrs.backgroundColor, backgroundColorId: attrs.backgroundColorFilterId, opacity: attrs.opacity, - ...this.generateEmphasisStyle(empasized), + ...this.generateEmphasisStyle(emphasized), } ); } From db2fe3c7da11c974fcea2728e901b10cae60a2a8 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:09 -0400 Subject: [PATCH 34/79] spelling: enforces Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/solver/abstract.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/solver/abstract.ts b/src/core/solver/abstract.ts index 899f4fda90..da57ccbde1 100644 --- a/src/core/solver/abstract.ts +++ b/src/core/solver/abstract.ts @@ -81,7 +81,7 @@ export abstract class ConstraintSolver { return s; } - /** Add a constraint that enfoces a = b */ + /** Add a constraint that enforces a = b */ public addEquals(strength: ConstraintStrength, a: Variable, b: Variable) { this.addLinear(strength, 0, [ [1, a], @@ -89,7 +89,7 @@ export abstract class ConstraintSolver { ]); } - /** Add a constraint that enfoces a = value */ + /** Add a constraint that enforces a = value */ public addEqualToConstant( strength: ConstraintStrength, a: Variable, From 6240eec5f0481a49415083663e5084916e03fcf4 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:09 -0400 Subject: [PATCH 35/79] spelling: example Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/marks/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/marks/index.ts b/src/core/prototypes/marks/index.ts index e5afa0f865..76436a5e44 100644 --- a/src/core/prototypes/marks/index.ts +++ b/src/core/prototypes/marks/index.ts @@ -42,7 +42,7 @@ * * * All marks implement several methods of {@link ObjectClass} - * for exmaple + * for example * `{@link ObjectClass.getAttributePanelWidgets}` - the method responsible for displaying widgets in the property panel. Each time when a user selects the mark in the object browser, the charticulator calls this method to display properties. Charticulator displays the properties for rectangle named `Shape1` * * ![Mark widgets](media://mark_widgets.png) From 1786980891fc07e7d19d5d2b5201fd602a4aabf2 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:10 -0400 Subject: [PATCH 36/79] spelling: expressions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/expression/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/expression/index.ts b/src/core/expression/index.ts index f68116b798..564cf44fb2 100644 --- a/src/core/expression/index.ts +++ b/src/core/expression/index.ts @@ -1,7 +1,7 @@ /** * Expressions * - * The module of exressions responsible for data binding or data fetching + * The module of expressions responsible for data binding or data fetching * Grammar of expression described in [parser.pegjs file](\src\core\expression\index.ts) * * @packageDocumentation From 23ec3a0a27f65856b02b40058e196451243f5deb Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:10 -0400 Subject: [PATCH 37/79] spelling: fields Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/views/dataset/data_field_binding_builder.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/views/dataset/data_field_binding_builder.tsx b/src/app/views/dataset/data_field_binding_builder.tsx index 7e6e6d859a..5e83ccd789 100644 --- a/src/app/views/dataset/data_field_binding_builder.tsx +++ b/src/app/views/dataset/data_field_binding_builder.tsx @@ -149,7 +149,7 @@ class MenuItemsCreator { } } - public setFieds( + public setFields( datasetStore: AppStore, table?: string, kinds?: Dataset.DataKind[], @@ -736,7 +736,7 @@ export class MenuItemBuilder implements Builder { kinds?: Dataset.DataKind[], types?: Dataset.DataType[] ): void { - this.menuItemsCreator.setFieds(datasetStore, table, kinds, types); + this.menuItemsCreator.setFields(datasetStore, table, kinds, types); } public produceDefaultValue(defaultValue: IDefaultValue): void { From 57f2a3f0460837c3369c9343212d7c55f05c3256 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:11 -0400 Subject: [PATCH 38/79] spelling: format Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/renderer/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/renderer/index.tsx b/src/app/renderer/index.tsx index 3118428005..7adc8e294e 100644 --- a/src/app/renderer/index.tsx +++ b/src/app/renderer/index.tsx @@ -71,7 +71,7 @@ export function applyColorFilter(color: Color, colorFilter: ColorFilter) { } /** - * Coverts {@Color} to `rgb(r,g,b)` string. Or coverts `#RRGGBB` fromat to `rgb(r,g,b)`} + * Coverts {@Color} to `rgb(r,g,b)` string. Or coverts `#RRGGBB` format to `rgb(r,g,b)`} * @param color {@Color} object or color string in HEX format (`#RRGGBB`) */ export function renderColor( From 8878089ead542ca3f3b62aeff9aeee18d0e66d29 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:11 -0400 Subject: [PATCH 39/79] spelling: glyph Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/state.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/prototypes/state.ts b/src/core/prototypes/state.ts index 84fd3f4a2b..9caeca3088 100644 --- a/src/core/prototypes/state.ts +++ b/src/core/prototypes/state.ts @@ -1175,7 +1175,7 @@ export class ChartStateManager { } /** Get glyph-level data context for the glyphIndex-th glyph */ - public getGlpyhDataContext( + public getGlyphDataContext( plotSegment: Specification.PlotSegment, glyphIndex: number ): Expression.Context { @@ -1188,7 +1188,7 @@ export class ChartStateManager { } /** Get all glyph-level data contexts for a given plot segment */ - public getGlpyhDataContexts( + public getGlyphDataContexts( plotSegment: Specification.PlotSegment, // eslint-disable-next-line glyphIndex: number From 1fb5a0792e87075832d35c2598e4d43921d0b869 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:10:47 -0400 Subject: [PATCH 40/79] spelling: gridline Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/plot_segments/axis.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/core/prototypes/plot_segments/axis.ts b/src/core/prototypes/plot_segments/axis.ts index b744c14be4..13e367a48e 100644 --- a/src/core/prototypes/plot_segments/axis.ts +++ b/src/core/prototypes/plot_segments/axis.ts @@ -1046,7 +1046,7 @@ export class AxisRenderer { return; } const g = makeGroup([]); - const gridineArcRotate = 90; + const gridlineArcRotate = 90; const lineStyle: Style = { strokeLinecap: "round", strokeColor: style.gridlineColor, @@ -1055,10 +1055,10 @@ export class AxisRenderer { }; for (const tickPosition of this.ticks.map((x) => x.position)) { const cos = Math.cos( - Geometry.degreesToRadians(-tickPosition + gridineArcRotate) + Geometry.degreesToRadians(-tickPosition + gridlineArcRotate) ); const sin = Math.sin( - Geometry.degreesToRadians(-tickPosition + gridineArcRotate) + Geometry.degreesToRadians(-tickPosition + gridlineArcRotate) ); const tx1 = x + cos * innerRadius; const ty1 = y + sin * innerRadius; @@ -1085,7 +1085,7 @@ export class AxisRenderer { const g = makeGroup([]); const startCos = Math.cos(Geometry.degreesToRadians(startAngle)); const startSin = Math.sin(Geometry.degreesToRadians(startAngle)); - const gridineArcRotate = 90; + const gridlineArcRotate = 90; const lineStyle: Style = { strokeLinecap: "round", strokeColor: style.gridlineColor, @@ -1101,9 +1101,9 @@ export class AxisRenderer { arc.polarLineTo( x, y, - -startAngle + gridineArcRotate, + -startAngle + gridlineArcRotate, tickPosition, - -endAngle + gridineArcRotate, + -endAngle + gridlineArcRotate, tickPosition, true ); From dcec8bc9b4b77c60bf6774de1eb831f8cfb84a73 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:59:30 -0400 Subject: [PATCH 41/79] spelling: group Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/container/chart_template.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/container/chart_template.ts b/src/container/chart_template.ts index cb6dfe8c41..7d17e4499d 100644 --- a/src/container/chart_template.ts +++ b/src/container/chart_template.ts @@ -172,7 +172,7 @@ export class ChartTemplate { const plotSegment = item.chartElement as Specification.PlotSegment; const originalTable = plotSegment.table; plotSegment.table = this.tableAssignment[originalTable]; - // Also fix filter and gropyBy expressions + // Also fix filter and groupyBy expressions if (plotSegment.filter) { if (plotSegment.filter.categories) { plotSegment.filter.categories.expression = this.transformExpression( From 3d8f93dab4fd0b1b72358d83c92690ed68ce3eb5 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:12 -0400 Subject: [PATCH 42/79] spelling: grouping Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/views/file_view/options_view.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/views/file_view/options_view.tsx b/src/app/views/file_view/options_view.tsx index 377f4bcd2e..9fb00f3e72 100644 --- a/src/app/views/file_view/options_view.tsx +++ b/src/app/views/file_view/options_view.tsx @@ -109,7 +109,7 @@ export const FileViewOptionsView: React.FC = () => { - {/* Uncomment to enable configuration for locale: currency symbol and groupping digits */} + {/* Uncomment to enable configuration for locale: currency symbol and grouping digits */} {/*
Date: Sun, 2 Oct 2022 14:11:21 -0400 Subject: [PATCH 43/79] spelling: hashes Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/common/unique_id.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/common/unique_id.ts b/src/core/common/unique_id.ts index 28f669522e..c7c857691b 100644 --- a/src/core/common/unique_id.ts +++ b/src/core/common/unique_id.ts @@ -39,14 +39,14 @@ export function uniqueID(): string { } let hashIndex = 1; -const objectHashs = new WeakMap, string>(); +const objectHashes = new WeakMap, string>(); export function objectHash(o: Record): string { - if (objectHashs.has(o)) { - return objectHashs.get(o); + if (objectHashes.has(o)) { + return objectHashes.get(o); } const newHash = `<#${hashIndex.toString()}>`; hashIndex += 1; - objectHashs.set(o, newHash); + objectHashes.set(o, newHash); return newHash; } From 1dbacef0701e369e3d6058d551bf3166290204e5 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:12 -0400 Subject: [PATCH 44/79] spelling: initialize Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/state.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/state.ts b/src/core/prototypes/state.ts index 9caeca3088..9611c7de1a 100644 --- a/src/core/prototypes/state.ts +++ b/src/core/prototypes/state.ts @@ -391,7 +391,7 @@ export class ChartStateManager { // Build the state hierarchy const elementStates = chart.elements.map((element) => { - // Initialie the element state + // Initialize the element state const elementState: Specification.ChartElementState = { attributes: {}, }; From 94c73629a9cc10a40c0d510814482ed8807d346e Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:12 -0400 Subject: [PATCH 45/79] spelling: iterator Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/object.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/object.ts b/src/core/prototypes/object.ts index 7de39ab5ab..013f2c52d8 100644 --- a/src/core/prototypes/object.ts +++ b/src/core/prototypes/object.ts @@ -237,7 +237,7 @@ export class ObjectClasses { } /** - * Gets an interator of registered classes. + * Gets an iterator of registered classes. */ public static RegisteredClasses(): IterableIterator { return this.registeredObjectClasses.values(); From 6690c13e22dd57d56d5c7cbca6eca4848f824b17 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:13 -0400 Subject: [PATCH 46/79] spelling: label Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/controls.ts | 2 +- src/core/prototypes/plot_segments/axis.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/core/prototypes/controls.ts b/src/core/prototypes/controls.ts index 1898001009..03b264ac3e 100644 --- a/src/core/prototypes/controls.ts +++ b/src/core/prototypes/controls.ts @@ -118,7 +118,7 @@ export interface MappingEditorOptions extends SearchSection { openMapping?: boolean; /** Enables value selector from mapping */ allowSelectValue?: boolean; - /** Text lael of input */ + /** Text label of input */ label?: string; stopPropagation?: boolean; diff --git a/src/core/prototypes/plot_segments/axis.ts b/src/core/prototypes/plot_segments/axis.ts index 13e367a48e..4549eb7962 100644 --- a/src/core/prototypes/plot_segments/axis.ts +++ b/src/core/prototypes/plot_segments/axis.ts @@ -1147,18 +1147,18 @@ export class AxisRenderer { const tx = Math.sin(radians) * radius; const ty = Math.cos(radians) * radius; - const lablel = + const label = tick.label && replaceSymbolByTab(replaceSymbolByNewLine(tick.label)); if ( - lablel && + label && (style.wordWrap || (typeof tick.label === "string" && - splitStringByNewLine(lablel).length > 1)) + splitStringByNewLine(label).length > 1)) ) { - let textContent = [lablel]; + let textContent = [label]; if (style.wordWrap) { textContent = splitByWidth( - lablel, + label, maxTickDistance, 10000, style.fontFamily, From 482a31294e997c4d5edca9100146b751dadfd2bd Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 15:00:43 -0400 Subject: [PATCH 47/79] spelling: lagrange Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.ts b/src/index.ts index 0b130cde76..b06dbb7106 100644 --- a/src/index.ts +++ b/src/index.ts @@ -57,7 +57,7 @@ * A linear least square solver using the Conjugate Gradient method. * * * Solve sparse linear least square problems. - * * Solve sparse constrained linear least square problems using a lagrange method. + * * Solve sparse constrained linear least square problems using a Lagrange method. * * Decompose dense matrices with full pivot LU to obtain solution and kernel (null space). * * Uses the Eigen library for sparse matrix computation and the conjugate gradient method. * * Compiled into WebAssembly for performance. From e6d845027023cda7b84c7a04e1d9cf445ecfd011 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:14 -0400 Subject: [PATCH 48/79] spelling: length Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/plot_segments/axis.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/plot_segments/axis.ts b/src/core/prototypes/plot_segments/axis.ts index 4549eb7962..5fcf6fd7a1 100644 --- a/src/core/prototypes/plot_segments/axis.ts +++ b/src/core/prototypes/plot_segments/axis.ts @@ -1140,7 +1140,7 @@ export class AxisRenderer { Geometry.degreesToRadians( radius * ((rangeMax - rangeMin) / this.ticks.length) ) - - margins * 2; // lenght of arc for all ticks + margins * 2; // length of arc for all ticks for (const tick of this.ticks) { const angle = tick.position; const radians = Geometry.degreesToRadians(angle); From 6c305d99d92db1989fc70180f04e34e6c0f0ca16 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:14 -0400 Subject: [PATCH 49/79] spelling: loading Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/application.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/application.tsx b/src/app/application.tsx index 965d9fae89..68db0dff9c 100644 --- a/src/app/application.tsx +++ b/src/app/application.tsx @@ -211,7 +211,7 @@ export class Application { thousands: localizaiton?.thousandsDelimiter ?? defaultNumberFormat.decimal, }); - console.warn("Loadin localization settings failed"); + console.warn("Loading localization settings failed"); } (window as any).mainStore = this.appStore; From 7fb41242e7e3d01f232b0c6d3ef5e220b4f6ae81 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:15 -0400 Subject: [PATCH 50/79] spelling: localization Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/application.tsx | 8 ++++---- src/container/container.tsx | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/app/application.tsx b/src/app/application.tsx index 68db0dff9c..2c9040f357 100644 --- a/src/app/application.tsx +++ b/src/app/application.tsx @@ -125,7 +125,7 @@ export class Application { workerScriptContent?: string; worker?: CharticulatorWorkerInterface; }, - localizaiton: LocalizationConfig, + localization: LocalizationConfig, handlers?: { menuBarHandlers?: MenuBarHandlers; telemetry?: TelemetryRecorder; @@ -205,11 +205,11 @@ export class Application { }); } catch (ex) { setFormatOptions({ - currency: [localizaiton?.currency, ""] ?? defaultCurrency, + currency: [localization?.currency, ""] ?? defaultCurrency, grouping: defaultDigitsGroup, - decimal: localizaiton?.decimalDelimiter ?? defaultNumberFormat.decimal, + decimal: localization?.decimalDelimiter ?? defaultNumberFormat.decimal, thousands: - localizaiton?.thousandsDelimiter ?? defaultNumberFormat.decimal, + localization?.thousandsDelimiter ?? defaultNumberFormat.decimal, }); console.warn("Loading localization settings failed"); } diff --git a/src/container/container.tsx b/src/container/container.tsx index 8822f686d1..8ab94f36e6 100644 --- a/src/container/container.tsx +++ b/src/container/container.tsx @@ -214,18 +214,18 @@ export class ChartContainer extends EventEmitter { public readonly instance: TemplateInstance, public readonly dataset: Dataset.Dataset, public renderEvents?: RenderEvents, - public localizaiton?: LocalizationConfig + public localization?: LocalizationConfig ) { super(); this.chart = instance.chart; this.defaultAttributes = instance.defaultAttributes; setFormatOptions({ - currency: [localizaiton?.currency, ""] ?? defaultCurrency, + currency: [localization?.currency, ""] ?? defaultCurrency, grouping: defaultDigitsGroup, - decimal: localizaiton?.decimalDelimiter ?? defaultNumberFormat.decimal, + decimal: localization?.decimalDelimiter ?? defaultNumberFormat.decimal, thousands: - localizaiton?.thousandsDelimiter ?? defaultNumberFormat.decimal, + localization?.thousandsDelimiter ?? defaultNumberFormat.decimal, }); } From 32a14f48e57ec70bb372eda8ec3c6b8a956c714c Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:15 -0400 Subject: [PATCH 51/79] spelling: manager Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/solver/plugins/polar_coordinator.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/core/solver/plugins/polar_coordinator.ts b/src/core/solver/plugins/polar_coordinator.ts index 4105ecde1f..021e33cd6c 100644 --- a/src/core/solver/plugins/polar_coordinator.ts +++ b/src/core/solver/plugins/polar_coordinator.ts @@ -23,7 +23,7 @@ export class PolarCoordinatorPlugin extends ConstraintPlugin { angleVarable: Variable[]; chartConstraints: Specification.Constraint[]; coordinatorObjectID: string; - chartMananger: ChartStateManager; + chartManager: ChartStateManager; constructor( solver: ConstraintSolver, @@ -34,7 +34,7 @@ export class PolarCoordinatorPlugin extends ConstraintPlugin { attrs: PolarGuideCoordinatorAttributesExtend, chartConstraints: Specification.Constraint[], coordinatorObjectID: string, - chartMananger: ChartStateManager + chartManager: ChartStateManager ) { super(); this.solver = solver; @@ -45,7 +45,7 @@ export class PolarCoordinatorPlugin extends ConstraintPlugin { this.attrs = attrs; this.chartConstraints = chartConstraints; this.coordinatorObjectID = coordinatorObjectID; - this.chartMananger = chartMananger; + this.chartManager = chartManager; } public apply() { @@ -94,14 +94,14 @@ export class PolarCoordinatorPlugin extends ConstraintPlugin { // take snapped attributes and apply new value snapToAttribute( - this.chartMananger, + this.chartManager, this.chartConstraints, this.coordinatorObjectID, attrXname, cx + tx ); snapToAttribute( - this.chartMananger, + this.chartManager, this.chartConstraints, this.coordinatorObjectID, attrYname, From a448c0c7c752e1b3edbee2c62cab2d595d194556 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:12:36 -0400 Subject: [PATCH 52/79] spelling: map Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/views/panels/widgets/fluent_mapping_editor.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/app/views/panels/widgets/fluent_mapping_editor.tsx b/src/app/views/panels/widgets/fluent_mapping_editor.tsx index 0e2a449277..4be026aaab 100644 --- a/src/app/views/panels/widgets/fluent_mapping_editor.tsx +++ b/src/app/views/panels/widgets/fluent_mapping_editor.tsx @@ -887,7 +887,7 @@ export class FluentMappingEditor extends React.Component< } } -export interface DataMappAndScaleEditorProps { +export interface DataMapAndScaleEditorProps { attribute: string; defaultMapping: Specification.Mapping; options: Prototypes.Controls.MappingEditorOptions; @@ -896,13 +896,13 @@ export interface DataMappAndScaleEditorProps { alignLeft?: boolean; plotSegment: ObjectClass; } -export interface DataMappAndScaleEditorState { +export interface DataMapAndScaleEditorState { currentMapping: Specification.Mapping; } -export class DataMappAndScaleEditor extends ContextedComponent< - DataMappAndScaleEditorProps, - DataMappAndScaleEditorState +export class DataMapAndScaleEditor extends ContextedComponent< + DataMapAndScaleEditorProps, + DataMapAndScaleEditorState > { public state = { currentMapping: this.props.defaultMapping, From f3dfed26dff8987e63b98f884bc0177680845868 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:16 -0400 Subject: [PATCH 53/79] spelling: message Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/components/index.ts | 2 +- src/app/components/{messsage_box.tsx => message_box.tsx} | 0 src/app/utils/index.ts | 6 +++--- 3 files changed, 4 insertions(+), 4 deletions(-) rename src/app/components/{messsage_box.tsx => message_box.tsx} (100%) diff --git a/src/app/components/index.ts b/src/app/components/index.ts index 18d84cf89b..fbd4dc5999 100644 --- a/src/app/components/index.ts +++ b/src/app/components/index.ts @@ -18,4 +18,4 @@ export * from "./gradient_picker"; export * from "./minimizable_panel"; export * from "./error_boundary"; export * from "./editable_text_view"; -export * from "./messsage_box"; +export * from "./message_box"; diff --git a/src/app/components/messsage_box.tsx b/src/app/components/message_box.tsx similarity index 100% rename from src/app/components/messsage_box.tsx rename to src/app/components/message_box.tsx diff --git a/src/app/utils/index.ts b/src/app/utils/index.ts index f4e2548bdf..47795ce9cb 100644 --- a/src/app/utils/index.ts +++ b/src/app/utils/index.ts @@ -356,11 +356,11 @@ export function convertColumns( applyConvertedValues(table, column.name, convertedValues); return null; } catch (ex) { - const messgae = `Converting column type from ${originColumn.type} to ${type} failed`; - console.warn(messgae); + const message = `Converting column type from ${originColumn.type} to ${type} failed`; + console.warn(message); // rollback type column.type = typeBeforeChange; - return messgae; + return message; } } From f9b86ed1e8b7e1b1b65430821a652b84fccb7d73 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:17 -0400 Subject: [PATCH 54/79] spelling: object Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/container/chart_template.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/container/chart_template.ts b/src/container/chart_template.ts index 7d17e4499d..014b3a6cda 100644 --- a/src/container/chart_template.ts +++ b/src/container/chart_template.ts @@ -124,7 +124,7 @@ export class ChartTemplate { } /** - * Creates instance of chart object from template. Chart objecty can be loaded into container to display it in canvas + * Creates instance of chart object from template. Chart object can be loaded into container to display it in canvas * On editing this method ensure that you made correspond changes in template builder ({@link ChartTemplateBuilder}). * Any exposed into template objects should be initialized here */ From 0f26eda7e2089d943a215dada3e53f0df58020b1 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:17 -0400 Subject: [PATCH 55/79] spelling: objects Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/stores/app_store.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/stores/app_store.ts b/src/app/stores/app_store.ts index a689349f61..b68c4152e3 100644 --- a/src/app/stores/app_store.ts +++ b/src/app/stores/app_store.ts @@ -347,7 +347,7 @@ export class AppStore extends BaseStore { this.chartManager?.resetDifference(); } - // removes unused scale objecs + // removes unused scale objects private updateChartState() { function hasMappedProperty( mappings: Specification.Mappings, From 13ccf8a832ca32e71e1b62ea33469b20d25f2a27 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:13:03 -0400 Subject: [PATCH 56/79] spelling: parsed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/views/panels/widgets/fluent_mapping_editor.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/app/views/panels/widgets/fluent_mapping_editor.tsx b/src/app/views/panels/widgets/fluent_mapping_editor.tsx index 4be026aaab..40ca479ec4 100644 --- a/src/app/views/panels/widgets/fluent_mapping_editor.tsx +++ b/src/app/views/panels/widgets/fluent_mapping_editor.tsx @@ -121,12 +121,12 @@ export class FluentMappingEditor extends React.Component< scaleMapping={mapping as any} store={this.props.store} onSelect={(index) => { - const paresedExpression = Expression.parse( + const parsedExpression = Expression.parse( scaleMapping.expression ) as FunctionCall; // change the second param of get function - (paresedExpression.args[1] as any).value = index; - scaleMapping.expression = paresedExpression.toString(); + (parsedExpression.args[1] as any).value = index; + scaleMapping.expression = parsedExpression.toString(); this.props.parent.onEditMappingHandler( this.props.attribute, scaleMapping From 273a59b70d9e7f590298de744fdade7edba5868a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:19 -0400 Subject: [PATCH 57/79] spelling: priority Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/views/canvas/snapping/session.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/views/canvas/snapping/session.ts b/src/app/views/canvas/snapping/session.ts index 7e8d772a8f..27e158537c 100644 --- a/src/app/views/canvas/snapping/session.ts +++ b/src/app/views/canvas/snapping/session.ts @@ -57,7 +57,7 @@ export class SnappingSession { } } - private giveProrityToPoint( + private givePriorityToPoint( a: SnappableGuide, b: SnappableGuide ) { @@ -88,7 +88,7 @@ export class SnappingSession { let minXDistance: number = null; let minYGuide: SnappableGuide = null; let minYDistance: number = null; - for (const g of this.candidates.sort(this.giveProrityToPoint)) { + for (const g of this.candidates.sort(this.givePriorityToPoint)) { const guide = g.guide as Prototypes.SnappingGuides.Axis; if (this.findClosestSnappingGuide) { if (guide.type == "y") { @@ -142,7 +142,7 @@ export class SnappingSession { let minXDistance: number = null; let minYGuide: SnappableGuide = null; let minYDistance: number = null; - for (const g of this.candidates.sort(this.giveProrityToPoint)) { + for (const g of this.candidates.sort(this.givePriorityToPoint)) { const guide = g.guide as Prototypes.SnappingGuides.Axis; if (this.findClosestSnappingGuide) { // Find closest point @@ -280,7 +280,7 @@ export class SnappingSession { } if (source == "x" || source == "y") { for (const candidate of this.currentCandidates.sort( - this.giveProrityToPoint + this.givePriorityToPoint )) { if ( (candidate.guide as Prototypes.SnappingGuides.PolarAxis) From 7d1223a89115b78d52c41204ff86ed38c2d4c119 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:18 -0400 Subject: [PATCH 58/79] spelling: properties Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/common/utils.ts | 2 +- src/core/prototypes/plot_segments/axis.ts | 4 ++-- src/core/prototypes/plot_segments/virtualScroll.tsx | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/core/common/utils.ts b/src/core/common/utils.ts index 8450824dfa..1fe2c55ff4 100644 --- a/src/core/common/utils.ts +++ b/src/core/common/utils.ts @@ -624,7 +624,7 @@ export function compareMarkAttributeNames(a: string, b: string) { if (a === b) { return true; } else { - // fill and stroke uses with color. Those preoperties has the same meaning for marks + // fill and stroke uses with color. Those properties has the same meaning for marks if (colorAttributes.indexOf(b) > -1 && colorAttributes.indexOf(a) > -1) { return true; } diff --git a/src/core/prototypes/plot_segments/axis.ts b/src/core/prototypes/plot_segments/axis.ts index 5fcf6fd7a1..58aacde7f2 100644 --- a/src/core/prototypes/plot_segments/axis.ts +++ b/src/core/prototypes/plot_segments/axis.ts @@ -47,7 +47,7 @@ import { AxisDataBindingType, NumericalMode, } from "../../specification/types"; -import { VirtualScrollBar, VirtualScrollBarPropertes } from "./virtualScroll"; +import { VirtualScrollBar, VirtualScrollBarProperties } from "./virtualScroll"; import { CategoryItemsWithIds, getOnConfirmFunction, @@ -1353,7 +1353,7 @@ export class AxisRenderer { height = AxisRenderer.SCROLL_BAR_SIZE; } - return React.createElement(VirtualScrollBar, { + return React.createElement(VirtualScrollBar, { onScroll, handlerBarWidth: AxisRenderer.SCROLL_BAR_SIZE, height, diff --git a/src/core/prototypes/plot_segments/virtualScroll.tsx b/src/core/prototypes/plot_segments/virtualScroll.tsx index 5a2e0200eb..792d42cb3c 100644 --- a/src/core/prototypes/plot_segments/virtualScroll.tsx +++ b/src/core/prototypes/plot_segments/virtualScroll.tsx @@ -7,7 +7,7 @@ import { useEffect } from "react"; import { ZoomInfo } from "../.."; import { AxisDataBindingType } from "../../specification/types"; -export interface VirtualScrollBarPropertes { +export interface VirtualScrollBarProperties { initialPosition: number; onScroll: (position: number) => void; x: number; @@ -22,7 +22,7 @@ export interface VirtualScrollBarPropertes { dataType: AxisDataBindingType; } -export const VirtualScrollBar: React.FC = ({ +export const VirtualScrollBar: React.FC = ({ handlerBarWidth, // AxisRenderer.SCROLL_BAR_SIZE vertical, height, From bfd3a7be856710da914bc74906c7469bc29a7ebc Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:19 -0400 Subject: [PATCH 59/79] spelling: providers Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/dataset/context.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/dataset/context.ts b/src/core/dataset/context.ts index e324d7f5fb..0b98902a2e 100644 --- a/src/core/dataset/context.ts +++ b/src/core/dataset/context.ts @@ -2,7 +2,7 @@ // Licensed under the MIT license. /** - * Context provideres for expressions ({@link "core/expression/index"}) + * Context providers for expressions ({@link "core/expression/index"}) * * @packageDocumentation * @preferred From d8ed3e7bf74d29158d125c2426f5471422df5394 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 14:13:32 -0400 Subject: [PATCH 60/79] spelling: ratio Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/guides/polar_coordinator.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/guides/polar_coordinator.ts b/src/core/prototypes/guides/polar_coordinator.ts index 6dda70b7cb..e9f9a33f2e 100644 --- a/src/core/prototypes/guides/polar_coordinator.ts +++ b/src/core/prototypes/guides/polar_coordinator.ts @@ -639,7 +639,7 @@ export class GuidePolarCoordinatorClass extends ChartElementClass< ) ) ), - // uncomment to allow configure raito + // uncomment to allow configure ratio // manager.row( // strings.objects.guides.radius, // manager.horizontal( From 2fbc1ef54e152bd602256d623b8be0ae40ca97e5 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:20 -0400 Subject: [PATCH 61/79] spelling: rectangle Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/core/prototypes/marks/rect.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/prototypes/marks/rect.ts b/src/core/prototypes/marks/rect.ts index 4fc65216a7..d5efd28464 100644 --- a/src/core/prototypes/marks/rect.ts +++ b/src/core/prototypes/marks/rect.ts @@ -404,7 +404,7 @@ export class RectElementClass extends EmphasizableMarkClass< this.state.attributes, ["x1", "y1", "x2", "y2", "cx", "cy", "width", "height"] ); - // Describes intrinsic relations of reactangle + // Describes intrinsic relations of rectangle // add constraint x2 - x1 = width solver.addLinear( ConstraintStrength.HARD, From bd7bf51aeea0b0feb828bb5b131a8631d7c66070 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Sun, 2 Oct 2022 13:53:20 -0400 Subject: [PATCH 62/79] spelling: removal Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- src/app/views/file_view/options_view.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/views/file_view/options_view.tsx b/src/app/views/file_view/options_view.tsx index 9fb00f3e72..dbf12ffc4a 100644 --- a/src/app/views/file_view/options_view.tsx +++ b/src/app/views/file_view/options_view.tsx @@ -80,7 +80,7 @@ export const FileViewOptionsView: React.FC = () => {