-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Closed
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-TerminalConnectionIssues pertaining to the terminal<->backend connection interfaceIssues pertaining to the terminal<->backend connection interfaceHelp WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.In-PRThis issue has a related PRThis issue has a related PRIssue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.The new Windows Terminal.good first issueThis is a fix that might be easier for someone to do as a first contributionThis is a fix that might be easier for someone to do as a first contribution
Milestone
Description
Environment
Windows build number: 10.0.19041.388
Windows Terminal version (if applicable): 1.1.2021.0
Steps to reproduce
- Open Windows Terminal
setx WSLENV "${env:WSLENV}:TEST/p"
- Close and reopen Windows Terminal
echo $env:WSLENV
Expected behavior
WT_SESSION:WT_PROFILE_ID:TEST/p
Actual behavior
WT_SESSION:WT_SESSION::WT_PROFILE_ID:TEST/p:WT_PROFILE_ID
I think the right thing to do here is to split WSLENV
by :
and check those vars are already set instead of just simply prepending and appending a string.
Probable related PRs:
vbrozik
Metadata
Metadata
Assignees
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-TerminalConnectionIssues pertaining to the terminal<->backend connection interfaceIssues pertaining to the terminal<->backend connection interfaceHelp WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.In-PRThis issue has a related PRThis issue has a related PRIssue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.The new Windows Terminal.good first issueThis is a fix that might be easier for someone to do as a first contributionThis is a fix that might be easier for someone to do as a first contribution