From a22b23e26aa853392c50c1cb90c81fe9919628b8 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Fri, 18 Nov 2022 17:16:13 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../03-mobilenet-transfer-learning-local.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/samples/research/VisionSample/MachineLearning/scripts/03-mobilenet-transfer-learning-local.py b/samples/research/VisionSample/MachineLearning/scripts/03-mobilenet-transfer-learning-local.py index ac443d8d..d5fed1d1 100644 --- a/samples/research/VisionSample/MachineLearning/scripts/03-mobilenet-transfer-learning-local.py +++ b/samples/research/VisionSample/MachineLearning/scripts/03-mobilenet-transfer-learning-local.py @@ -41,7 +41,26 @@ def ExtractFiles(filename): try: print ('Extracting files...') with tarfile.open(filename) as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar) finally: print ('Extracting files Done.') return None