Skip to content

Conversation

@dileepyavan
Copy link
Member

@dileepyavan dileepyavan commented Nov 25, 2025

Updating prompts for new openAI Model

@dileepyavan dileepyavan marked this pull request as ready for review November 25, 2025 20:25
Copilot AI review requested due to automatic review settings November 25, 2025 20:25
@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Nov 25, 2025
Copilot finished reviewing on behalf of dileepyavan November 25, 2025 20:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GPT-5.1 Codex prompt template according to new recommendations from OpenAI. The changes restructure the prompt to emphasize parallelism in tool usage, add guidance for frontend design tasks, and provide clearer error handling instructions.

Key Changes:

  • Added new sections for file exploration/reading with emphasis on parallel tool execution via multi_tool_use.parallel
  • Added frontend design guidance to avoid generic "AI slop" and encourage intentional, bold design choices
  • Replaced generic tool usage and special request handling with more specific error handling guidance

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

<Tag name='Exploration_and_reading_files'>
- Think first. Before any tool call, decide ALL files/resources you will need.<br />
- Batch everything. If you need multiple files (even from different places), read them together.<br />
- multi_tool_use.parallel Use `multi_tool_use.parallel` to parallelize tool calls and only this.<br />
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete sentence on line 38. The line starts with "multi_tool_use.parallel Use multi_tool_use.parallel..." which appears to have text before "Use" that doesn't form a proper sentence. Should likely be either "- Use multi_tool_use.parallel to parallelize tool calls and only this." or restructured for clarity.

Suggested change
- multi_tool_use.parallel Use `multi_tool_use.parallel` to parallelize tool calls and only this.<br />
- Use `multi_tool_use.parallel` to parallelize tool calls and only this.<br />

Copilot uses AI. Check for mistakes.
- While you are working, you might notice unexpected changes that you didn't make. If this happens, STOP IMMEDIATELY and ask the user how they would like to proceed.<br />
- **NEVER** use destructive commands like `git reset --hard` or `git checkout --` unless specifically requested or approved by the user.<br />
</Tag>
<Tag name='Exploration_and_reading_files'>
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag name 'Exploration_and_reading_files' uses underscores and starts with a capital letter, which is inconsistent with other tag names in this file (e.g., 'editing_constraints', 'tool_use', 'frontend_tasks'). For consistency, consider using 'exploration_and_reading_files' instead.

Suggested change
<Tag name='Exploration_and_reading_files'>
<Tag name='exploration_and_reading_files'>

Copilot uses AI. Check for mistakes.
- Motion: Use a few meaningful animations (page-load, staggered reveals) instead of generic micro-motions.<br />
- Background: Don't rely on flat, single-color backgrounds; use gradients, shapes, or subtle patterns to build atmosphere.<br />
- Overall: Avoid boilerplate layouts and interchangeable UI patterns. Vary themes, type families, and visual languages across outputs.<br />
- Ensure the page loads properly on both desktop and mobile<br />
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing period at the end of the sentence. The line should end with a period for consistency with other bullet points in the prompt that all end with periods.

Suggested change
- Ensure the page loads properly on both desktop and mobile<br />
- Ensure the page loads properly on both desktop and mobile.<br />

Copilot uses AI. Check for mistakes.
Comment on lines 48 to 49
- {tools[ToolName.CoreManageTodoList] && <>
<br />
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional rendering logic changed from wrapping the entire tool_use content to only wrapping the CoreManageTodoList section. This means the opening - {tools[ToolName.CoreManageTodoList] && <> on line 48 creates a bullet point that starts with a conditional JSX expression, which will render as "- " when the condition is false, leaving an empty bullet point. Consider restructuring to avoid rendering anything when the tool is not available, or move the - inside the conditional block.

Suggested change
- {tools[ToolName.CoreManageTodoList] && <>
<br />
{tools[ToolName.CoreManageTodoList] && <>
- <br />

Copilot uses AI. Check for mistakes.
justschen
justschen previously approved these changes Nov 25, 2025
@justschen
Copy link
Contributor

@dileepyavan looks like some tests failed

</>}
</Tag>
<Tag name='special_user_requests'>
- If the user makes a simple request (such as asking for the time) which you can fulfill by running a terminal command (such as `date`), you should do so.<br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete this section?

Tyriar
Tyriar previously approved these changes Nov 25, 2025
benibenj
benibenj previously approved these changes Dec 1, 2025
roblourens
roblourens previously approved these changes Dec 1, 2025
@dileepyavan dileepyavan dismissed stale reviews from roblourens and benibenj via 9b53466 December 1, 2025 23:51
@dileepyavan dileepyavan force-pushed the DileepY/openAI_modelUpdate branch from b9ff73f to 7156b94 Compare December 2, 2025 04:06
@dileepyavan dileepyavan requested a review from benibenj December 2, 2025 06:22
@dileepyavan dileepyavan added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 016f083 Dec 2, 2025
16 checks passed
@dileepyavan dileepyavan deleted the DileepY/openAI_modelUpdate branch December 2, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants