Skip to content

Commit 410ebc0

Browse files
authored
Upgrade Node to 22 and update the dependenies to be compatible with node 22 as node v16 is depricated (#554)
* update node to 18.19.0 * clean up node 16 references * not 18 but 22./dev.sh * revert changes to Dockerfile.dev for node upgrade lints
1 parent a1dfcdf commit 410ebc0

File tree

10 files changed

+104
-305
lines changed

10 files changed

+104
-305
lines changed

.github/workflows/pre-commit.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,20 +29,15 @@ jobs:
2929
steps:
3030
- uses: actions/checkout@v4
3131

32-
- name: Setup Node.js 18
32+
- name: Setup Node.js 22
3333
uses: actions/setup-node@v3
3434
with:
35-
node-version: 18
35+
node-version: 22
3636

3737
- name: Install dependencies for cli
3838
run: yarn add eslint@^8.40.0 eslint-plugin-import@^2.29.0 eslint-plugin-prettier@^5.0.1 eslint-plugin-react@^7.29.4 eslint-plugin-unused-imports@^3.0.0 --dev
3939
working-directory: cli
4040

41-
- name: Setup Node.js 16
42-
uses: actions/setup-node@v3
43-
with:
44-
node-version: 16
45-
4641
- name: Install dependencies for web-server
4742
run: yarn add eslint@^8.40.0 eslint-config-next@13.5.6 eslint-plugin-import@^2.29.0 eslint-plugin-prettier@^5.0.1 eslint-plugin-react@^7.29.4 eslint-plugin-unused-imports@^3.0.0 --dev
4843
working-directory: web-server

CONTRIBUTING.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ Please follow the existing code style and conventions used in the project. If yo
2929
```
3030
pip install -r backend/dev-requirements.txt --upgrade
3131
```
32-
Also install the eslint for both `cli/` and `webserver/`. Please use node 16 for that
32+
Also install the eslint for both `cli/` and `webserver/`. Please use node 22 for that
3333
*NOTE*: If NVM is not installed, install using [nvm](https://github.com/nvm-sh/nvm?tab=readme-ov-file#installing-and-updating)
3434
```
35-
nvm install 16
36-
nvm use 16
35+
nvm install 22
36+
nvm use 22
3737
```
3838
```
3939
cd cli
@@ -60,8 +60,6 @@ Please follow the existing code style and conventions used in the project. If yo
6060
pre-commit run --files [path/to/file]
6161
```
6262
63-
*NOTE*: Make sure the terminal is using node 16 for the linting before committing(Until we upgrade node for webserver)
64-
6563
## Labels
6664
6765
We use the following labels to categorize and prioritize issues:

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ RUN apt-get update && \
6767
redis-server \
6868
supervisor \
6969
curl \
70-
&& curl -fsSL https://deb.nodesource.com/setup_16.x | bash - \
70+
&& curl -fsSL https://deb.nodesource.com/setup_22.x | bash - \
7171
&& apt-get install -y nodejs \
7272
&& mkdir -p /etc/cron.d && mv /app/setup_utils/cronjob.txt /etc/cron.d/cronjob \
7373
&& chmod +x /app/setup_utils/* \

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,11 +358,11 @@ Coming Soon!
358358
To get started contributing to middleware check out our [CONTRIBUTING.md](https://github.com/middlewarehq/middleware/blob/main/CONTRIBUTING.md).
359359
360360
> [!IMPORTANT]
361-
> ✨ We offer **SWAG** for solving issues labelled [`advanced`](https://github.com/middlewarehq/middleware/issues?q=is%3Aissue+is%3Aopen+label%3Aadvanced)! ✨
361+
> ✨ We offer **SWAG** for solving issues labelled [`advanced`](https://github.com/middlewarehq/middleware/issues?q=is%3Aissue+is%3Aopen+label%3Aadvanced)! ✨
362362
> _Please confirm with our team on respective issues before proceeding._
363363
364364
> [!IMPORTANT]
365-
> 👩‍💻 When new hiring positions open, we look at our open source contributors first! 👨‍💻
365+
> 👩‍💻 When new hiring positions open, we look at our open source contributors first! 👨‍💻
366366
> _[Join our Slack](https://mhq.link/oss-community) so we can reach out to you._
367367
368368
We appreciate your contributions and look forward to working together to make Middleware even better!

cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"license": "MIT",
55
"bin": "dist/cli.js",
66
"engines": {
7-
"node": ">=16"
7+
"node": "^22.x"
88
},
99
"type": "module",
1010
"scripts": {

0 commit comments

Comments
 (0)