Skip to content

Commit e89931a

Browse files
committed
fix: check error func
1 parent ddf4f5d commit e89931a

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

web-server/pages/api/internal/ai/dora_metrics.ts

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -126,20 +126,12 @@ endpoint.handle.POST(postSchema, async (req, res) => {
126126
}
127127
});
128128

129-
function checkForErrors(responses: any): { status: string; message: string } {
130-
let status = 'success';
131-
let message = '';
132-
133-
for (const value of Object.values(responses)) {
134-
if (value.status === 'error') {
135-
status = 'error';
136-
message = value.message;
137-
break;
138-
}
139-
}
129+
const checkForErrors = (responses: any): { status: string; message: string } => {
130+
const errorResponse = Object.values(responses).find(value => value.status === 'error');
131+
132+
return errorResponse ? { status: 'error', message: errorResponse.message } : { status: 'success', message: '' };
133+
};
140134

141-
return { status, message };
142-
}
143135

144136
const getDoraMetricsScore = (
145137
dora_data: TeamDoraMetricsApiResponseType,

0 commit comments

Comments
 (0)