Merging into a common repository

[Anorov]

Hey, I've noticed this repository and a few other branches of the original SocksiPy floating around Github for the past few years. Some dead, some with various additions and changes made.

I have my own branch, which I have renamed to "PySocks" (partially to distinguish it from the original and partially because I think it sounds a little better): https://github.com/Anorov/PySocks

I've fixed a few bugs that are present in a lot of the current branches around, and I've also overhauled the coding style to make it much more Pythonic. In the process, I believe there'll be some slight speed upgrades and much clearer exception output. It fully supports both Python 2 and 3. I've also added some fairly rudimentary tests, which I plan to improve later.

This branch is currently in the process of being integrated into the urllib3 library, and shortly thereafter will be accessible to the requests library, so that SOCKS proxies will be an option when starting a requests session.

I think it would be cool if people still interested in working on this library could all work on a central project. What are your thoughts on the matter?

[mikedougherty]

Hi, sorry, I meant to reply to this a while ago but instead the notification email just stayed starred forever ;)

that all sounds great!

this fork was literally only meant to support digsby, but then received a couple pull requests. I have no intention of continuing development except for bugfixes affecting digsby (and after 6 years I doubt we'll run into any unexpected behavior).

The functionality this module provides is necessary (imo) for any network enabled app and it would be great to have a single source for SOCKS support. In the future I'll direct any/all issues & requests to PySocks.

I'll have a look over PySocks at some point as well and see if there's anything I can offer.

cheers!

[Anorov]

Cool, sounds good. I've been trying to remain as active as possible with my fork, so I'll gladly investigate any issues or suggestions for improvement that your developers or users may have.