Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

Commit a9a1ab6

Browse files
authored
UserWithId Strategy calls id() method on User Model (#32)
1 parent d370d33 commit a9a1ab6

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
"require": {
66
"guzzlehttp/guzzle": "^6.3|^7.0",
77
"illuminate/support": "^5.8|^6|^7|^8",
8-
"illuminate/http": "^5.8|^6|^7|^8"
8+
"illuminate/http": "^5.8|^6|^7|^8",
9+
"illuminate/contracts": "^5.8|^6|^7|^8"
910
},
1011
"require-dev": {
1112
"phpunit/phpunit": "^8.3",

config/unleash.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,6 @@
4545
'applicationHostname' => \MikeFrancis\LaravelUnleash\Strategies\ApplicationHostnameStrategy::class,
4646
'default' => \MikeFrancis\LaravelUnleash\Strategies\DefaultStrategy::class,
4747
'remoteAddress' => \MikeFrancis\LaravelUnleash\Strategies\RemoteAddressStrategy::class,
48-
'userWithIds' => \MikeFrancis\LaravelUnleash\Strategies\UserWithIdStrategy::class,
48+
'userWithId' => \MikeFrancis\LaravelUnleash\Strategies\UserWithIdStrategy::class,
4949
],
5050
];

src/Strategies/UserWithIdStrategy.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ public function isEnabled(array $params, Request $request): bool
1616
return false;
1717
}
1818

19-
return in_array($user->id(), $userIds);
19+
return in_array($user->getAuthIdentifier(), $userIds);
2020
}
2121
}

tests/Strategies/UserWithIdStrategyTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace MikeFrancis\LaravelUnleash\Tests\Strategies;
44

5-
use Illuminate\Contracts\Auth\Guard;
5+
use Illuminate\Contracts\Auth\Authenticatable;
66
use Illuminate\Http\Request;
77
use MikeFrancis\LaravelUnleash\Strategies\UserWithIdStrategy;
88
use PHPUnit\Framework\TestCase;
@@ -15,8 +15,8 @@ public function testWithUserId()
1515
'userIds' => '123,456',
1616
];
1717

18-
$userMock = $this->createMock(Guard::class);
19-
$userMock->expects($this->once())->method('id')->willReturn(123);
18+
$userMock = $this->createMock(Authenticatable::class);
19+
$userMock->expects($this->once())->method('getAuthIdentifier')->willReturn(123);
2020
$request = $this->createMock(Request::class);
2121
$request->expects($this->once())->method('user')->willReturn($userMock);
2222

@@ -31,8 +31,8 @@ public function testWithInvalidUserId()
3131
'userIds' => '123,456',
3232
];
3333

34-
$userMock = $this->createMock(Guard::class);
35-
$userMock->expects($this->once())->method('id')->willReturn(789);
34+
$userMock = $this->createMock(Authenticatable::class);
35+
$userMock->expects($this->once())->method('getAuthIdentifier')->willReturn(789);
3636
$request = $this->createMock(Request::class);
3737
$request->expects($this->once())->method('user')->willReturn($userMock);
3838

0 commit comments

Comments
 (0)