Skip to content

Commit aaa5969

Browse files
committed
compatible with tests
1 parent 60748f1 commit aaa5969

File tree

1 file changed

+19
-9
lines changed

1 file changed

+19
-9
lines changed

mindsdb_sdk/knowledge_bases.py

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,12 @@ def insert_files(self, file_paths: List[str], params: dict = None):
117117
"""
118118
Insert data from file to knowledge base
119119
"""
120+
data = {'files': file_paths}
121+
120122
self.api.insert_into_knowledge_base(
121123
self.project.name,
122124
self.name,
123-
data={'files': file_paths, 'params': params}
125+
data=data
124126
)
125127

126128
def insert_webpages(self, urls: List[str], crawl_depth: int = 1, filters: List[str] = None, params: dict = None):
@@ -132,15 +134,17 @@ def insert_webpages(self, urls: List[str], crawl_depth: int = 1, filters: List[s
132134
:param filters: Include only URLs that match these regex patterns
133135
:param params: Runtime parameters for KB
134136
"""
137+
data={
138+
'urls': urls,
139+
'crawl_depth': crawl_depth,
140+
'filters': [] if filters is None else filters,
141+
}
142+
if params:
143+
data['params'] = params
135144
self.api.insert_into_knowledge_base(
136145
self.project.name,
137146
self.name,
138-
data={
139-
'urls': urls,
140-
'crawl_depth': crawl_depth,
141-
'filters': [] if filters is None else filters,
142-
'params': params
143-
}
147+
data=data
144148
)
145149

146150
def insert(self, data: Union[pd.DataFrame, Query, dict], params: dict = None):
@@ -171,10 +175,13 @@ def insert(self, data: Union[pd.DataFrame, Query, dict], params: dict = None):
171175
else:
172176
raise ValueError("Unknown data type, accepted types: DataFrame, Query, dict")
173177

178+
data = {'rows': data}
179+
if params:
180+
data['params'] = params
174181
return self.api.insert_into_knowledge_base(
175182
self.project.name,
176183
self.name,
177-
data={'rows': data, 'params': params},
184+
data=data,
178185
)
179186

180187
def insert_query(self, data: Query, params: dict = None):
@@ -204,10 +211,13 @@ def insert_query(self, data: Query, params: dict = None):
204211
return Query(self, sql, self.database)
205212

206213
# query have to be in context of mindsdb project
214+
data = {'query': data.sql}
215+
if params:
216+
data['params'] = params
207217
self.api.insert_into_knowledge_base(
208218
self.project.name,
209219
self.name,
210-
data={'query': data.sql, 'params': params}
220+
data=data
211221
)
212222

213223
def completion(self, query, **data):

0 commit comments

Comments
 (0)