Reduce garbage generation

Author: tomcashman

core/src/main/java/org/mini2Dx/miniscript/core/GameScriptingEngine.java

@@ -215,7 +215,7 @@ public GameScriptingEngine(ClasspathScriptProvider classpathScriptProvider,
 
 	private void init(int maxConcurrentScripts) {
 		for(int i = 0; i < maxConcurrentScripts; i++) {
-			threadPoolProvider.submit(this);
+			threadPoolProvider.scheduleAtFixedRate(this, 16L, 16L, TimeUnit.MILLISECONDS);
 		}
 		threadPoolProvider.scheduleAtFixedRate(new Runnable() {
 			@Override
@@ -288,8 +288,9 @@ public void update(float delta) {
 			gameThread = Thread.currentThread();
 		}
 
-		for (GameFuture gameFuture : runningFutures.values()) {
-			gameFuture.evaluate(delta);
+		final List<GameFuture> gameFutures = (List<GameFuture>) runningFutures.values();
+		for (int i = 0; i < gameFutures.size(); i++) {
+			gameFutures.get(i).evaluate(delta);
 		}
 
 		while (!queuedFutures.isEmpty()) {
@@ -359,13 +360,6 @@ public void run() {
 		if(shuttingDown.get()) {
 			return;
 		}
-
-		long duration = System.currentTimeMillis() - startTime;
-		if (duration >= 16L) {
-			threadPoolProvider.submit(this);
-		} else {
-			threadPoolProvider.schedule(this, 16L - duration, TimeUnit.MILLISECONDS);
-		}
 	}
 
 	private void cleanupCompletedFutures() {

core/src/main/java/org/mini2Dx/miniscript/core/threadpool/KavaThreadPoolProvider.java

@@ -98,6 +98,7 @@ public void shutdown(boolean interruptThreads) {
 
 	@Override
 	public void run() {
+		final Thread currentThread = Thread.currentThread();
 		while(running.get()) {
 			final ScheduledTask scheduledTask;
 			try {
@@ -114,7 +115,7 @@ public void run() {
 			}
 			try {
 				final ScheduledTaskFuture future = scheduledTask.getFuture();
-				future.setExecutingThread(Thread.currentThread());
+				future.setExecutingThread(currentThread);
 				final Runnable runnable = scheduledTask.getRunnable();
 				if(runnable != null && !future.isCancelled()) {
 					runnable.run();
@@ -125,7 +126,7 @@ public void run() {
 				final ScheduledTaskFuture future = scheduledTask.getFuture();
 				if(scheduledTask.isRepeating() && !future.isCancelled()) {
 					final ScheduledTask nextTask = ScheduledTask.allocate(scheduledTask.getRunnable(),
-							System.nanoTime() + scheduledTask.getRepeatUnit().toNanos(scheduledTask.getRepeatInterval()),
+							scheduledTask.getScheduledStartTimeNanos() + scheduledTask.getRepeatUnit().toNanos(scheduledTask.getRepeatInterval()),
 							scheduledTask.getRepeatInterval(), scheduledTask.getRepeatUnit());
 
 					nextTask.setFuture(future);

core/src/main/java/org/mini2Dx/miniscript/core/util/ReadWriteMap.java

@@ -104,7 +104,10 @@ public Set<K> keySet() {
 		final Set<K> result = keySet.get();
 		try {
 			result.clear();
-			result.addAll(internalMap.keySet());
+			//addAll allocates arrays unnecessarily
+			internalMap.keySet().forEach((key) -> {
+				result.add(key);
+			});
 		} finally {
 			lock.unlockRead();
 		}
@@ -117,7 +120,10 @@ public Collection<V> values() {
 		final Collection<V> result = values.get();
 		try {
 			result.clear();
-			result.addAll(internalMap.values());
+			//addAll allocates arrays unnecessarily
+			internalMap.values().forEach((val) -> {
+				result.add(val);
+			});
 		} finally {
 			lock.unlockRead();
 		}
@@ -130,7 +136,10 @@ public Set<Entry<K, V>> entrySet() {
 		final Set<Entry<K, V>> result = entrySet.get();
 		try {
 			result.clear();
-			result.addAll(internalMap.entrySet());
+			//addAll allocates arrays unnecessarily
+			internalMap.entrySet().forEach((entry) -> {
+				result.add(entry);
+			});
 		} finally {
 			lock.unlockRead();
 		}