From 762d631a257c6d19eae1cb37f15ebb579214a608 Mon Sep 17 00:00:00 2001
From: jvoisin <julien.voisin@dustri.org>
Date: Thu, 14 Aug 2025 23:27:03 +0200
Subject: [PATCH] refactor(css): set externalIcon size in CSS

There is no need to repeat `width="16" height="16"` for every single
externalIcon in the HTML, when we can specify this in the CSS instead.
---
 internal/template/templates/common/feed_list.html       | 2 +-
 internal/template/templates/views/bookmark_entries.html | 2 +-
 internal/template/templates/views/category_entries.html | 2 +-
 internal/template/templates/views/entry.html            | 2 +-
 internal/template/templates/views/feed_entries.html     | 2 +-
 internal/template/templates/views/history_entries.html  | 2 +-
 internal/template/templates/views/search.html           | 2 +-
 internal/template/templates/views/shared_entries.html   | 2 +-
 internal/template/templates/views/tag_entries.html      | 2 +-
 internal/template/templates/views/unread_entries.html   | 2 +-
 internal/ui/static/css/common.css                       | 5 +++++
 11 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/internal/template/templates/common/feed_list.html b/internal/template/templates/common/feed_list.html
index 21fe71a758b..bf9dfe1eb23 100644
--- a/internal/template/templates/common/feed_list.html
+++ b/internal/template/templates/common/feed_list.html
@@ -10,7 +10,7 @@
                 <h2 id="feed-title-{{ .ID }}" class="item-title">
                     <a href="{{ route "feedEntries" "feedID" .ID }}">
                         {{ if and (.Icon) (gt .Icon.IconID 0) }}
-                        <img src="{{ route "feedIcon" "externalIconID" .Icon.ExternalIconID }}" width="16" height="16" loading="lazy" alt="">
+                        <img src="{{ route "feedIcon" "externalIconID" .Icon.ExternalIconID }}" loading="lazy" alt="">
                         {{ end }}
                         {{ if .Disabled }} 🚫 {{ end }}
                         {{ .Title }}
diff --git a/internal/template/templates/views/bookmark_entries.html b/internal/template/templates/views/bookmark_entries.html
index 2626515ea07..a04a8ae2796 100644
--- a/internal/template/templates/views/bookmark_entries.html
+++ b/internal/template/templates/views/bookmark_entries.html
@@ -29,7 +29,7 @@ <h1 id="page-header-title" dir="auto">
                 <h2 id="entry-title-{{ .ID }}" class="item-title">
                     <a href="{{ route "starredEntry" "entryID" .ID }}">
                         {{ if ne .Feed.Icon.IconID 0 }}
-                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" width="16" height="16" loading="lazy" alt="">
+                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" loading="lazy" alt="">
                         {{ end }}
                         {{ .Title }}
                     </a>
diff --git a/internal/template/templates/views/category_entries.html b/internal/template/templates/views/category_entries.html
index 9ce211f19ec..d2d6242ea5c 100644
--- a/internal/template/templates/views/category_entries.html
+++ b/internal/template/templates/views/category_entries.html
@@ -102,7 +102,7 @@ <h2 id="entry-title-{{ .ID }}" class="item-title">
                         {{ end }}
                     >
                         {{ if ne .Feed.Icon.IconID 0 }}
-                            <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" width="16" height="16" loading="lazy" alt="">
+                            <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" loading="lazy" alt="">
                         {{ end }}
                         {{ .Title }}
                     </a>
diff --git a/internal/template/templates/views/entry.html b/internal/template/templates/views/entry.html
index a1d592963e3..c1dc0ca16e9 100644
--- a/internal/template/templates/views/entry.html
+++ b/internal/template/templates/views/entry.html
@@ -141,7 +141,7 @@ <h1 id="page-header-title" dir="auto">
         <div class="entry-meta" dir="auto">
             <span class="entry-website">
                 {{ if ne .entry.Feed.Icon.IconID 0 }}
-                <img src="{{ route "feedIcon" "externalIconID" .entry.Feed.Icon.ExternalIconID }}" width="16" height="16" loading="lazy" alt="{{ .entry.Feed.Title }}">
+                <img src="{{ route "feedIcon" "externalIconID" .entry.Feed.Icon.ExternalIconID }}" loading="lazy" alt="{{ .entry.Feed.Title }}">
                 {{ end }}
                 {{ if .user }}
                 <a href="{{ route "feedEntries" "feedID" .entry.Feed.ID }}">{{ .entry.Feed.Title }}</a>
diff --git a/internal/template/templates/views/feed_entries.html b/internal/template/templates/views/feed_entries.html
index 9271414c648..b32e4cdf9d0 100644
--- a/internal/template/templates/views/feed_entries.html
+++ b/internal/template/templates/views/feed_entries.html
@@ -113,7 +113,7 @@ <h2 id="entry-title-{{ .ID }}" class="item-title">
                         {{ end }}
                     >
                         {{ if ne .Feed.Icon.IconID 0 }}
-                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" width="16" height="16" loading="lazy" alt="">
+                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" loading="lazy" alt="">
                         {{ end }}
                         {{ .Title }}
                     </a>
diff --git a/internal/template/templates/views/history_entries.html b/internal/template/templates/views/history_entries.html
index 26d2cbd38de..324c531bb2d 100644
--- a/internal/template/templates/views/history_entries.html
+++ b/internal/template/templates/views/history_entries.html
@@ -48,7 +48,7 @@ <h1 id="page-header-title">
                 <h2 id="entry-title-{{ .ID }}" class="item-title">
                     <a href="{{ route "readEntry" "entryID" .ID }}">
                         {{ if ne .Feed.Icon.IconID 0 }}
-                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" width="16" height="16" loading="lazy" alt="">
+                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" loading="lazy" alt="">
                         {{ end }}
                         {{ .Title }}
                     </a>
diff --git a/internal/template/templates/views/search.html b/internal/template/templates/views/search.html
index 13cf7fbc7f1..a3a3c546e99 100644
--- a/internal/template/templates/views/search.html
+++ b/internal/template/templates/views/search.html
@@ -32,7 +32,7 @@ <h1 id="page-header-title">{{ t "page.search.title" }} ({{ .total }})</h1>
                     <h2 id="entry-title-{{ .ID }}" class="item-title">
                         <a href="{{ route "searchEntry" "entryID" .ID }}?q={{ $.searchQuery }}">
                             {{ if ne .Feed.Icon.IconID 0 }}
-                            <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" width="16" height="16" loading="lazy" alt="{{ .Feed.Title }}">
+                            <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" loading="lazy" alt="{{ .Feed.Title }}">
                             {{ else }}
                             <span class="sr-only">{{ .Feed.Title }}</span>
                             {{ end }}
diff --git a/internal/template/templates/views/shared_entries.html b/internal/template/templates/views/shared_entries.html
index f1d366e85aa..509c2e5c406 100644
--- a/internal/template/templates/views/shared_entries.html
+++ b/internal/template/templates/views/shared_entries.html
@@ -48,7 +48,7 @@ <h1 id="page-header-title">
                 <h2 id="entry-title-{{ .ID }}" class="item-title">
                     <a href="{{ route "readEntry" "entryID" .ID }}">
                         {{ if ne .Feed.Icon.IconID 0 }}
-                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" width="16" height="16" loading="lazy" alt="">
+                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" loading="lazy" alt="">
                         {{ end }}
                         {{ .Title }}
                     </a>
diff --git a/internal/template/templates/views/tag_entries.html b/internal/template/templates/views/tag_entries.html
index d5f127ee572..71686e9f3b6 100644
--- a/internal/template/templates/views/tag_entries.html
+++ b/internal/template/templates/views/tag_entries.html
@@ -29,7 +29,7 @@ <h1 id="page-header-title" dir="auto">
                 <h2 id="entry-title-{{ .ID }}" class="item-title">
                     <a href="{{ route "tagEntry" "entryID" .ID "tagName" (urlEncode $.tagName) }}">
                         {{ if ne .Feed.Icon.IconID 0 }}
-                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" width="16" height="16" loading="lazy" alt="">
+                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" loading="lazy" alt="">
                         {{ end }}
                         {{ .Title }}
                     </a>
diff --git a/internal/template/templates/views/unread_entries.html b/internal/template/templates/views/unread_entries.html
index 7dfdae828f0..1f980bebf76 100644
--- a/internal/template/templates/views/unread_entries.html
+++ b/internal/template/templates/views/unread_entries.html
@@ -56,7 +56,7 @@ <h1 id="page-header-title">
                 <h2 id="entry-title-{{ .ID }}" class="item-title">
                     <a href="{{ route "unreadEntry" "entryID" .ID }}">
                         {{ if ne .Feed.Icon.IconID 0 }}
-                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" width="16" height="16" loading="lazy" alt="">
+                        <img src="{{ route "feedIcon" "externalIconID" .Feed.Icon.ExternalIconID }}" loading="lazy" alt="">
                         {{ end }}
                         {{ .Title }}
                     </a>
diff --git a/internal/ui/static/css/common.css b/internal/ui/static/css/common.css
index d9f1a04af87..47888f769e2 100644
--- a/internal/ui/static/css/common.css
+++ b/internal/ui/static/css/common.css
@@ -816,6 +816,11 @@ template {
     font-size: inherit;
 }
 
+.item-title img {
+    width: 16px;
+    height: 16px;
+}
+
 .feed-entries-counter {
     display: inline-flex;
     gap: 2px;