Mink's use of stripos leads to some empty string behaviors in PHP 8

[neclimdul]

In PHP 8 empty strings are present in every string. This means that depending on which version of PHP you're using, assertions like assertContains and assertNotContains can behave different.

I thought this was a bug but it seems to be an intentional but fairly undocumented change in PHP8
https://3v4l.org/VGB5j
https://php.watch/versions/8.0/string-function-empty-needles

This may not be a bug, but because it will always pass (or fail) it does not seem like the intended functionality. Also personally it seems like passing an empty string to these assertions means something went wrong in the code calling the assertion and its more useful result is to fail then to treat it as passing.

[aik099]

I agree that searching for an empty string looks like a bug. If test suite passes on PHP 8, then we're good for now :)

[neclimdul]

Yeah I ran into this because Drupal’s test suite passed when it shouldn't and then failed when 7.x tests ran on the commit.

If you agree it looks buggy I'll get a pr together and see what it looks like.

[aik099]

PR, that does what exactly?