Skip to content

address-show should include coins belonging to "pub key" addresses #1981

@ImplOfAnImpl

Description

@ImplOfAnImpl

E.g. I have

+-------+---------+----------------------------------------------+--------------------------------+--------------------+
| Index | Purpose | Address                                      | Is used in transaction history | Coins              |
+=======+=========+==============================================+================================+====================+
| 0     | Receive | tmt1q94w2g3vwvw74swj3gx4kaf5qelapmdhyyyxe3ef | Yes                            | 523437.13324032693 |

The problem is that I also have some TML belonging to the "pub key" address corresponding to the shown "pub key hash" one, but this amount is not included anywhere in the output of address-show.
As a result, he sum of amounts in address-show is less than the amount returned by account-balance, which is confusing.

One of ways to go about this is to make the "Colins" column show the sum of both amounts.
This can be done either by default (could be confusing too) or via a separate option, e.g. something like --with-pk-amounts.
In the latter case it could also make sense to alter the title of the "Coins" column based on whether --with-pk-amounts was passed or not. E.g. it could be something like "Coins (total)" if it was passed and "Coins (PKH only)" if it wasn't.

Alternatively, we could have separate columns for different amounts, e.g. "Coins (PKH)", "Coins (PK)", "Coins (total)".

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions