chore: add additional assertions of redirect url and ass scopes test (#29)

Author: ricklambrechts

config/oidc.php

@@ -29,7 +29,7 @@
     /**
      * By default, the openid scope is requested. If you need additional scopes, you can specify them here.
      */
-    'additional_scopes' => explode(',', env('OIDC_ADDITIONAL_SCOPES', '')),
+    'additional_scopes' => array_filter(explode(',', env('OIDC_ADDITIONAL_SCOPES', ''))),
 
     /**
      * Code Challenge Method used for PKCE.

tests/Feature/Http/Controllers/LoginControllerTest.php

@@ -33,8 +33,43 @@ public function testLoginRouteRedirectsToAuthorizeUrlOfProvider(): void
         $response
             ->assertStatus(302)
             ->assertRedirectContains("https://provider.rdobeheer.nl/authorize")
-            ->assertRedirectContains('test-client-id');
+            ->assertRedirectContains('response_type=code')
+            ->assertRedirectContains('redirect_uri=http%3A%2F%2Flocalhost%2Foidc%2Flogin')
+            ->assertRedirectContains('client_id=test-client-id')
+            ->assertRedirectContains('scope=openid')
+            ->assertRedirectContains('code_challenge_method=S256');
     }
+
+    /**
+     * @dataProvider scopesProvider
+     */
+    public function testLoginRouteRedirectsToAuthorizeUrlOfProviderWithScopes(
+        array $additionalScopes,
+        string $scopeInUrl
+    ): void {
+        $this->mockOpenIDConfigurationLoader();
+
+        config()->set('oidc.client_id', 'test-client-id');
+        config()->set('oidc.additional_scopes', $additionalScopes);
+
+        $response = $this->get(route('oidc.login', ['login_hint' => 'test-login-hint']));
+        $response
+            ->assertStatus(302)
+            ->assertRedirectContains("https://provider.rdobeheer.nl/authorize")
+            ->assertRedirectContains('test-client-id')
+            ->assertRedirectContains('login_hint=test-login-hint')
+            ->assertRedirectContains($scopeInUrl);
+    }
+
+    public static function scopesProvider(): array
+    {
+        return [
+            'no scopes' => [[], 'scope=openid'],
+            'one scope' => [['test-scope-1'], 'scope=test-scope-1+openid'],
+            'multiple scopes' => [['test-scope-1', 'test-scope-2'], 'scope=test-scope-1+test-scope-2+openid'],
+        ];
+    }
+
     public function testLoginRouteRedirectsToAuthorizeUrlOfProviderWithLoginHint(): void
     {
         $this->mockOpenIDConfigurationLoader();