Skip to content

Commit 5dec7f3

Browse files
authored
log error if a shard has a failure (#2690)
1 parent 5fc50e0 commit 5dec7f3

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

docker-compose.opensearch.base.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
services:
22
opensearch:
3-
image: opensearchproject/opensearch:2.19.3
3+
image: opensearchproject/opensearch:3.1.0
44
environment:
55
- "cluster.name=opensearch-cluster"
66
- "bootstrap.memory_lock=true" # along with the memlock settings below, disables swapping

learning_resources_search/api.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -739,7 +739,13 @@ def execute_learn_search(search_params):
739739
settings.DEFAULT_SEARCH_MAX_INCOMPLETENESS_PENALTY
740740
)
741741
search = construct_search(search_params)
742-
return search.execute().to_dict()
742+
results = search.execute().to_dict()
743+
if results.get("_shards", {}).get("failures"):
744+
log.error(
745+
"Search encountered shard failures: %s",
746+
results.get("_shards").get("failures"),
747+
)
748+
return results
743749

744750

745751
def subscribe_user_to_search_query(

0 commit comments

Comments
 (0)