Fix scaled dot product attention mask argument (#236)

louen · web-flow · commit a8f7411d0c7b · 2025-05-07T16:10:13.000-07:00
* fix SADP

* empty mask
diff --git a/Source/MLX/MLXFast.swift b/Source/MLX/MLXFast.swift
@@ -94,7 +94,7 @@ public enum MLXFast {
         mlx_fast_scaled_dot_product_attention(
             &result,
             queries.ctx, keys.ctx, values.ctx, scale,
-            mask == nil ? "causal" : "", masks,
+            "", masks,
             stream.ctx)
         return MLXArray(result)
     }

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public enum MLXFast {`
`94`	`94`	`mlx_fast_scaled_dot_product_attention(`
`95`	`95`	`&result,`
`96`	`96`	`queries.ctx, keys.ctx, values.ctx, scale,`
`97`		`- mask == nil ? "causal" : "", masks,`
	`97`	`+ "", masks,`
`98`	`98`	`stream.ctx)`
`99`	`99`	`return MLXArray(result)`
`100`	`100`	`}`