Merge pull request #203 from mlcommons/dev

Merge Dev

Author: anandhu-eng

.github/workflows/test-mlc-script-features.yml

@@ -113,7 +113,9 @@ jobs:
 
         mlcr --tags=install,python-venv --version=3.10.8 --name=mlperf --quiet
 
-        mlcr --tags=run,mlperf,inference,_submission,_short --adr.python.name=mlperf --adr.python.version_min=3.8 --adr.compiler.tags=gcc --adr.openimages-preprocessed.tags=_50 --submitter=MLCommons --implementation=cpp --hw_name=default --model=retinanet --backend=onnxruntime --device=cpu --scenario=Offline --quiet
+        export MLC_SCRIPT_EXTRA_CMD="--adr.python.name=mlperf"
+
+        mlcr --tags=run,mlperf,inference,_submission,_short --adr.python.version_min=3.8 --adr.compiler.tags=gcc --adr.openimages-preprocessed.tags=_50 --submitter=MLCommons --implementation=cpp --hw_name=default --model=retinanet --backend=onnxruntime --device=cpu --scenario=Offline --quiet
 
      # Step for Linux/MacOS
     - name: Randomly Execute Step (Linux/MacOS)

.github/workflows/test-mlperf-inference-abtf-poc.yml

@@ -10,6 +10,7 @@ on:
 
 jobs:
   build:
+    name: Test MLPerf Inference ABTF POC
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false

.github/workflows/test-mlperf-inference-bert-deepsparse-tf-onnxruntime-pytorch.yml

@@ -10,6 +10,7 @@ on:
 
 jobs:
   build:
+    name: MLPerf Inference Bert ${{ matrix.backend }} on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false

.github/workflows/test-mlperf-inference-mlcommons-cpp-resnet50.yml

@@ -10,6 +10,7 @@ on:
 
 jobs:
   build:
+    name: MLPerf inference MLCommons C++ ResNet50
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false

.github/workflows/test-mlperf-inference-rgat.yml

@@ -9,7 +9,8 @@ on:
       - '!**.md'
 
 jobs:
-  build:
+  rgat-inference-run:
+    name:  ${{ matrix.os }} - ${{ matrix.backend }} - ${{ matrix.implementation }}
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false

.github/workflows/test-mlperf-inference-tvm-resnet50.yml

@@ -10,6 +10,7 @@ on:
 
 jobs:
   tvm-run:
+    name: TVM ResNet50
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false

.github/workflows/test-mlperf-loadgen-onnx-huggingface-bert-fp32-squad.yml

@@ -10,7 +10,7 @@ on:
 
 jobs:
   build:
-
+    name: Test MLPerf loadgen with HuggingFace bert onnx fp32 squad model on Python ${{ matrix.python-version }}
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false

.github/workflows/test-nvidia-mlperf-inference-implementations.yml

@@ -17,12 +17,14 @@ jobs:
       strategy:
         fail-fast: false
         matrix:
-          system: [ "GO-spr", "phoenix"]
+          system: [ "GO-spr", "phoenix", "GO-i9" ]
           # system: [ "mlc-server" ] 
           python-version: [ "3.12" ]
           model: [ "resnet50",  "retinanet",  "bert-99", "bert-99.9", "gptj-99.9", "3d-unet-99.9", "sdxl" ]
           exclude:
            - model: gptj-99.9
+           - system: phoenix
+           - system: GO-i9
 
       steps:
       - name: Test MLPerf Inference NVIDIA ${{ matrix.model }}
@@ -43,12 +45,7 @@ jobs:
             gpu_name=rtx_4090
             docker_string=" --docker"
           fi
-          if [ "${{ matrix.model }}" = "bert-99" ] || [ "${{ matrix.model }}" = "bert-99.9" ]; then
-            category="edge"
-          else
-            category="datacenter,edge"
-          fi
-
+          category="datacenter,edge"
           if [ -f "gh_action/bin/deactivate" ]; then source gh_action/bin/deactivate; fi
           python3 -m venv gh_action
           source gh_action/bin/activate

automation/script/docker_utils.py

@@ -109,7 +109,7 @@ def prepare_docker_inputs(input_params, docker_settings,
         keys += [
             "skip_run_cmd", "pre_run_cmds", "run_cmd_prefix", "all_gpus", "num_gpus", "device", "gh_token",
             "port_maps", "shm_size", "pass_user_id", "pass_user_group", "extra_run_args", "detached", "interactive",
-            "dt", "it", "use_host_group_id", "use_host_user_id", "keep_detached", "reuse_existing"
+            "dt", "it", "use_host_group_id", "use_host_user_id", "keep_detached", "reuse_existing", "use_google_dns"
         ]
     # Collect Dockerfile inputs
     docker_inputs = {
@@ -413,7 +413,7 @@ def get_container_path_script(i):
 def get_container_path(value, username="mlcuser"):
     path_split = value.split(os.sep)
     if len(path_split) == 1:
-        return value
+        return value, value
 
     new_value = ''
     if "cache" in path_split and "local" in path_split:

automation/script/module.py

@@ -273,31 +273,17 @@ def _run(self, i):
         # Useful to set up default flags such as the name of virtual enviroment
         extra_cli = os.environ.get('MLC_SCRIPT_EXTRA_CMD', '').strip()
         if extra_cli != '':
-            from cmind import cli
-            r = cli.parse(extra_cli)
+            r = convert_args_to_dictionary(extra_cli)
             if r['return'] > 0:
                 return r
 
-            mlc_input = r['mlc_input']
+            mlc_input = r['args_dict']
 
             utils.merge_dicts({'dict1': i,
                                'dict2': mlc_input,
                                'append_lists': True,
                                'append_unique': True})
 
-        # Check if has extra tags as a second artifact
-        # Example: cmr . "_python _tiny"
-
-        parsed_artifacts = i.get('parsed_artifacts', [])
-        if len(parsed_artifacts) > 0:
-            extra_tags = parsed_artifacts[0][0][0]
-            if ' ' in extra_tags or ',' in extra_tags:
-                # Add tags
-                x = i.get('tags', '')
-                if x != '':
-                    x += ','
-                i['tags'] = x + extra_tags.replace(' ', ',')
-
         # Recursion spaces needed to format log and print
         recursion_spaces = i.get('recursion_spaces', '')
         # Caching selections to avoid asking users again