Update ruleset for modern (PHP 8+) code

Author: mmoll

MO4/ruleset.xml

@@ -14,6 +14,10 @@
         <!-- exclude sniffs that are disabled on purpose by this standard -->
         <exclude name="Symfony.Commenting.ClassComment.Missing"/>
         <exclude name="Symfony.Commenting.License"/>
+        <!-- SlevomatCodingStandard.ControlStructures.RequireYodaComparison supports autofixing -->
+        <exclude name="Symfony.ControlStructure.YodaConditions.Invalid"/>
+        <!-- disable forcing of function type hints as we're requiring native types -->
+        <exclude name="Symfony.Commenting.FunctionComment"/>
     </rule>
 
     <!-- Also include PSR12 -->
@@ -131,8 +135,16 @@
     </rule>
     <!-- Require usage of ::class instead of __CLASS__, get_class(), get_class($this), get_called_class() and get_parent_class() -->
     <rule ref="SlevomatCodingStandard.Classes.ModernClassNameReference"/>
+    <!-- Require use of constructor property promotion -->
+    <rule ref="SlevomatCodingStandard.Classes.RequireConstructorPropertyPromotion"/>
+    <!-- Forbid static:: in final class -->
+    <rule ref="SlevomatCodingStandard.Classes.UselessLateStaticBinding"/>
+    <!-- Forbid empty comments-->
+    <rule ref="SlevomatCodingStandard.Commenting.EmptyComment"/>
     <!-- report invalid format of inline phpDocs with @var -->
     <rule ref="SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration"/>
+    <!-- Forbid useless function doc comments -->
+    <rule ref="SlevomatCodingStandard.Commenting.UselessFunctionDocComment"/>
     <!-- Forbid useless @inheritDoc comments -->
     <rule ref="SlevomatCodingStandard.Commenting.UselessInheritDocComment"/>
     <!-- Forbid assignments in conditions -->
@@ -159,13 +171,21 @@
     <rule ref="SlevomatCodingStandard.ControlStructures.NewWithParentheses"/>
     <!-- Require usage of null coalesce operator when possible -->
     <rule ref="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator"/>
+    <!-- Require usage of null coalesce equal operator when possible -->
+    <rule ref="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceEqualOperator"/>
+    <!-- Require usage of null safe operator when possible -->
+    <rule ref="SlevomatCodingStandard.ControlStructures.RequireNullSafeObjectOperator"/>
     <!-- Require usage of ternary operator when possible -->
     <rule ref="SlevomatCodingStandard.ControlStructures.RequireTernaryOperator">
         <!-- But multiline is useful for readability -->
         <properties>
             <property name="ignoreMultiLine" value="true"/>
         </properties>
     </rule>
+    <!-- Require Yoda comparisons -->
+    <rule ref="SlevomatCodingStandard.ControlStructures.RequireYodaComparison"/>
+    <!-- Formatting of arrow functions -->
+    <rule ref="SlevomatCodingStandard.Functions.ArrowFunctionDeclaration"/>
     <!-- Enforce consistent spacing of named arguments -->
     <rule ref="SlevomatCodingStandard.Functions.NamedArgumentSpacing"/>
     <!-- Require static closures for microoptimization -->
@@ -237,10 +257,10 @@
         </properties>
     </rule>
     <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.UselessAnnotation">
-        <severity>0</severity>
+        <severity>9</severity>
     </rule>
     <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingTraversableTypeHintSpecification">
-        <severity>0</severity>
+        <severity>9</severity>
     </rule>
     <!-- Require return type hints to be declared -->
     <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint">
@@ -251,10 +271,19 @@
         </properties>
     </rule>
     <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.UselessAnnotation">
-        <severity>0</severity>
+        <severity>9</severity>
     </rule>
     <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingTraversableTypeHintSpecification">
-        <severity>0</severity>
+        <severity>9</severity>
+    </rule>
+    <!-- DNF (union / intersection) type hint formatting -->
+    <rule ref="SlevomatCodingStandard.TypeHints.DNFTypeHintFormat">
+        <properties>
+            <property name="withSpacesAroundOperators" value="yes"/>
+            <property name="withSpacesInsideParentheses" value="no"/>
+            <property name="shortNullable" value="yes"/>
+            <property name="nullPosition" value="last"/>
+        </properties>
     </rule>
     <!-- Forbid useless @var for constants -->
     <rule ref="SlevomatCodingStandard.TypeHints.UselessConstantTypeHint"/>

composer.json

@@ -26,7 +26,7 @@
         "php": "^8.1",
         "dealerdirect/phpcodesniffer-composer-installer": "^0.7 || ^1.0",
         "escapestudios/symfony2-coding-standard": "^3.16.0",
-        "slevomat/coding-standard": "^8.14",
+        "slevomat/coding-standard": "^8.20",
         "squizlabs/php_codesniffer": "^3.8.0"
     },
     "require-dev": {

integrationtests/testfile.php

@@ -39,8 +39,6 @@ public function __construct(string $dummy)
     }
 
     /**
-     * @return string
-     *
      * @deprecated
      */
     public function someDeprecatedMethod(): string
@@ -53,8 +51,8 @@ public function someDeprecatedMethod(): string
     /**
      * Transforms the input given as first argument.
      *
-     * @param bool|string $dummy   Some argument description
-     * @param array       $options An options collection to be used within the transformation
+     * @param bool|string   $dummy   Some argument description
+     * @param array<string> $options An options collection to be used within the transformation
      *
      * @return string|null The transformed input
      *