Skip to content

Conversation

@bserem
Copy link
Contributor

@bserem bserem commented Apr 18, 2025

Addresses #18

This is heavily inspired (as in "copied") from https://github.com/tyler36/ddev-cypress/pull/54/files

I was facing the same issues on projects with multiple hostnames, where surprisingly even the main domain (my.ddev.site) was not resolving for backstop.
The PR is fixing things for me.

@bserem
Copy link
Contributor Author

bserem commented May 31, 2025

@mmunz this has been working for me, any thoughts? Shall we merge it?

@mmunz mmunz self-requested a review June 9, 2025 05:36
@mmunz mmunz self-assigned this Jun 9, 2025
@mmunz
Copy link
Owner

mmunz commented Jun 9, 2025

@bserem the code in

if [ -n "$routerIp" ]; then
didn't work for you? This should already add the hostnames and also works for me with additional_hostnames. I didn't try with additional_fqdns though.

@bserem
Copy link
Contributor Author

bserem commented Jun 11, 2025

@mmunz , it only works for me if I apply the changes of this merge request when I use multiple hostnames in DDEV.

So, for all projects I rely on your repo, but for projects with multiple hostnames I still rely on https://github.com/bserem/ddev-backstopjs/tree/multiple-hostnames
I do not use additional FQDNs myself, so I can't test those yet.

@stasadev
Copy link

This fix will not be needed in the next DDEV release (v1.24.9):

Make sure to add ddev_version_constraint: '>= v1.24.9' to install.yaml when it's out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants