Stop Relying On A2S_PLAYER Query For Online Status #12
Description
As of right now, games we have utilizing A2S queries have servers that are required to respond to the A2S_PLAYER query which is used to retrieve the users list. I decided to require this temporarily to combat fake/redirect servers until we have stronger filtering methods in-place (see #9).
While this does really help combat some fake/redirect servers, there are legitimate hosting providers that drop or rate limit these responses due to things like (D)DoS protection and mitigation. Therefore, I'd prefer not relying on this query to determine if a server is online. Instead, the A2S_INFO query that we use already should be responsible for that.
I've already seen some false-positives. This led me to add a moderation option to exempt a server from requiring the A2S_PLAYER response determine whether the server is online or not.
With that said, I made it so when a server is offline, but not labeled as online due to the retry count not being exceeded, it won't touch the player list so users will still show as online who were on the server before the failed response.