I2cMaster::connect<Signals..., reset>() without resetting devices

[rleh]

The I2cMaster::connect<Signals..., reset>() function takes a I2cMaster::ResetDevices enum value as (last) template argument to configure/disable the integrated reset mechanism.

modm/src/modm/platform/i2c/stm32/i2c_master.hpp.in

Lines 43 to 45 in 0992ab1

	template<class... Signals, ResetDevices reset = ResetDevices::Standard>
	static void
	connect(PullUps pullups = PullUps::External)

The default value is ResetDevices::Standard (= pull SDA low and 9 clock cycles at 100kHz) which works fine, but it is not possible to actually specify a (different) value:

error: no matching function for call to 'modm::platform::I2cMaster1::connect<modm::platform::detail::DataB8::Scl, modm::platform::detail::DataB9::Sda, modm::I2cMaster::ResetDevices::NoReset>()'
MyI2cMaster::connect<Scl::Scl, Sda::Sda, modm::I2cMaster::ResetDevices::NoReset>();

[chris-durand]

This does not work in C++. The compiler will interpret all parameters as types which are part of the Signals parameter pack:
https://gcc.godbolt.org/z/rY46d5M8E

We should make the reset setting a normal runtime function parameter.

[salkinium]

We should make the reset setting a normal runtime function parameter.

Yes. It'll be optimized away if unused.

[rleh]

I'll take care of a fix (before 2022q1 release next week). 🙂

[chris-durand]

Will be fixed in #842