Explicit $setOnInsert not necessary

Author: GromNaN

src/Scout/ScoutEngine.php

@@ -126,7 +126,8 @@ public function update($models)
                 'updateOne' => [
                     ['_id' => $model->getScoutKey()],
                     [
-                        '$setOnInsert' => ['_id' => $model->getScoutKey()],
+                        // The _id field is added automatically when the document is inserted
+                        // Update all other fields
                         '$set' => $searchableData,
                     ],
                     ['upsert' => true],

tests/Scout/ScoutEngineTest.php

@@ -485,14 +485,14 @@ public function testUpdate(): void
                 [
                     'updateOne' => [
                         ['_id' => 'key_1'],
-                        ['$setOnInsert' => ['_id' => 'key_1'], '$set' => ['id' => 1, 'date' => new UTCDateTime($date)]],
+                        ['$set' => ['id' => 1, 'date' => new UTCDateTime($date)]],
                         ['upsert' => true],
                     ],
                 ],
                 [
                     'updateOne' => [
                         ['_id' => 'key_2'],
-                        ['$setOnInsert' => ['_id' => 'key_2'], '$set' => ['id' => 2]],
+                        ['$set' => ['id' => 2]],
                         ['upsert' => true],
                     ],
                 ],
@@ -525,7 +525,7 @@ public function testUpdateWithSoftDelete(): void
                     [
                         'updateOne' => [
                             ['_id' => 'key_1'],
-                            ['$setOnInsert' => ['_id' => 'key_1'], '$set' => ['id' => 1, '__soft_deleted' => false]],
+                            ['$set' => ['id' => 1, '__soft_deleted' => false]],
                             ['upsert' => true],
                         ],
                     ],