CLOUDP-285949: add support for flex clusters to atlas backup snaphots list (#3483)

Author: andreaangiolillo

internal/cli/backup/snapshots/list.go

@@ -24,6 +24,7 @@ import (
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/store"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/usage"
 	"github.com/spf13/cobra"
+	atlasv2 "go.mongodb.org/atlas-sdk/v20241113002/admin"
 )
 
 type ListOpts struct {
@@ -45,17 +46,47 @@ func (opts *ListOpts) initStore(ctx context.Context) func() error {
 var listTemplate = `ID	TYPE	STATUS	CREATED AT	EXPIRES AT{{range valueOrEmptySlice .Results}}
 {{.Id}}	{{.SnapshotType}}	{{.Status}}	{{.CreatedAt}}	{{.ExpiresAt}}{{end}}
 `
+var listTemplateFlex = `ID	STATUS	MONGODB VERSION	START TIME	FINISH TIME	EXPIRATION{{range valueOrEmptySlice .Results}}
+{{.Id}}	{{.Status}}	{{.MongoDBVersion}}	{{.StartTime}}	{{.FinishTime}}	{{.Expiration}}{{end}}
+`
 
 func (opts *ListOpts) Run() error {
+	r, err := opts.store.FlexClusterSnapshots(opts.newListFlexBackupsAPIParams())
+	if err == nil {
+		opts.Template = listTemplateFlex
+		return opts.Print(r)
+	}
+
+	apiError, ok := atlasv2.AsError(err)
+	if !ok {
+		return err
+	}
+
+	if apiError.ErrorCode != cannotUseNotFlexWithFlexApisErrorCode {
+		return err
+	}
+
 	listOpts := opts.NewListOptions()
-	r, err := opts.store.Snapshots(opts.ConfigProjectID(), opts.clusterName, listOpts)
+	snapshotsList, err := opts.store.Snapshots(opts.ConfigProjectID(), opts.clusterName, listOpts)
 	if err != nil {
 		return err
 	}
 
-	return opts.Print(r)
+	return opts.Print(snapshotsList)
+}
+
+func (opts *ListOpts) newListFlexBackupsAPIParams() *atlasv2.ListFlexBackupsApiParams {
+	includeCount := !opts.ListOpts.OmitCount
+	return &atlasv2.ListFlexBackupsApiParams{
+		GroupId:      opts.ConfigProjectID(),
+		Name:         opts.clusterName,
+		IncludeCount: &includeCount,
+		ItemsPerPage: &opts.ListOpts.ItemsPerPage,
+		PageNum:      &opts.ListOpts.PageNum,
+	}
 }
 
+// ListBuilder builds a cobra.Command that can run as:
 // atlas backups snapshots list <clusterName> [--projectId projectId] [--page N] [--limit N].
 func ListBuilder() *cobra.Command {
 	opts := new(ListOpts)

internal/cli/backup/snapshots/list_test.go

@@ -25,6 +25,7 @@ import (
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/mocks"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/pointer"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/test"
+	"github.com/stretchr/testify/require"
 	atlasv2 "go.mongodb.org/atlas-sdk/v20241113002/admin"
 )
 
@@ -52,14 +53,45 @@ func TestList_Run(t *testing.T) {
 		},
 	}
 
+	expectedError := &atlasv2.GenericOpenAPIError{}
+	expectedError.SetModel(atlasv2.ApiError{ErrorCode: cannotUseNotFlexWithFlexApisErrorCode})
+
+	mockStore.
+		EXPECT().
+		FlexClusterSnapshots(listOpts.newListFlexBackupsAPIParams()).
+		Return(nil, expectedError).
+		Times(1)
+
 	mockStore.
 		EXPECT().
 		Snapshots(listOpts.ProjectID, "Cluster0", listOpts.NewListOptions()).
 		Return(expected, nil).
 		Times(1)
 
-	if err := listOpts.Run(); err != nil {
-		t.Fatalf("Run() unexpected error: %v", err)
+	require.NoError(t, listOpts.Run())
+	test.VerifyOutputTemplate(t, listTemplate, expected)
+}
+
+func TestList_Run_FlexCluster(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	mockStore := mocks.NewMockSnapshotsLister(ctrl)
+	expected := &atlasv2.PaginatedApiAtlasFlexBackupSnapshot20241113{}
+	buf := new(bytes.Buffer)
+	listOpts := &ListOpts{
+		store:       mockStore,
+		clusterName: "Cluster0",
+		OutputOpts: cli.OutputOpts{
+			Template:  listTemplate,
+			OutWriter: buf,
+		},
 	}
+
+	mockStore.
+		EXPECT().
+		FlexClusterSnapshots(listOpts.newListFlexBackupsAPIParams()).
+		Return(expected, nil).
+		Times(1)
+
+	require.NoError(t, listOpts.Run())
 	test.VerifyOutputTemplate(t, listTemplate, expected)
 }