Separate lock object. Get rid of useful Monitor.Pulse()

Author: nerzhulart

Mono.Debugging/Mono.Debugging.Evaluation/AsyncOperationManager.cs

@@ -34,15 +34,17 @@ namespace Mono.Debugging.Evaluation
 {
 	public class AsyncOperationManager: IDisposable
 	{
-		List<AsyncOperation> operationsToCancel = new List<AsyncOperation> ();
+		readonly List<AsyncOperation> operationsToCancel = new List<AsyncOperation> ();
+		readonly object operationsSync = new object ();
+
 		internal bool Disposing;
 
 		public void Invoke (AsyncOperation methodCall, int timeout)
 		{
 			methodCall.Aborted = false;
 			methodCall.Manager = this;
 
-			lock (operationsToCancel) {
+			lock (operationsSync) {
 				operationsToCancel.Add (methodCall);
 				methodCall.Invoke ();
 			}
@@ -51,9 +53,8 @@ public void Invoke (AsyncOperation methodCall, int timeout)
 				if (!methodCall.WaitForCompleted (timeout)) {
 					bool wasAborted = methodCall.Aborted;
 					methodCall.InternalAbort ();
-					lock (operationsToCancel) {
+					lock (operationsSync) {
 						operationsToCancel.Remove (methodCall);
-						ST.Monitor.PulseAll (operationsToCancel);
 					}
 					if (wasAborted)
 						throw new EvaluatorAbortedException ();
@@ -65,9 +66,8 @@ public void Invoke (AsyncOperation methodCall, int timeout)
 				methodCall.WaitForCompleted (System.Threading.Timeout.Infinite);
 			}
 
-			lock (operationsToCancel) {
+			lock (operationsSync) {
 				operationsToCancel.Remove (methodCall);
-				ST.Monitor.PulseAll (operationsToCancel);
 				if (methodCall.Aborted) {
 					throw new EvaluatorAbortedException ();
 				}
@@ -81,7 +81,7 @@ public void Invoke (AsyncOperation methodCall, int timeout)
 		public void Dispose ()
 		{
 			Disposing = true;
-			lock (operationsToCancel) {
+			lock (operationsSync) {
 				foreach (AsyncOperation op in operationsToCancel) {
 					op.InternalShutdown ();
 				}
@@ -91,7 +91,7 @@ public void Dispose ()
 
 		public void AbortAll ()
 		{
-			lock (operationsToCancel) {
+			lock (operationsSync) {
 				foreach (AsyncOperation op in operationsToCancel)
 					op.InternalAbort ();
 			}