Skip to content

MetricOverviewContainer dataFetch is not rejected when metric data is not found #313

@openjck

Description

@openjck

Because this is a single-page app, even paths which are not found return a 200. For example:

https://data.firefox.com/datasets/desktop/user-activity/Worldwide/nonExistentMetric

When react-refetch tries to fetch a page like this, the dataFetch gets stuck in pending forever, so no error message is ever shown. Switching to a server-side framework like Next.js (#142) would probably solve this. Alternatively, we could host data from a different domain which does return 404s for non-existent paths.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions