Tests & FMT

Author: MSroczynski3

src/rules/prefer-web-first-assertions.test.ts

@@ -641,6 +641,12 @@ runRuleTester('prefer-web-first-assertions', rule, {
       code: javascript('expect(await foo.allTextContents()).toBe("bar")'),
       errors: [{ messageId: 'useWebFirstAssertion' }],
     },
+    {
+      code: javascript(`
+          const myText = page.locator('foo li').allTextContents();
+          expect(myText).toEqual(['Alpha', 'Beta', 'Gamma'])`),
+      errors: [{ messageId: 'useWebFirstAssertion' }],
+    },
     {
       code: javascript('expect(await foo.allTextContents()).not.toBe("bar")'),
       errors: [{ messageId: 'useWebFirstAssertion' }],
@@ -1266,6 +1272,7 @@ runRuleTester('prefer-web-first-assertions', rule, {
     { code: test('let visible = await foo.isVisible()') },
     { code: test('const value = await bar["inputValue"]()') },
     { code: test('const isEditable = await baz[`isEditable`]()') },
+    { code: test('const myText = page.locator("foo li").allTextContents()') },
     {
       code: javascript`
         import { expect } from '@playwright/test';
@@ -1332,10 +1339,5 @@ runRuleTester('prefer-web-first-assertions', rule, {
         expect(fooLocatorText).toEqual('foo')
       `),
     },
-    {
-      code: test(`
-        const myText = page.locator('foo li').allTextContents();
-        expect(myText).toEqual(['Alpha', 'Beta', 'Gamma'])`),
-    },
   ],
 })

src/rules/prefer-web-first-assertions.ts

@@ -112,17 +112,17 @@ export default createRule({
           (+!!notModifier ^ +isFalsy && methodConfig.inverse) ||
           methodConfig.matcher
 
-          // We don't want to provide fix suggestion for some methods.
-          // In this case, we just report the error and let the user handle it.
-          if (methodConfig.noFix) {
-            context.report({
-              data: { matcher: methodConfig.matcher, method },
-              messageId: 'useWebFirstAssertion',
-              node: call.callee.property,
-            })
-            return
-          }
-          
+        // We don't want to provide fix suggestion for some methods.
+        // In this case, we just report the error and let the user handle it.
+        if (methodConfig.noFix) {
+          context.report({
+            data: { matcher: methodConfig.matcher, method },
+            messageId: 'useWebFirstAssertion',
+            node: call.callee.property,
+          })
+          return
+        }
+
         const { callee } = call
         context.report({
           data: {