From 7acca88dd56c0a39417e1e5a9e12b975c4fd450b Mon Sep 17 00:00:00 2001 From: silverwind Date: Tue, 16 Sep 2025 16:28:27 +0200 Subject: [PATCH 1/5] Update `globals` dependency --- package.json | 2 +- pnpm-lock.yaml | 13 ++++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index d367b628..21a2806b 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "eslint": ">=8.40.0" }, "dependencies": { - "globals": "^13.23.0" + "globals": "^16.4.0" }, "devDependencies": { "@anolilab/semantic-release-clean-package-json": "^3.0.2", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 136d4abe..92697577 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -9,8 +9,8 @@ importers: .: dependencies: globals: - specifier: ^13.23.0 - version: 13.23.0 + specifier: ^16.4.0 + version: 16.4.0 devDependencies: '@anolilab/semantic-release-clean-package-json': specifier: ^3.0.2 @@ -3027,6 +3027,7 @@ packages: engines: {node: '>=8'} dependencies: type-fest: 0.20.2 + dev: true /globals@14.0.0: resolution: {integrity: sha512-oahGvuMGQlPw/ivIYBjVSrWAfWLBeku5tpPE2fOPLi+WHffIWbuh2tCjhyQhTBPMf5E9jDEH4FOmTYgYwbKwtQ==} @@ -3037,6 +3038,11 @@ packages: engines: {node: '>=18'} dev: true + /globals@16.4.0: + resolution: {integrity: sha512-ob/2LcVVaVGCYN+r14cnwnoDPUufjiYgSqRhiFD0Q1iI4Odora5RE8Iv1D24hAz5oMophRGkGz+yuvQmmUMnMw==} + engines: {node: '>=18'} + dev: false + /globalthis@1.0.4: resolution: {integrity: sha512-DpLKbNU4WylpxJykQujfCcwYWiV/Jhm50Goo0wrVILAv5jOr9d+H+UR3PhSCD2rCCEIg0uc+G+muBTwD54JhDQ==} engines: {node: '>= 0.4'} @@ -5337,6 +5343,7 @@ packages: /type-fest@0.20.2: resolution: {integrity: sha512-Ne+eE4r0/iWnpAxD852z3A+N0Bt5RN//NjJwRd2VFHEmrywxf5vsZlh4R6lixl6B+wz/8d+maTSAkN1FIkI3LQ==} engines: {node: '>=10'} + dev: true /type-fest@1.4.0: resolution: {integrity: sha512-yGSza74xk0UG8k+pLh5oeoYirvIiWo5t0/o3zHHAO2tRDiZcxWP7fywNlXhqb6/r6sWvwi+RsyQMWhVLe4BVuA==} @@ -5798,5 +5805,5 @@ packages: eslint: '>=8.40.0' dependencies: eslint: 9.13.0 - globals: 13.23.0 + globals: 16.4.0 dev: false From e1c6455588022451256a680bab701d38b13ba0c1 Mon Sep 17 00:00:00 2001 From: silverwind Date: Thu, 18 Sep 2025 09:03:24 +0200 Subject: [PATCH 2/5] use Object.prototype.hasOwnProperty --- src/rules/prefer-web-first-assertions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rules/prefer-web-first-assertions.ts b/src/rules/prefer-web-first-assertions.ts index 3d6e0e72..a868a8f5 100644 --- a/src/rules/prefer-web-first-assertions.ts +++ b/src/rules/prefer-web-first-assertions.ts @@ -85,7 +85,7 @@ export default createRule({ // Playwright method must be supported const method = getStringValue(call.callee.property) const methodConfig = methods[method] - if (!Object.hasOwn(methods, method)) return + if (!Object.prototype.hasOwnProperty.call(methods, method)) return // Change the matcher const notModifier = fnCall.modifiers.find( From e65bc8bb1f3fbcdf216841edb41483f052f37983 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 19 Sep 2025 08:36:26 +0200 Subject: [PATCH 3/5] revert and bump typescript target --- src/rules/prefer-web-first-assertions.ts | 2 +- tsconfig.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rules/prefer-web-first-assertions.ts b/src/rules/prefer-web-first-assertions.ts index a868a8f5..3d6e0e72 100644 --- a/src/rules/prefer-web-first-assertions.ts +++ b/src/rules/prefer-web-first-assertions.ts @@ -85,7 +85,7 @@ export default createRule({ // Playwright method must be supported const method = getStringValue(call.callee.property) const methodConfig = methods[method] - if (!Object.prototype.hasOwnProperty.call(methods, method)) return + if (!Object.hasOwn(methods, method)) return // Change the matcher const notModifier = fnCall.modifiers.find( diff --git a/tsconfig.json b/tsconfig.json index 3b8e8ddd..84d2d2f5 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "target": "es2020", + "target": "es2022", "module": "nodenext", "moduleResolution": "nodenext", "strict": true, From dc1136a28828cfe610a5c7b0824ab204a954d4dd Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 19 Sep 2025 08:53:10 +0200 Subject: [PATCH 4/5] bump to node 16.9.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 21a2806b..38ea8842 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "examples" ], "engines": { - "node": ">=16.6.0" + "node": ">=16.9.0" }, "type": "module", "types": "./index.d.ts", From 2f3824525b3a4a3f2d76e07ef1a730fc8f23caf5 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 19 Sep 2025 08:54:23 +0200 Subject: [PATCH 5/5] update lockfile --- pnpm-lock.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 92697577..db271691 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -5800,7 +5800,7 @@ packages: resolution: {directory: '', type: directory} id: 'file:' name: eslint-plugin-playwright - engines: {node: '>=16.6.0'} + engines: {node: '>=16.9.0'} peerDependencies: eslint: '>=8.40.0' dependencies: