[combobox][typescript] onValueChange value is nullable

[mgray88]

Bug report

Current behavior

value is not correctly typed as | null

Expected behavior

Since value is nullable, it should be expressed as such in Typescript

Base UI version

1.0.0-beta.4

[atomiks]

Are you referring to defaultValue or value inference?

It's nullable provided the useState call has it specified

function App() {
  const [value, setValue] = React.useState<string | null>('a');
  return (
    <Combobox.Root
      value={value}
      onValueChange={(newValue) => {
                      ^string | null
      }}
    />
  );
}

Some context: #2372

[mgray88]

Ah, in this particular case I was using it uncontrolled

<Combobox.Root
  items={source}
  defaultOpen
  defaultInputValue={val}
  onValueChange={(value) => {
                  ^string
  }}
/>

[atomiks]

Yeah okay, the type in onValueChange should include | null if value is unspecified. This also applies to Select.

[github-actions]

This fix will be available in the next npm release of Base UI.

In the meantime, you can try it out on our Canary release channel:

npm i https://pkg.pr.new/@base-ui-components/react@2897