Merge pull request #1946 from multiversx/send-to-non-existent-address

Sync with scenario v1.5.0

Author: andrei-marinica

.github/workflows/actions.yml

@@ -18,7 +18,7 @@ jobs:
     with:
       rust-toolchain: 1.85
       path-to-sc-meta: framework/meta
-      mx-scenario-go-version: v3.0.0
+      mx-scenario-go-version: v4.0.0
       enable-interactor-tests: true
       coverage-args: --ignore-filename-regex='meta/src' --ignore-filename-regex='wasm-adapter' --ignore-filename-regex='benchmarks/' --ignore-filename-regex='tests/' --output ./coverage.md
     secrets:

.github/workflows/template-test-current.yml

@@ -28,7 +28,7 @@ jobs:
         run: |
           cargo install wasm-opt
           cargo install --path framework/meta
-          sc-meta install mx-scenario-go --tag v3.0.0
+          sc-meta install mx-scenario-go --tag v4.0.0
 
           which wasm-opt
           which mx-scenario-go

.github/workflows/template-test-released.yml

@@ -28,7 +28,7 @@ jobs:
         run: |
           cargo install wasm-opt
           cargo install --path framework/meta
-          sc-meta install mx-scenario-go --tag v3.0.0
+          sc-meta install mx-scenario-go --tag v4.0.0
 
           which wasm-opt
           which mx-scenario-go

contracts/feature-tests/basic-features/interact/Cargo.toml

@@ -16,8 +16,8 @@ path = "src/bf_interact.rs"
 clap = { version = "4.4.7", features = ["derive"] }
 serde = { version = "1.0", features = ["derive"] }
 tokio = { version = "1.24" }
-toml = "0.8.6"
 serial_test = { version = "3.2.0" }
+toml = "0.8.6"
 system-sc-interact = { path = "../../../../tools/interactor-system-func-calls" }
 
 [dependencies.basic-features]

contracts/feature-tests/basic-features/interact/tests/bf_interact_cs_test.rs

@@ -1,7 +1,12 @@
 use basic_features_interact::{BasicFeaturesInteract, Config};
-use multiversx_sc_snippets::imports::{
-    BigUint, EgldDecimals, EsdtLocalRole, EsdtTokenType, ManagedBuffer, ManagedDecimal,
-    ManagedOption, ManagedVec, RustBigUint, StaticApi,
+use multiversx_sc_snippets::{
+    imports::{
+        BigUint, ESDTSystemSCAddress, ESDTSystemSCProxy, EgldDecimals, EsdtLocalRole,
+        EsdtTokenPayment, EsdtTokenType, FungibleTokenProperties, ManagedBuffer, ManagedDecimal,
+        ManagedOption, ManagedVec, ReturnsNewTokenIdentifier, RustBigUint, StaticApi,
+        TokenIdentifier,
+    },
+    test_wallets, InteractorRunAsync,
 };
 use serial_test::serial;
 use system_sc_interact::SysFuncCallsInteract;
@@ -35,6 +40,60 @@ async fn simulator_basic_features_test() {
 }
 
 #[tokio::test]
+#[serial]
+#[cfg_attr(not(feature = "chain-simulator-tests"), ignore)]
+async fn send_esdt_to_non_existent_address_test() {
+    let registered_wallet_address = test_wallets::mike().to_address();
+    let not_registered_wallet_address = test_wallets::alice().to_address();
+
+    let mut chain_simulator_interact =
+        BasicFeaturesInteract::init(Config::chain_simulator_config()).await;
+
+    let token = chain_simulator_interact
+        .interactor
+        .tx()
+        .from(&registered_wallet_address)
+        .to(ESDTSystemSCAddress)
+        .gas(100_000_000u64)
+        .typed(ESDTSystemSCProxy)
+        .issue_fungible(
+            BigUint::from(50000000000000000u64),
+            "test",
+            "TEST",
+            100u16,
+            FungibleTokenProperties {
+                num_decimals: 0usize,
+                can_freeze: true,
+                can_wipe: true,
+                can_pause: true,
+                can_mint: true,
+                can_burn: true,
+                can_change_owner: true,
+                can_upgrade: true,
+                can_add_special_roles: true,
+            },
+        )
+        .returns(ReturnsNewTokenIdentifier)
+        .run()
+        .await;
+
+    // send to not registered address
+    chain_simulator_interact
+        .interactor
+        .tx()
+        .from(&registered_wallet_address)
+        .to(&not_registered_wallet_address)
+        .esdt(EsdtTokenPayment::new(
+            TokenIdentifier::from_esdt_bytes(token.clone()),
+            1,
+            BigUint::from(10u16),
+        ))
+        .run()
+        .await;
+}
+
+#[tokio::test]
+#[serial]
 #[ignore = "signature verification is currently unavailable"]
 async fn simulator_crypto_test() {
     let mut bf_interact = BasicFeaturesInteract::init(Config::chain_simulator_config()).await;

contracts/feature-tests/basic-features/scenarios/send_esdt_to_nonexisting_account.scen.json

@@ -0,0 +1,97 @@
+{
+    "comment": "simple ESDT transfer to nonexistent account, no SC",
+    "steps": [
+        {
+            "step": "setState",
+            "accounts": {
+                "address:A": {
+                    "nonce": "0",
+                    "balance": "0x1000000000",
+                    "esdt": {
+                        "str:TOK-123456": "150"
+                    }
+                }
+            }
+        },
+        {
+            "step": "transfer",
+            "id": "1",
+            "tx": {
+                "from": "address:A",
+                "to": "address:B",
+                "esdtValue": [
+                    {
+                        "tokenIdentifier": "str:TOK-123456",
+                        "value": "100"
+                    }
+                ],
+                "gasLimit": "0x100000000",
+                "gasPrice": "0x01"
+            }
+        },
+        {
+            "step": "checkState",
+            "id": "check-1",
+            "comment": "check after tx 1",
+            "accounts": {
+                "address:A": {
+                    "nonce": "1",
+                    "balance": "0xf00000000",
+                    "esdt": {
+                        "str:TOK-123456": "50"
+                    },
+                    "storage": {},
+                    "code": ""
+                },
+                "address:B": {
+                    "nonce": "0",
+                    "esdt": {
+                        "str:TOK-123456": "100"
+                    },
+                    "storage": {},
+                    "code": ""
+                }
+            }
+        },
+        {
+            "step": "transfer",
+            "id": "2",
+            "tx": {
+                "from": "address:A",
+                "to": "address:B",
+                "esdtValue": [
+                    {
+                        "tokenIdentifier": "str:TOK-123456",
+                        "value": "50"
+                    }
+                ],
+                "gasLimit": "0x100000000",
+                "gasPrice": "0x01"
+            }
+        },
+        {
+            "step": "checkState",
+            "id": "check-2",
+            "comment": "check after tx 2",
+            "accounts": {
+                "address:A": {
+                    "nonce": "2",
+                    "balance": "0xe00000000",
+                    "esdt": {
+                        "str:TOK-123456": "0"
+                    },
+                    "storage": {},
+                    "code": ""
+                },
+                "address:B": {
+                    "nonce": "0",
+                    "esdt": {
+                        "str:TOK-123456": "150"
+                    },
+                    "storage": {},
+                    "code": ""
+                }
+            }
+        }
+    ]
+}

contracts/feature-tests/basic-features/tests/basic_features_scenario_go_test.rs

@@ -338,6 +338,11 @@ fn small_num_overflow_go() {
     world().run("scenarios/small_num_overflow.scen.json");
 }
 
+#[test]
+fn send_esdt_to_nonexisting_account_go() {
+    world().run("scenarios/send_esdt_to_nonexisting_account.scen.json");
+}
+
 #[test]
 fn storage_big_int_go() {
     world().run("scenarios/storage_big_int.scen.json");

contracts/feature-tests/basic-features/tests/basic_features_scenario_rs_test.rs

@@ -360,6 +360,12 @@ fn small_num_overflow_rs() {
     world().run("scenarios/small_num_overflow.scen.json");
 }
 
+#[test]
+#[ignore = "unsupported"]
+fn send_esdt_to_nonexisting_account_rs() {
+    world().run("scenarios/send_esdt_to_nonexisting_account.scen.json");
+}
+
 #[test]
 fn storage_big_int_rs() {
     world().run("scenarios/storage_big_int.scen.json");

contracts/feature-tests/payable-features/interactor/src/payable_interactor.rs

@@ -26,6 +26,11 @@ pub async fn adder_cli() {
         Some(payable_interactor_cli::InteractCliCommand::AllTransfers) => {
             basic_interact.check_all_transfers().await;
         },
+        Some(payable_interactor_cli::InteractCliCommand::MultiTransferWithOneEGLD) => {
+            basic_interact
+                .check_multi_transfer_only_egld_transfer()
+                .await;
+        },
         None => {},
     }
 }
@@ -70,7 +75,27 @@ impl PayableInteract {
             .await;
 
         println!("new address: {new_address}");
-        self.state.set_adder_address(new_address);
+        self.state.set_payable_features_address(new_address);
+    }
+
+    pub async fn check_multi_transfer_only_egld_transfer(&mut self) {
+        let mut payment = MultiEgldOrEsdtPayment::new();
+        payment.push(EgldOrEsdtTokenPayment::egld_payment(1_0000u64.into()));
+
+        let result = self
+            .interactor
+            .tx()
+            .from(&self.wallet_address)
+            .to(self.state.current_payable_features_address())
+            .gas(6_000_000u64)
+            .typed(payable_features_proxy::PayableFeaturesProxy)
+            .payable_all_transfers()
+            .payment(payment)
+            .returns(ReturnsResult)
+            .run()
+            .await;
+
+        println!("Result: {result:?}");
     }
 
     pub async fn check_all_transfers(&mut self) {
@@ -82,7 +107,7 @@ impl PayableInteract {
             .interactor
             .tx()
             .from(&self.wallet_address)
-            .to(self.state.current_adder_address())
+            .to(self.state.current_payable_features_address())
             .gas(6_000_000u64)
             .typed(payable_features_proxy::PayableFeaturesProxy)
             .payable_all_transfers()

contracts/feature-tests/payable-features/interactor/src/payable_interactor_cli.rs

@@ -16,4 +16,6 @@ pub enum InteractCliCommand {
     Deploy,
     #[command(name = "at", about = "Check all transfers")]
     AllTransfers,
+    #[command(name = "mt", about = "Check multi transfer with one EGLD")]
+    MultiTransferWithOneEGLD,
 }