increase coverage

jensens · jensens · commit bdd0c70d723d · 2025-10-20T12:31:28.000+02:00
diff --git a/tests/data/config_samples/basic_config.ini b/tests/data/config_samples/basic_config.ini
@@ -0,0 +1,8 @@
+[settings]
+requirements-in = requirements.txt
+requirements-out = requirements-mxdev.txt
+constraints-out = constraints-mxdev.txt
+
+[example.package]
+url = https://github.com/example/package.git
+branch = main
diff --git a/tests/data/config_samples/config_invalid_mode.ini b/tests/data/config_samples/config_invalid_mode.ini
@@ -0,0 +1,6 @@
+[settings]
+requirements-in = requirements.txt
+default-install-mode = invalid
+
+[example.package]
+url = https://github.com/example/package.git
diff --git a/tests/data/config_samples/config_no_url.ini b/tests/data/config_samples/config_no_url.ini
@@ -0,0 +1,5 @@
+[settings]
+requirements-in = requirements.txt
+
+[example.package]
+branch = main
diff --git a/tests/data/config_samples/config_package_invalid_mode.ini b/tests/data/config_samples/config_package_invalid_mode.ini
@@ -0,0 +1,6 @@
+[settings]
+requirements-in = requirements.txt
+
+[example.package]
+url = https://github.com/example/package.git
+install-mode = badmode
diff --git a/tests/data/config_samples/config_with_extras.ini b/tests/data/config_samples/config_with_extras.ini
@@ -0,0 +1,11 @@
+[settings]
+requirements-in = requirements.txt
+default-target = ./sources
+threads = 8
+main-package = -e .[test]
+
+[example.package]
+url = https://github.com/example/package.git
+extras = test,docs
+subdirectory = packages/core
+install-mode = skip
diff --git a/tests/data/config_samples/config_with_ignores.ini b/tests/data/config_samples/config_with_ignores.ini
@@ -0,0 +1,8 @@
+[settings]
+requirements-in = requirements.txt
+ignores =
+    ignored.package
+    another.ignored
+
+[example.package]
+url = https://github.com/example/package.git
diff --git a/tests/data/config_samples/config_with_overrides.ini b/tests/data/config_samples/config_with_overrides.ini
@@ -0,0 +1,8 @@
+[settings]
+requirements-in = requirements.txt
+version-overrides =
+    requests==2.28.0
+    urllib3==1.26.9
+
+[example.package]
+url = https://github.com/example/package.git
diff --git a/tests/data/requirements/basic_requirements.txt b/tests/data/requirements/basic_requirements.txt
@@ -0,0 +1,3 @@
+requests>=2.28.0
+urllib3>=1.26.9
+packaging>=21.0
diff --git a/tests/data/requirements/constraints.txt b/tests/data/requirements/constraints.txt
@@ -0,0 +1,3 @@
+requests==2.28.0
+urllib3==1.26.9
+packaging==21.3
diff --git a/tests/data/requirements/nested_requirements.txt b/tests/data/requirements/nested_requirements.txt
@@ -0,0 +1,2 @@
+-r other_requirements.txt
+requests
diff --git a/tests/data/requirements/other_requirements.txt b/tests/data/requirements/other_requirements.txt
@@ -0,0 +1,2 @@
+urllib3
+packaging
diff --git a/tests/data/requirements/requirements_with_constraints.txt b/tests/data/requirements/requirements_with_constraints.txt
@@ -0,0 +1,4 @@
+-c constraints.txt
+requests
+urllib3
+packaging
diff --git a/tests/test_config.py b/tests/test_config.py
@@ -0,0 +1,186 @@
+import pathlib
+import pytest
+
+
+def test_to_bool():
+    """Test the to_bool helper function."""
+    from mxdev.config import to_bool
+
+    # String values
+    assert to_bool("true") is True
+    assert to_bool("True") is True
+    assert to_bool("TRUE") is True
+    assert to_bool("on") is True
+    assert to_bool("ON") is True
+    assert to_bool("yes") is True
+    assert to_bool("YES") is True
+    assert to_bool("1") is True
+
+    assert to_bool("false") is False
+    assert to_bool("False") is False
+    assert to_bool("no") is False
+    assert to_bool("0") is False
+    assert to_bool("anything") is False
+
+    # Non-string values
+    assert to_bool(True) is True
+    assert to_bool(False) is False
+    assert to_bool(1) is True
+    assert to_bool(0) is False
+    assert to_bool([1, 2]) is True
+    assert to_bool([]) is False
+
+
+def test_configuration_basic():
+    """Test basic Configuration initialization."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    config = Configuration(str(base / "basic_config.ini"))
+
+    assert config.settings["requirements-in"] == "requirements.txt"
+    assert config.settings["requirements-out"] == "requirements-mxdev.txt"
+    assert config.settings["constraints-out"] == "constraints-mxdev.txt"
+    assert "example.package" in config.packages
+    assert config.packages["example.package"]["url"] == "https://github.com/example/package.git"
+    assert config.packages["example.package"]["branch"] == "main"
+
+
+def test_configuration_properties():
+    """Test Configuration property methods."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    config = Configuration(str(base / "basic_config.ini"))
+
+    assert config.infile == "requirements.txt"
+    assert config.out_requirements == "requirements-mxdev.txt"
+    assert config.out_constraints == "constraints-mxdev.txt"
+    assert "example.package" in config.package_keys
+    assert config.override_keys == []
+
+
+def test_configuration_with_overrides():
+    """Test Configuration with version overrides."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    config = Configuration(str(base / "config_with_overrides.ini"))
+
+    assert "requests" in config.overrides
+    assert config.overrides["requests"] == "requests==2.28.0"
+    assert "urllib3" in config.overrides
+    assert config.overrides["urllib3"] == "urllib3==1.26.9"
+    assert "requests" in config.override_keys
+    assert "urllib3" in config.override_keys
+
+
+def test_configuration_with_ignores():
+    """Test Configuration with ignored packages."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    config = Configuration(str(base / "config_with_ignores.ini"))
+
+    assert "ignored.package" in config.ignore_keys
+    assert "another.ignored" in config.ignore_keys
+
+
+def test_configuration_invalid_default_install_mode():
+    """Test Configuration with invalid default-install-mode."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    with pytest.raises(ValueError, match="default-install-mode must be one of"):
+        Configuration(str(base / "config_invalid_mode.ini"))
+
+
+def test_configuration_invalid_package_install_mode():
+    """Test Configuration with invalid package install-mode."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    with pytest.raises(ValueError, match="install-mode in .* must be one of"):
+        Configuration(str(base / "config_package_invalid_mode.ini"))
+
+
+def test_configuration_no_url():
+    """Test Configuration with package missing URL."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    with pytest.raises(ValueError, match="has no URL set"):
+        Configuration(str(base / "config_no_url.ini"))
+
+
+def test_configuration_with_extras():
+    """Test Configuration with extras and subdirectory."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    config = Configuration(str(base / "config_with_extras.ini"))
+
+    pkg = config.packages["example.package"]
+    assert pkg["extras"] == "test,docs"
+    assert pkg["subdirectory"] == "packages/core"
+    assert pkg["install-mode"] == "skip"
+    assert config.settings.get("main-package") == "-e .[test]"
+    assert config.settings.get("default-target") == "./sources"
+    # threads from INI is ignored, always defaults to 4 or override_args
+    assert config.settings.get("threads") == "4"
+
+
+def test_configuration_override_args_offline():
+    """Test Configuration with offline override argument."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    config = Configuration(
+        str(base / "basic_config.ini"),
+        override_args={"offline": True}
+    )
+
+    assert config.settings["offline"] == "true"
+    # Package should inherit offline setting
+    assert config.packages["example.package"].get("offline") is True
+
+
+def test_configuration_override_args_threads():
+    """Test Configuration with threads override argument."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    config = Configuration(
+        str(base / "basic_config.ini"),
+        override_args={"threads": 16}
+    )
+
+    assert config.settings["threads"] == "16"
+
+
+def test_configuration_default_threads():
+    """Test Configuration default threads value."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    config = Configuration(str(base / "basic_config.ini"))
+
+    # Should default to 4 if not specified
+    assert config.settings["threads"] == "4"
+
+
+def test_configuration_package_defaults():
+    """Test that Configuration applies package defaults correctly."""
+    from mxdev.config import Configuration
+
+    base = pathlib.Path(__file__).parent / "data" / "config_samples"
+    config = Configuration(str(base / "basic_config.ini"))
+
+    pkg = config.packages["example.package"]
+    assert pkg["branch"] == "main"
+    assert pkg["extras"] == ""
+    assert pkg["subdirectory"] == ""
+    assert pkg["target"] == "sources"  # default-target not set, should be "sources"
+    assert pkg["install-mode"] == "direct"  # default mode
+    assert pkg["vcs"] == "git"
+    assert "path" in pkg
diff --git a/tests/test_entry_points.py b/tests/test_entry_points.py
@@ -0,0 +1,124 @@
+import pytest
+from unittest.mock import patch, MagicMock
+
+
+def test_has_importlib_entrypoints_constant():
+    """Test HAS_IMPORTLIB_ENTRYPOINTS constant is defined."""
+    from mxdev.entry_points import HAS_IMPORTLIB_ENTRYPOINTS
+
+    # Should be a boolean
+    assert isinstance(HAS_IMPORTLIB_ENTRYPOINTS, bool)
+
+
+def test_load_eps_by_group_with_python312():
+    """Test load_eps_by_group with Python 3.12+ API (group parameter)."""
+    from mxdev.entry_points import load_eps_by_group
+
+    # Mock entry points for Python 3.12+ API
+    mock_ep1 = MagicMock()
+    mock_ep1.name = "test-ep1"
+    mock_ep2 = MagicMock()
+    mock_ep2.name = "test-ep2"
+    mock_eps = [mock_ep1, mock_ep2]
+
+    with patch('mxdev.entry_points.HAS_IMPORTLIB_ENTRYPOINTS', True):
+        with patch('mxdev.entry_points.entry_points', return_value=mock_eps) as mock_entry_points:
+            result = load_eps_by_group("test-group")
+
+            # Should call entry_points with group parameter
+            mock_entry_points.assert_called_once_with(group="test-group")
+            # Should return unique list
+            assert len(result) == 2
+            assert mock_ep1 in result
+            assert mock_ep2 in result
+
+
+def test_load_eps_by_group_with_old_python():
+    """Test load_eps_by_group with Python <3.12 API (no group parameter)."""
+    from mxdev.entry_points import load_eps_by_group
+
+    # Mock entry points for older Python API
+    mock_ep1 = MagicMock()
+    mock_ep1.name = "test-ep1"
+    mock_ep2 = MagicMock()
+    mock_ep2.name = "test-ep2"
+
+    mock_eps_dict = {
+        "test-group": [mock_ep1, mock_ep2],
+        "other-group": []
+    }
+
+    with patch('mxdev.entry_points.HAS_IMPORTLIB_ENTRYPOINTS', False):
+        with patch('mxdev.entry_points.entry_points', return_value=mock_eps_dict) as mock_entry_points:
+            result = load_eps_by_group("test-group")
+
+            # Should call entry_points without parameters
+            mock_entry_points.assert_called_once_with()
+            # Should return unique list from the group
+            assert len(result) == 2
+            assert mock_ep1 in result
+            assert mock_ep2 in result
+
+
+def test_load_eps_by_group_group_not_found():
+    """Test load_eps_by_group when group doesn't exist (old Python API)."""
+    from mxdev.entry_points import load_eps_by_group
+
+    mock_eps_dict = {
+        "other-group": []
+    }
+
+    with patch('mxdev.entry_points.HAS_IMPORTLIB_ENTRYPOINTS', False):
+        with patch('mxdev.entry_points.entry_points', return_value=mock_eps_dict):
+            result = load_eps_by_group("nonexistent-group")
+
+            # Should return empty list when group not found
+            assert result == []
+
+
+def test_load_eps_by_group_deduplicates():
+    """Test load_eps_by_group removes duplicates using set()."""
+    from mxdev.entry_points import load_eps_by_group
+
+    # Create mock entry points - same object twice to test deduplication
+    mock_ep = MagicMock()
+    mock_ep.name = "test-ep"
+    # Make it hashable for set()
+    mock_ep.__hash__ = lambda self: hash("test-ep")
+    mock_eps = [mock_ep, mock_ep]  # Duplicate
+
+    with patch('mxdev.entry_points.HAS_IMPORTLIB_ENTRYPOINTS', True):
+        with patch('mxdev.entry_points.entry_points', return_value=mock_eps):
+            result = load_eps_by_group("test-group")
+
+            # Should deduplicate - only one entry
+            assert len(result) == 1
+            assert mock_ep in result
+
+
+def test_load_eps_by_group_empty_group():
+    """Test load_eps_by_group with empty group results."""
+    from mxdev.entry_points import load_eps_by_group
+
+    with patch('mxdev.entry_points.HAS_IMPORTLIB_ENTRYPOINTS', True):
+        with patch('mxdev.entry_points.entry_points', return_value=[]):
+            result = load_eps_by_group("empty-group")
+
+            # Should return empty list
+            assert result == []
+
+
+def test_load_eps_by_group_old_python_empty_group():
+    """Test load_eps_by_group with empty group on old Python API."""
+    from mxdev.entry_points import load_eps_by_group
+
+    mock_eps_dict = {
+        "test-group": []
+    }
+
+    with patch('mxdev.entry_points.HAS_IMPORTLIB_ENTRYPOINTS', False):
+        with patch('mxdev.entry_points.entry_points', return_value=mock_eps_dict):
+            result = load_eps_by_group("test-group")
+
+            # Should return empty list
+            assert result == []
diff --git a/tests/test_git_additional.py b/tests/test_git_additional.py
diff --git a/tests/test_hooks.py b/tests/test_hooks.py
diff --git a/tests/test_logging.py b/tests/test_logging.py
diff --git a/tests/test_main.py b/tests/test_main.py
diff --git a/tests/test_processing.py b/tests/test_processing.py
diff --git a/tests/test_vcs_filesystem.py b/tests/test_vcs_filesystem.py

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+requests>=2.28.0`
	`2`	`+urllib3>=1.26.9`
	`3`	`+packaging>=21.0`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+requests==2.28.0`
	`2`	`+urllib3==1.26.9`
	`3`	`+packaging==21.3`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+-r other_requirements.txt`
	`2`	`+requests`