Fix: no-unsupported-features had a false negative (fixes #40)

Author: mysticatea

lib/rules/no-unsupported-features.js

@@ -27,6 +27,7 @@ var DESTRUCTURING_PARENT_TYPE = /^(?:Function(?:Declaration|Expression)|ArrowFun
 var BINARY_NUMBER = /^0[bB]/;
 var OCTAL_NUMBER = /^0[oO]/;
 var UNICODE_ESC = /\\u\{.+?\}/;
+var GET_OR_SET = /^(?:g|s)et$/;
 var NEW_BUILTIN_TYPES = [
     "Int8Array", "Uint8Array", "Uint8ClampedArray", "Int16Array", "Uint16Array",
     "Int32Array", "Uint32Array", "Float32Array", "Float64Array", "DataView",
@@ -522,7 +523,12 @@ module.exports = function(context) {
             if (node.parent.type === "ObjectExpression" &&
                 (node.computed || node.shorthand || node.method)
             ) {
-                report(node, "objectLiteralExtensions");
+                if (node.shorthand && GET_OR_SET.test(node.key.name)) {
+                    report(node, "objectPropertyShorthandOfGetSet");
+                }
+                else {
+                    report(node, "objectLiteralExtensions");
+                }
             }
         },
 

lib/util/features.js

@@ -35,6 +35,11 @@ module.exports = {
         name: "Object Literal Extensions",
         node: 4
     },
+    "objectPropertyShorthandOfGetSet": {
+        alias: ["syntax", "objectLiteralExtensions"],
+        name: "Property Shorthand of 'get' and 'set'",
+        node: 6
+    },
     "forOf": {
         alias: ["syntax"],
         name: "'for..of' Loops",

tests/lib/rules/no-unsupported-features.js

@@ -143,6 +143,13 @@ ruleTester.run("no-unsupported-features", rule, [
         errors: 5,
         supported: 4
     },
+    {
+        keys: ["objectPropertyShorthandOfGetSet", "objectLiteralExtensions", "syntax"],
+        name: "Property Shorthand of 'get' and 'set'",
+        code: "var obj = {get, set}",
+        errors: 2,
+        supported: 6
+    },
     {
         keys: ["forOf", "syntax"],
         name: "'for..of' Loops",