Fix: shebang should allow CLI flags (fixes #51)

Author: mysticatea

lib/rules/shebang.js

@@ -20,6 +20,7 @@ var getPackageJson = require("../util/get-package-json")
 
 var NODE_SHEBANG = "#!/usr/bin/env node\n"
 var SHEBANG_PATTERN = /^(#!.+?)?(\r)?\n/
+var NODE_SHEBANG_PATTERN = /#!\/usr\/bin\/env node(?: [^\r\n]+?)?\n/
 
 /**
  * Checks whether or not a given path is a `bin` file.
@@ -88,7 +89,7 @@ module.exports = function(context) {
 
     return {
         Program: function(node) {
-            if (needsShebang ? info.shebang === NODE_SHEBANG : !info.shebang) {
+            if (needsShebang ? NODE_SHEBANG_PATTERN.test(info.shebang) : !info.shebang) {
                 // Good the shebang target.
                 // Checks BOM and \r.
                 if (needsShebang && info.bom) {

tests/lib/rules/shebang.js

@@ -126,6 +126,12 @@ ruleTester.run("shebang", rule, {
             filename: fixture("string-bin/lib/test.js"),
             code: "\n\n\nhello();",
         },
+
+        // https://github.com/mysticatea/eslint-plugin-node/issues/51
+        {
+            filename: fixture("string-bin/bin/test.js"),
+            code: "#!/usr/bin/env node --harmony\nhello();",
+        },
     ],
     invalid: [
         {
@@ -303,5 +309,13 @@ ruleTester.run("shebang", rule, {
                 "This file must have Unix linebreaks (LF).",
             ],
         },
+
+        // https://github.com/mysticatea/eslint-plugin-node/issues/51
+        {
+            filename: fixture("string-bin/lib/test.js"),
+            code: "#!/usr/bin/env node --harmony\nhello();",
+            output: "hello();",
+            errors: ["This file needs no shebang."],
+        },
     ],
 })