Skip to content

Commit 261c4bd

Browse files
committed
Fix: upgrade my ESLint config and address TODOs.
1 parent 01ede1d commit 261c4bd

File tree

4 files changed

+3
-15
lines changed

4 files changed

+3
-15
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
],
1414
"scripts": {
1515
"clean": "rimraf .nyc_output coverage",
16-
"lint": "eslint bin lib test",
16+
"lint": "node bin/index.js \">=4\" eslint bin lib test",
1717
"coverage": "wait-on coverage/lcov-report/index.html && opener coverage/lcov-report/index.html",
1818
"coveralls": "cat coverage/lcov.info | coveralls",
1919
"preversion": "run-s clean test",
@@ -32,8 +32,8 @@
3232
"babel-register": "^6.9.0",
3333
"chokidar-cli": "^1.2.0",
3434
"coveralls": "^2.11.9",
35-
"eslint": "^2.13.1",
36-
"eslint-config-mysticatea": "^4.0.0",
35+
"eslint": "^3.0.0",
36+
"eslint-config-mysticatea": "^5.0.0",
3737
"mocha": "^2.5.3",
3838
"npm-run-all": "^2.3.0",
3939
"nyc": "^6.6.1",

test/lib/api.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ function run(range, options) {
5353
})
5454
}
5555

56-
// TODO: https://github.com/mysticatea/eslint-plugin/issues/7
57-
//eslint-disable-next-line mysticatea/block-scoped-var
5856
function runSync(range, options) {
5957
var fail = Boolean(options && options.fail)
6058
var result = spawnIfNodeVersionSatisfies.sync(
@@ -74,7 +72,4 @@ function runSync(range, options) {
7472
//------------------------------------------------------------------------------
7573

7674
exports.run = run
77-
78-
// TODO: https://github.com/mysticatea/eslint-plugin/issues/7
79-
//eslint-disable-next-line mysticatea/block-scoped-var
8075
exports.runSync = runSync

test/lib/buffer-stream.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,4 @@ Object.defineProperty(BufferStream.prototype, "_write", {
3232
writable: true,
3333
})
3434

35-
// TODO: https://github.com/mysticatea/eslint-plugin/issues/7
36-
//eslint-disable-next-line mysticatea/block-scoped-var
3735
module.exports = BufferStream

test/lib/cli.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ function run(args) {
4343
})
4444
}
4545

46-
// TODO: https://github.com/mysticatea/eslint-plugin/issues/7
47-
//eslint-disable-next-line mysticatea/block-scoped-var
4846
function runToCheck(range, options) {
4947
var fail = Boolean(options && options.fail)
5048
return run([
@@ -59,7 +57,4 @@ function runToCheck(range, options) {
5957
//------------------------------------------------------------------------------
6058

6159
exports.run = run
62-
63-
// TODO: https://github.com/mysticatea/eslint-plugin/issues/7
64-
//eslint-disable-next-line mysticatea/block-scoped-var
6560
exports.runToCheck = runToCheck

0 commit comments

Comments
 (0)