From 8d0f31f72dc4f53676a07137892ca222c78b312f Mon Sep 17 00:00:00 2001 From: eqsdxr Date: Wed, 28 May 2025 10:55:23 +0000 Subject: [PATCH 1/2] Improve log message when PORT env not set --- src/config/config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/config/config.go b/src/config/config.go index d1aaae4..ae36602 100644 --- a/src/config/config.go +++ b/src/config/config.go @@ -99,7 +99,7 @@ func GetConfig() *Config { log.Printf("Set external port from environment -> %s", cfg.Server.ExternalPort) } else { cfg.Server.ExternalPort = cfg.Server.InternalPort - log.Printf("Set external port from environment -> %s", cfg.Server.ExternalPort) + log.Printf("Environment variable PORT not set; using internal port value -> %s", cfg.Server.ExternalPort) } if err != nil { log.Fatalf("Error in parse config %v", err) From f6c1f76bce8783636b3c591d6d0aea765b5eeb3a Mon Sep 17 00:00:00 2001 From: eqsdxr Date: Wed, 28 May 2025 11:03:00 +0000 Subject: [PATCH 2/2] Fix error handling order --- src/config/config.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/config/config.go b/src/config/config.go index ae36602..501f1ca 100644 --- a/src/config/config.go +++ b/src/config/config.go @@ -93,6 +93,10 @@ func GetConfig() *Config { } cfg, err := ParseConfig(v) + if err != nil { + log.Fatalf("Error in parse config %v", err) + } + envPort := os.Getenv("PORT") if envPort != "" { cfg.Server.ExternalPort = envPort @@ -101,9 +105,6 @@ func GetConfig() *Config { cfg.Server.ExternalPort = cfg.Server.InternalPort log.Printf("Environment variable PORT not set; using internal port value -> %s", cfg.Server.ExternalPort) } - if err != nil { - log.Fatalf("Error in parse config %v", err) - } return cfg }