Fixing issue with HttpClient no releasing native stream (#399)

Ellerbach · web-flow · commit 940007a8c080 · 2023-08-08T08:57:56.000+02:00
diff --git a/nanoFramework.System.Net.Http/Http/System.Net._InputNetworkStreamWrapper.cs b/nanoFramework.System.Net.Http/Http/System.Net._InputNetworkStreamWrapper.cs
@@ -474,7 +474,10 @@ protected override void Dispose(bool disposing)
         {
             m_InUse = false;
 
-            if (!m_isClone)
+            // This has been commented because we are not closing the socket properly when using HttpClient
+            // This is causing the socket to remain open and not be released back to the pool
+            // This will require more testing to make sure that this does not break anything else
+            //if (!m_isClone)
             {
                 m_Stream.Close();
 

Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,10 @@ protected override void Dispose(bool disposing)`
`474`	`474`	`{`
`475`	`475`	`m_InUse = false;`
`476`	`476`
`477`		`- if (!m_isClone)`
	`477`	`+ // This has been commented because we are not closing the socket properly when using HttpClient`
	`478`	`+ // This is causing the socket to remain open and not be released back to the pool`
	`479`	`+ // This will require more testing to make sure that this does not break anything else`
	`480`	`+ //if (!m_isClone)`
`478`	`481`	`{`
`479`	`482`	`m_Stream.Close();`
`480`	`483`