fix: update tests for cuDF 25.08.00a (#2700)

* remove xfail

* added is_polars_exception

* catch cudf exception

* coverage happy?

* coverage happier?

* xfail nw.Date

Author: EdAbati

narwhals/_polars/utils.py

@@ -217,6 +217,19 @@ def narwhals_to_native_dtype(  # noqa: C901, PLR0912
     return pl.Unknown()  # pragma: no cover
 
 
+def _is_polars_exception(exception: Exception, backend_version: tuple[int, ...]) -> bool:
+    if backend_version >= (1,):
+        # Old versions of Polars didn't have PolarsError.
+        return isinstance(exception, pl.exceptions.PolarsError)
+    # Last attempt, for old Polars versions.
+    return "polars.exceptions" in str(type(exception))  # pragma: no cover
+
+
+def _is_cudf_exception(exception: Exception) -> bool:
+    # These exceptions are raised when running polars on GPUs via cuDF
+    return str(exception).startswith("CUDF failure")
+
+
 def catch_polars_exception(
     exception: Exception, backend_version: tuple[int, ...]
 ) -> NarwhalsError | Exception:
@@ -230,13 +243,7 @@ def catch_polars_exception(
         return DuplicateError(str(exception))
     elif isinstance(exception, pl.exceptions.ComputeError):
         return ComputeError(str(exception))
-    if backend_version >= (1,) and isinstance(exception, pl.exceptions.PolarsError):
-        # Old versions of Polars didn't have PolarsError.
+    if _is_polars_exception(exception, backend_version) or _is_cudf_exception(exception):
         return NarwhalsError(str(exception))  # pragma: no cover
-    elif backend_version < (1,) and "polars.exceptions" in str(
-        type(exception)
-    ):  # pragma: no cover
-        # Last attempt, for old Polars versions.
-        return NarwhalsError(str(exception))
     # Just return exception as-is.
     return exception

tests/expr_and_series/is_in_test.py

@@ -1,7 +1,5 @@
 from __future__ import annotations
 
-import os
-
 import pytest
 
 import narwhals as nw
@@ -18,16 +16,7 @@ def test_expr_is_in(constructor: Constructor) -> None:
     assert_equal_data(result, expected)
 
 
-def test_expr_is_in_empty_list(
-    constructor: Constructor, request: pytest.FixtureRequest
-) -> None:
-    if "polars_lazy" in str(constructor) and os.environ.get("NARWHALS_POLARS_GPU"):
-        # Traceback:
-        # narwhals.exceptions.ComputeError: RuntimeError:
-        # CUDF failure at:/__w/cudf/cudf/cpp/include/cudf/utilities/type_dispatcher.hpp:567:
-        # Invalid type_id.
-        request.applymarker(pytest.mark.xfail)
-
+def test_expr_is_in_empty_list(constructor: Constructor) -> None:
     df = nw.from_native(constructor(data))
     result = df.select(nw.col("a").is_in([]))
     expected = {"a": [False, False, False, False]}

tests/expr_and_series/lit_test.py

@@ -8,7 +8,13 @@
 import pytest
 
 import narwhals as nw
-from tests.utils import DASK_VERSION, PANDAS_VERSION, Constructor, assert_equal_data
+from tests.utils import (
+    CUDF_VERSION,
+    DASK_VERSION,
+    PANDAS_VERSION,
+    Constructor,
+    assert_equal_data,
+)
 
 if TYPE_CHECKING:
     from narwhals.dtypes import DType
@@ -109,8 +115,11 @@ def test_lit_operation_in_with_columns(
 
 @pytest.mark.skipif(PANDAS_VERSION < (1, 5), reason="too old for pyarrow")
 def test_date_lit(constructor: Constructor, request: pytest.FixtureRequest) -> None:
-    if "dask" in str(constructor):
-        # https://github.com/dask/dask/issues/11637
+    # https://github.com/dask/dask/issues/11637
+    if "dask" in str(constructor) or (
+        # https://github.com/rapidsai/cudf/pull/18832
+        "cudf" in str(constructor) and CUDF_VERSION >= (25, 8, 0)
+    ):
         request.applymarker(pytest.mark.xfail)
     df = nw.from_native(constructor({"a": [1]}))
     result = df.with_columns(nw.lit(date(2020, 1, 1), dtype=nw.Date)).collect_schema()

tests/utils.py

@@ -38,6 +38,7 @@ def get_module_version_as_tuple(module_name: str) -> tuple[int, ...]:
 DASK_VERSION: tuple[int, ...] = get_module_version_as_tuple("dask")
 PYARROW_VERSION: tuple[int, ...] = get_module_version_as_tuple("pyarrow")
 PYSPARK_VERSION: tuple[int, ...] = get_module_version_as_tuple("pyspark")
+CUDF_VERSION: tuple[int, ...] = get_module_version_as_tuple("cudf")
 
 Constructor: TypeAlias = Callable[[Any], "NativeLazyFrame | NativeFrame | DataFrameLike"]
 ConstructorEager: TypeAlias = Callable[[Any], "NativeFrame | DataFrameLike"]