ci: fixup cudf tests (#2899)

* ci: fixup cudf tests

* just skip dask tests, they probably think we are "offering vitamins when they need painkillers" anyway

Author: MarcoGorelli

narwhals/_dask/expr_dt.py

@@ -99,7 +99,8 @@ def func(s: dx.Series, time_zone: str) -> dx.Series:
 
         return self.compliant._with_callable(func, "tz_convert", time_zone=time_zone)
 
-    def timestamp(self, time_unit: TimeUnit) -> DaskExpr:
+    # ignoring coverage due to https://github.com/narwhals-dev/narwhals/issues/2808.
+    def timestamp(self, time_unit: TimeUnit) -> DaskExpr:  # pragma: no cover
         def func(s: dx.Series, time_unit: TimeUnit) -> dx.Series:
             dtype = native_to_narwhals_dtype(
                 s.dtype, self.compliant._version, Implementation.DASK

tests/expr_and_series/division_by_zero_test.py

@@ -1,7 +1,5 @@
 from __future__ import annotations
 
-import os
-
 import pytest
 
 import narwhals as nw
@@ -107,11 +105,6 @@ def test_floordiv_int_by_zero(
     if "polars" in str(constructor) and POLARS_VERSION < (0, 20, 7):
         pytest.skip(reason="bug")
 
-    if "polars_lazy" in str(constructor) and os.environ.get("NARWHALS_POLARS_GPU"):
-        request.applymarker(
-            pytest.mark.xfail(reason="https://github.com/pola-rs/polars/issues/23365")
-        )
-
     data: dict[str, list[int]] = {"a": [left]}
     df = nw.from_native(constructor(data))
     # pyarrow backend floordiv raises divide by zero error

tests/expr_and_series/dt/timestamp_test.py

@@ -51,6 +51,8 @@ def test_timestamp_datetimes(
     time_unit: Literal["ns", "us", "ms"],
     expected: list[int | None],
 ) -> None:
+    if "dask" in str(constructor):
+        pytest.skip(reason="https://github.com/narwhals-dev/narwhals/issues/2808")
     if any(x in str(constructor) for x in ("duckdb", "pyspark", "ibis")):
         request.applymarker(
             pytest.mark.xfail(reason="Backend timestamp conversion not yet implemented")
@@ -95,6 +97,8 @@ def test_timestamp_datetimes_tz_aware(
     time_unit: Literal["ns", "us", "ms"],
     expected: list[int | None],
 ) -> None:
+    if "dask" in str(constructor):
+        pytest.skip(reason="https://github.com/narwhals-dev/narwhals/issues/2808")
     if any(x in str(constructor) for x in ("duckdb", "pyspark", "ibis")):
         request.applymarker(
             pytest.mark.xfail(reason="Backend timestamp conversion not yet implemented")
@@ -150,6 +154,8 @@ def test_timestamp_dates(
     time_unit: Literal["ns", "us", "ms"],
     expected: list[int | None],
 ) -> None:
+    if "dask" in str(constructor):
+        pytest.skip(reason="https://github.com/narwhals-dev/narwhals/issues/2808")
     if any(x in str(constructor) for x in ("duckdb", "pyspark", "ibis")):
         request.applymarker(
             pytest.mark.xfail(reason="Backend timestamp conversion not yet implemented")
@@ -177,6 +183,8 @@ def test_timestamp_dates(
 def test_timestamp_invalid_date(
     request: pytest.FixtureRequest, constructor: Constructor
 ) -> None:
+    if "dask" in str(constructor):
+        pytest.skip(reason="https://github.com/narwhals-dev/narwhals/issues/2808")
     if any(x in str(constructor) for x in ("duckdb", "pyspark", "ibis")):
         request.applymarker(
             pytest.mark.xfail(reason="Backend timestamp conversion not yet implemented")

tests/expr_and_series/name/suffix_test.py

@@ -23,6 +23,11 @@ def test_suffix_after_alias(constructor: Constructor) -> None:
     result = df.select((nw.col("foo")).alias("alias_for_foo").name.suffix(suffix))
     expected = {"alias_for_foo_with_suffix": [1, 2, 3]}
     assert_equal_data(result, expected)
+    result = df.select(
+        nw.col("foo").alias("bar").name.prefix("prefix_").name.suffix("_suffix")
+    )
+    expected = {"prefix_bar_suffix": [1, 2, 3]}
+    assert_equal_data(result, expected)
 
 
 def test_suffix_anonymous(constructor: Constructor) -> None:

tests/modern_polars/pivot_test.py

@@ -8,12 +8,13 @@
 from tests.utils import POLARS_VERSION, ConstructorEager, assert_equal_data
 
 
-@pytest.mark.skipif(POLARS_VERSION < (1, 0), reason="requires polars 1.0+")
 def test_pivot(
     constructor_eager: ConstructorEager, request: pytest.FixtureRequest
 ) -> None:
     if any(x in str(constructor_eager) for x in ("pyarrow_table", "modin")):
         request.applymarker(pytest.mark.xfail)
+    if "polars" in str(constructor_eager) and POLARS_VERSION < (1, 0):
+        pytest.skip()
 
     data = {
         "date": [

tests/modern_polars/unpivot_test.py

@@ -2,30 +2,20 @@
 
 from datetime import datetime
 
-import pytest
-
 import narwhals as nw
-from tests.utils import PYARROW_VERSION, Constructor, assert_equal_data
-
+from tests.utils import Constructor, assert_equal_data
 
-def test_unpivot(constructor: Constructor, request: pytest.FixtureRequest) -> None:
-    if "cudf" in str(constructor) or (
-        "pyarrow_table" in str(constructor) and PYARROW_VERSION < (13, 0, 0)
-    ):
-        request.applymarker(pytest.mark.xfail)
 
+def test_unpivot(constructor: Constructor) -> None:
     data = {
         "date": [datetime(2020, 1, 1), datetime(2020, 1, 2), datetime(2020, 1, 3)],
         "aapl": [110, 100, 105],
         "tsla": [220, 200, 210],
         "msft": [330, 300, 315],
         "nflx": [420, 400, 440],
     }
-
     df = nw.from_native(constructor(data))
-
     result = df.unpivot(index="date", value_name="price").sort(by=["date", "variable"])
-
     expected = {
         "date": [
             *[datetime(2020, 1, 1)] * 4,